Giter Club home page Giter Club logo

app's Introduction

Looking for contributors!!

GitHub App built with Probot that add an appropriate label depend on the PR's status.

Motivation

I spent the time to know Pull requests status during team development. As a team bigger, time becomes more increased. At first it was used internally but I noticed most of people have same problem so I published it as Open Source ✨.

Installation

  1. Go to PRTriage App top page
  2. Click "+ Add to GitHub" button
  3. Choose a repository
  4. That's it ✨

Learn how to install it for GitHub Enterprise.

How it works

Only watching the most recent commit 👀:

  • Do nothing when the PR's title starts from WIP, [WIP] or WIP:.
  • Add the PR: draft lable when the draft PR is created.
  • Add the PR: unreviewed label when the PR does not have any reviews.
  • Add the PR: reviewed-changes-requested label when the PR has reviewed and got Change request event.
  • Add the PR: partially-approved label when PR has reviewd and got Approve from one of the reviewers.
  • Add the PR: review-approved label when the PR has reviewed and got Approve from everyone.
  • Add the PR: merged label when the PR has merged.

Trusted by

Example users include the following GitHub organizations:

vuejs

The Practical Dev

Linio

Redash

And design

Wix

Autify



Contributing

It has adopted a Code of Conduct that we expect project participants to adhere to.
Please read the full text so that you can understand what actions will and will not be tolerated.

Read our contributing guide to learn about our development process, how to propose bugfixes
and improvements, and how to build and test your changes to PRTriage.

License

PRTriage © Sam Yamashita. Released under the Apache 2.0
Authored and maintained by Sam Yamashita with help from contributors.

FOSSA Status

Privacy PolicySecurity Policy

app's People

Contributors

allout58 avatar dependabot-preview[bot] avatar dependabot-support avatar dependabot[bot] avatar elsayed-atef avatar fossabot avatar greenkeeper[bot] avatar greenkeeperio-bot avatar snyk-bot avatar sotayamashita avatar tannakartikey avatar tiagodanin avatar watsonbot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

app's Issues

test

Summary

(Summarize the bug encountered concisely)

Steps to reproduce

(How one can reproduce the issue - this is very important)

Pull Request URL

(If possible, please paste pull request URLs which have errors.)

What is the current bug behavior?

(What actually happens)

What is the expected correct behavior?

(What you should see instead)

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you have any idea to solve the problem, please help us.)

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

App stopped working for a repo

Summary

About a week ago, the app stopped working for all repos within our yreceipts organisation. It no longer adds or changes any labels of any pull requests. I can confirm the app is still enabled and authorised.

Steps to reproduce

For example, request changes on a PR where the app is installed.

Pull Request URL

For example: https://github.com/yreceipts/yreceipts.com/pull/1809

What is the current bug behavior?

Nothing happens.

What is the expected correct behavior?

A label reflecting the current status of the PR should be added and the previous such label removed when said status changes.

Relevant logs and/or screenshots

No logs are available, as the app no longer leaves any noticeable traces.

Possible fixes

N/A

label is changed by editing PR

Summary

A label is changed by editing PR.

Steps to reproduce

  1. Create a PR (should have a PR: unreviewed label)
  2. Change the PR's title
  3. Oops, label is gone 👎

Pull Request URL

(If possible, please paste pull request URLs which have errors.)

What is the current bug behavior?

  1. Create a PR (should have a PR: unreviewed label)
  2. Change the PR's title
  3. Oops, The label is gone 👎

What is the expected correct behavior?

  1. Create a PR (should have a PR: unreviewed label)
  2. Change the PR's title
  3. Nothing happens 💯

Relevant logs and/or screenshots

N/A

Possible fixes

N/A

Change name

pull request のワークフローをサポートするボット

"PR: unreviewed" forgotten

Summary

The bot forgot (a few times) to remove the PR: unreviewed either when it was mistakenly added alongside PR: reviewed-approved (shouldn't that label be PR: review-approved?) like in here or and simply forgot to remove it when a review was approved or changes were requested.

Steps to reproduce

Have someone or a bot open a PR, have a bot (say access-lint) approve the review and watch.

Pull Request URL

What is the current bug's behaviour?

It seems to be activating two events causing a mix of labelling which could persist even after the PR was closed or merged.

What is the expected correct behaviour?

The bot should add and remove the correct label whether a bot or human approved a PR or requested changes to it.

Relevant logs and/or screenshots

There are other repos where that bug occurred but it can be reflected by the example above.

Possible fixes

Possibly adding more checks to ensure that PRs, where multiple reviews are requested that it takes into account when one is an approval and the other one, is either blank (read unreviewed) or requesting changes.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Make labels configurable.

Summary

Please add the ability to customize the labels that will be used. PR: unreviewed, PR: review-approved and PR: reviewed-changes-requested doesn't match our style. While we can obviously fork the app and make the changes, it would be great to make them configurable.

If this feature is done, I would use probot-config to allow for a .github/pr-triage.yml file.

In order to keep the labels under control, if this is implemented, it would be great if it would automatically migrate the existing label names. Do a check to see if the original name exists, and then replace it with the configured name. This way we don't have a ton of PRs that don't have the correct label.

Cannot notice when new issue is created

I cannot notice when new issue is created immediately. I do not want users or contributors to wait 24 hours. I want to replay something immediately If I am up 😄 I do not want to use bot. It is not useful in this situation.

Bot created PRs are not being triaged

When a bot such as Dependabot opens a PR, it is not being triaged (labeled). These cases are still useful because we still need to review these, and it helps us mark what PRs may or may not be reviewed.

Add `PR: reviews-approved` label even though nobody approve PR

!!PLEASE READ IT!!

To make it easier for us to treat your feedback,
we have made a template you can fill out.

Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label.

and verify the issue you're about to submit isn't a duplicate.
Please make separate posts for each feature request or bug report.
Please remove this notice if you're confident your issue isn't a duplicate.

Summary

Add PR: reviews-approved label even though nobody approve PR.

Steps to reproduce

  1. Create a PR
  2. Leave a single comment

Pull Request URL

skip because of permission 😢

What is the current bug behavior?

Add PR: reviewed-approved

What is the expected correct behavior?

Do nothing

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you have any idea to solve the problem, please help us.)

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

ready for use?

Hi @sotayamashita! This bot looks really useful. Should we give it a try on some electron repos? You think it's stable enough?

Update status in merged PR's

Summary
Add status for merged pull requests without approval.

Issue type: Suggestion

Current Behavior:
image

Expected behavior (Suggestion)
image

PRTriage should only be triggered by commit not comment

Summary

Steps to reproduce

  1. Merge PR
  2. Comment

Pull Request URL

N/A

What is the current bug behavior?

PRTriage remove PR: Merged if user comment.

What is the expected correct behavior?

PRTriage should only check commit

Relevant logs and/or screenshots

Screen Shot 2019-06-14 at 14 03 49

Possible fixes

(If you have any idea to solve the problem, please help us.)

Is this working?

Summary

The bot does not seem to be doing anything. I have it installed on a test repo, and no matter what, it does not label anything. Neither a needs-review, or reviewed and needs to be fixed, nothing.

I also looked at the one PR opened on this project, and it doesn't look like the bot is being used here, or it isn't working.

Listen to review dismissals

Summary

When a review is dismissed, the status should update based on other reviews. If there are no other reviews, it should go back to unreviewed. If there are other reviews, the status should depend on them.

Steps to reproduce

Review a PR and approve it. Then dismiss the review.

What is the current bug behavior?

The label stays the same.

What is the expected correct behavior?

The label is removed and goes back to unreviewed.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

A JSON web token could not be decoded

I have created my stand alone deployment for Github Enterprise and I got the following error

08:55:33.581Z ERROR event: {"message":"A JSON web token could not be decoded","documentation_url":"https://developer.github.com/enterprise/2.13/v3"} (id=220e4f40-a132-11e8-9db5-d4be22122988)
  HttpError: {"message":"A JSON web token could not be decoded","documentation_url":"https://developer.github.com/enterprise/2.13/v3"}
      at response.text.then.message (/pr-triage/node_modules/@octokit/rest/lib/request/request.js:72:19)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)
  --
  event: {
    "event": "pull_request_review.submitted",
    "id": "220e4f40-a132-11e8-9db5-d4be22122988",
    "installation": 21,
    "repository": "xxxxxxxxx/yyyyyyyy"
  }
08:55:33.581Z  INFO http: POST / 200 - 141.73 ms (id=220e4f40-a132-11e8-9db5-d4be22122988)
09:01:21.185Z DEBUG github: GitHub request: GET /app/installations - 401 undefined (installation=undefined)
  params: {
    "per_page": 100,
    "baseUrl": "https://github.xxxxx.com/api/v3",
    "request": {
      "timeout": 0
    }
  }

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Fix deprication methods

Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.addLabels()". Use "issue_number" instead
Deprecation: [@octokit/rest] "number" parameter is deprecated for ".pullRequests.listReviews()". Use "pull_number" instead

Which should be prioritized WIP or draft?

In the current implementation, PRTriage prioritize WIP over draft. I think It just doesn't feel right to me. What do you think?

*** Update ***
I am leaving it open for at least 14 7 days to give time for you to raise any concerns.
(14 days is too long)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.