powerloom / deploy Goto Github PK

Describe the bug

Stopping and Starting services using ./build-dev.sh occasionally throws Error
Error response from daemon: network 07cecd2548b6251645426f6236e68841d180c8e87a9ff12a8d65beb994d11123 not found

To Reproduce

Steps to reproduce the behavior:

1. Start all services using ./build-dev.sh
2. Stop them using docker-compose down --volumes
3. Repeat 1 and 2

Expected behavior
All services should start and stop without any issues

Proposed Solution
Enabling --force-recreate flag in build-dev.sh startup command should fix the issue.

Additional context
Observed in Mac OS Ventura (Apple Silicon)

I'm submitting a

• bug report.
• feature request.

Current Behaviour:

Expected Behaviour:

Steps to reproduce:

Snapshot:

Environment:

• python/nodejs/go version
• OS details
• Config details
• Logs

Do you want to work on this issue?

Describe the bug

Issue title is self-explanatory

To Reproduce

Affected versions:

Steps to reproduce the behavior:

1. run ./bootstrap.sh
2. run ./build-dev.sh

Expected behavior
the env example should include slot ID. This will cause the .env load to further pass the slot ID to pooler initialization scripts.

Proposed Solution
include slot ID in env example

Caveats
NA

Additional context
Ensure the correct images of pooler and audit-protocol are pulled that utilize the slot ID.

Is your feature request related to a problem?
When launching on Github Codespaces, port forwarding is tricky and things like pooler frontend don't work out of the box.

Describe the solution you'd like
Use environment variables such as GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN to automatically map the APIs.

Describe alternatives you've considered
One less convenient option would be is to allow users to input these manually.

Is your feature request related to a problem?
The current development flow is very complicated, developers need to restart entire build-dev.sh setup to reload and test new changes which takes a lot of time.
Code should be mounted as volumes so developers can just login to docker container and test their changes by restarting the service they're working on without having to restart the whole thing.

Describe the solution you'd like
Mount code path as volumes for easy development flow

While our setup works great with Github codespaces, it still requires running an Ethereum node or paying for an external RPC provider. We want to support developers would like to give this a try without incurring any additional costs. I propose the following:

1. Reduce the default pairs (currently 20) and set rate limits to something that fits in the free plan of most external RPC providers.

2. Add a flag to allow people with full nodes to run all pairs for best experience.

Is your feature request related to a problem?
The aave use case codebase does not have an aave specific branch for Powerloom:deploy.

Describe the solution you'd like
A deploy branch for aave should be created to keep any necessary aave specific changes separate from other use cases.

Describe alternatives you've considered
Aave specific code changes could be pushed to the main branch, but it would be cleaner and easier to maintain by keeping a separate branch.

Describe the bug

Docker compose files have extra_hosts extra bit which is not used anymore since we've switched to service name based addressing. Docker Compose files can be cleaned up to remove it.

Expected behavior
All files should be clean and concise with extra unused bits.

Proposed Solution
Cleanup Docker compose files

We should prevent running services unless their snapshotter is registered on the contract. Since we are still in invite only mode, a simple check against the contract from the build.sh script can help save time especially with bad inputs.