poweld / hipchat-scala Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 9.0 185 KB

Scala interface for the HipChat v2 API

License: MIT License

Scala 100.00%

hipchat-scala's People

Contributors

Stargazers

Watchers

Forkers

giabao mrfyda briandemant reemplazable pedrorijo91 davidtanluc oltier pshirshov

hipchat-scala's Issues

Update dependencies

While using this library with play 2.4.6 I get some problems:

2016-01-05 11:41:35,458 [error] Cannot invoke the action
java.lang.RuntimeException: java.lang.NoSuchMethodError: com.ning.http.client.AsyncHttpClientConfig$Builder.setRequestTimeoutInMs(I)Lcom/ning/http/client/AsyncHttpClientConfig$Builder;
    at play.api.mvc.ActionBuilder$$anon$1.apply(Action.scala:498) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4$$anonfun$apply$5.apply(Action.scala:105) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4$$anonfun$apply$5.apply(Action.scala:105) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.utils.Threads$.withContextClassLoader(Threads.scala:21) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4.apply(Action.scala:104) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4.apply(Action.scala:103) ~[play_2.11-2.4.3.jar:2.4.3]
    at scala.Option.map(Option.scala:146) ~[scala-library-2.11.7.jar:na]
    at play.api.mvc.Action$$anonfun$apply$1.apply(Action.scala:103) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1.apply(Action.scala:96) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$mapM$1.apply(Iteratee.scala:524) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$mapM$1.apply(Iteratee.scala:524) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMapM$1.apply(Iteratee.scala:560) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMapM$1.apply(Iteratee.scala:560) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMap$1$$anonfun$apply$14.apply(Iteratee.scala:537) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMap$1$$anonfun$apply$14.apply(Iteratee.scala:537) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24) ~[scala-library-2.11.7.jar:na]
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24) ~[scala-library-2.11.7.jar:na]
    at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40) [akka-actor_2.11-2.3.13.jar:na]
    at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397) [akka-actor_2.11-2.3.13.jar:na]
    at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) [scala-library-2.11.7.jar:na]
Caused by: java.lang.NoSuchMethodError: com.ning.http.client.AsyncHttpClientConfig$Builder.setRequestTimeoutInMs(I)Lcom/ning/http/client/AsyncHttpClientConfig$Builder;
    at dispatch.InternalDefaults$BasicDefaults$.builder(defaults.scala:45) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.InternalDefaults$.client(defaults.scala:32) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.Http$.<init>(execution.scala:30) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.Http$.<clinit>(execution.scala) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at com.imadethatcow.hipchat.common.Common$.<init>(Common.scala:22) ~[hipchat-scala_2.11-0.2.jar:0.2]
    at com.imadethatcow.hipchat.common.Common$.<clinit>(Common.scala) ~[hipchat-scala_2.11-0.2.jar:0.2]
    at com.imadethatcow.hipchat.rooms.RoomNotifier.sendNotification(RoomNotifier.scala:21) ~[hipchat-scala_2.11-0.2.jar:0.2]
(...)

2016-01-05 11:41:35,473 [error] Caught exception
java.lang.RuntimeException: java.lang.NoSuchMethodError: com.ning.http.client.AsyncHttpClientConfig$Builder.setRequestTimeoutInMs(I)Lcom/ning/http/client/AsyncHttpClientConfig$Builder;
    at play.api.mvc.ActionBuilder$$anon$1.apply(Action.scala:498) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4$$anonfun$apply$5.apply(Action.scala:105) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4$$anonfun$apply$5.apply(Action.scala:105) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.utils.Threads$.withContextClassLoader(Threads.scala:21) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4.apply(Action.scala:104) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1$$anonfun$apply$4.apply(Action.scala:103) ~[play_2.11-2.4.3.jar:2.4.3]
    at scala.Option.map(Option.scala:146) ~[scala-library-2.11.7.jar:na]
    at play.api.mvc.Action$$anonfun$apply$1.apply(Action.scala:103) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.mvc.Action$$anonfun$apply$1.apply(Action.scala:96) ~[play_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$mapM$1.apply(Iteratee.scala:524) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$mapM$1.apply(Iteratee.scala:524) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMapM$1.apply(Iteratee.scala:560) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMapM$1.apply(Iteratee.scala:560) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMap$1$$anonfun$apply$14.apply(Iteratee.scala:537) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at play.api.libs.iteratee.Iteratee$$anonfun$flatMap$1$$anonfun$apply$14.apply(Iteratee.scala:537) ~[play-iteratees_2.11-2.4.3.jar:2.4.3]
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24) ~[scala-library-2.11.7.jar:na]
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24) ~[scala-library-2.11.7.jar:na]
    at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40) [akka-actor_2.11-2.3.13.jar:na]
    at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397) [akka-actor_2.11-2.3.13.jar:na]
    at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) [scala-library-2.11.7.jar:na]
    at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) [scala-library-2.11.7.jar:na]
Caused by: java.lang.NoSuchMethodError: com.ning.http.client.AsyncHttpClientConfig$Builder.setRequestTimeoutInMs(I)Lcom/ning/http/client/AsyncHttpClientConfig$Builder;
    at dispatch.InternalDefaults$BasicDefaults$.builder(defaults.scala:45) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.InternalDefaults$.client(defaults.scala:32) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.Http$.<init>(execution.scala:30) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at dispatch.Http$.<clinit>(execution.scala) ~[dispatch-core_2.11-0.11.2.jar:0.11.2]
    at com.imadethatcow.hipchat.common.Common$.<init>(Common.scala:22) ~[hipchat-scala_2.11-0.2.jar:0.2]
    at com.imadethatcow.hipchat.common.Common$.<clinit>(Common.scala) ~[hipchat-scala_2.11-0.2.jar:0.2]
    at com.imadethatcow.hipchat.rooms.RoomNotifier.sendNotification(RoomNotifier.scala:21) ~[hipchat-scala_2.11-0.2.jar:0.2]
(...)

I believe the problem is due to:

Play 2.4.6 uses async-http-client 1.9.2
hipchat-scala uses dispatch-core 0.11.2, which uses async-http-client 1.8.10

1.9.21 doesn't have com.ning.http.client.AsyncHttpClientConfig$Builder.setRequestTimeoutInMs(I) method, leading to this error on runtime

is this lib compatible with HipChat enterprise?

Hipchat provides a self hosted version (https://www.hipchat.com/data-center).

I'm still not sure if Hipchat enterprise maintains the same API (I would expect so).

From what I've seen (at https://github.com/poweld/hipchat-scala/search?utf8=%E2%9C%93&q=api-url&type=) it should be possible to use this lib with Hipchat enterprise/self-hosted. If so, this use case could be covered on the README file

No 2.12 support

Hey, it would be great to add 2.12 support )

Application needs to shutdown both clients to end.

I'm executing a Spark job which generates a output to HipChat.

After the notification is send the application continues to run, even though my code has finished.

Using visual-vm I've found that the threads from dispatch are kept alive, making the application wait for them to finish.

Here's an example gist to reproduce the bug.

To solve this I added a callback finishing the internal dispatch clients, enabling the application to die.

eventualNotification.onComplete { _ =>
  // Both clients are needed, only one or the other doesn't work
  Http.shutdown()
  Common.http.shutdown()
}

This is IMO a severe bug, since my application needs to handle the lifecycle of the internal http library of one of my dependencies.

One suggestion is to choose another http client, I've had used dispatch before and had a terrible experience with it on a similar scenario.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.