potherca / flysystem-github Goto Github PK

I get the next error

Class 'Symfony\Component\EventDispatcher\Event' not found

The logic in extractMetaDataFromTreeInfo() only seems to work if the incoming path ends with a trailing slash. This may be expected, but it might be nice if the method was a little more forgiving and added the slash if missing.

The metadata provided for a directory entry doesn't contain a path entity. My interpretation of the flysystem doc (http://flysystem.thephpleague.com/creating-an-adapter/) is that this can be expected. Am I reading that correctly?

The composer.lock file is not present in the project, probably because it's listed in the .gitignore file. I would expect this file to be present in the repository. What's the reason it is ignored?

As of Q4 2019, Github are deprecating API calls that use an access token as a query-string parameter (See: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters). Unfortunately, this is the suggested method to use when reviewing this module's README and which will result in your being emailed daily by GH telling you that this type of request is deprecated.

A quick fix for this would be to use the alternative method that is suggested in the READMR, and make it the suggested method, in addition to some notes and a link to the github.com docs page above for the other.

When calling getMetadata on a directory entity, it seems to return a multidimensional array of metadata for the entities of that directory, not the metadata for the directory itself. This seems to be inconsistent with the other native flysystem adapters that I have worked with.

The repository name foo/ is accepted, although it's clearly incorrect.

Currently PHP 5.5 is required for the package. I glanced quickly through the code and the only place I noticed 5.5 syntax was in the tests. Would it be reasonable to require 5.5 for dev, but 5.4 otherwise?

The Client class should be renamed to ApiFacade or something similar as that more closely reflects it goal and purpose.