Giter Club home page Giter Club logo

aws-service-catalog-deployment-pipeline's Introduction

๐Ÿ‘‹ Welcome to My GitHub Page! ๐Ÿš€

I'm an SRE Engineer at Centrica, passionate about โ˜๏ธ cloud computing. I thrive on creating diverse projects using various languages like Golang, Python, Java, and more! While some projects are private for legal reasons, you can still explore a few here. ๐Ÿ˜‰

Always eager to expand my skill set, I'm currently exploring virtualization systems like Proxmox to supercharge my projects. ๐Ÿ–ฅ๏ธ

Feel free to connect with me for tech discussions, questions, or just a friendly chat. Let's dive into the exciting world of coding together! ๐ŸŒŸ

Stay tuned for more updates and cool projects coming your way! ๐ŸŽ‰

General Metrics

aws-service-catalog-deployment-pipeline's People

Contributors

dependabot[bot] avatar porrige51122 avatar

Watchers

 avatar  avatar

Forkers

kaedig

aws-service-catalog-deployment-pipeline's Issues

Documentation

More documentation is needed:

  • What this project is
  • How it works
  • How to run it
  • Licenses and Contributing Policies

Manual Approval

There should be a stage in the middle of the pipeline run, which can be turned on an off by terraform variables, which enables manual approval, meaning it can only be deployed to service catalog once the manual approval has gone past

Rename resources to be more helpful

Many of the resources are either using default names (Helpful as they are unique) which now should be changed to a uniform name, and a potential suffix can be added to all of them to allow for multiple unique pipelines running in parallel to exist.

Add a spell check action

Add a Github Action to the repo which scans all the comments and Documentation for spelling mistakes.

This is helpful for anyone contributing who may not notice small mistakes in their spelling, but can make a big difference in the documentation.

This should run every push to the repo.

Add Optional Buildspec Var

Add a variable that allows you to pass in a custom buildspec yaml file which will be read in the build stage of the pipeline. This allows people to add their own custom tests on top of the cfn-lint that it already does.

Deploy to Service Catalog

At the end of the pipeline, there should be a stage where it gets deployed to service catalog. This should add new versions when the template is updated, rather than overwriting existing versions.

Add Tags

Tags should be an optional variable accepted by the module allowing for users to be able to tag the infrastructure as needed.

Static Testing

We need a stage in the run which runs static analysis such as formatting and linting on the template file. This will allow some quick errors to show up early on in the run

Add Github Actions

Adding some github actions to the repo.

Static analysis such as:
Terraform Linting
Cloud Formation Linting
Go Linting

Then some documentation linting would be handy that would help check for spelling mistakes

Remove Admin Access

The deploy role in ./module/iam should not have admin access. This role should be audited to have the least amount of permissions, then the role arn should be returned to the user, where they can then add added permissions if they would like

Make Approval stage optional

Currently the approval stage is mandatory, we need it optional so people can choose full automatic deployments if the approval is declared elsewhere.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.