DeviceMetadata should store an IOType variant which represents the type of values that an input returns or an output accepts.

Subscribers should have a unified command structure so that any subscriber/command structure can be built

Create a struct named ScheduledCommand which stores a Command trait object (eg: GPIOCommand) and a timestamp. Such objects should retain a reference to the instantiating Device and have a single method that

Likewise, PollGroup should have a container which stores these objects. This container should be routinely iterated through and executed then popped from the container at the appropriate time.

Binary is writing too much to stdout during polling

This should be an integration test

Custom implementations of Error and Result seem to be an anti-pattern and are hard to keep track of. Keep ErrorKind to help distinguish fixable issues. However, errors should simply be returned by the Err() function and not custom code.

In the event that ::rx() fails or incorrect type for value, ::generate_event() should return a Result<IOEvent, ...>

Update REAME to state that embedded devices will be supported soon (because no_std has not been implemented yet), but embedded linux systems are supported.

Command factory should accept closure instead of literal values

Implement this PID library

Devices should be initialized dynamically using a config file instead of being hardcoded.

Both input and output should be unaware of the other. However, events generated by Input::read() are routed to Publisher::notify() which is propagated to Subscriber implementations and therefore events are passed to outputs.

Implementations and definitions are too spread out

If a temperature sensor reads a f64 input, and a subscriber generates a bool value to turn on a heater, which is passed to an output.

As it stands, IOType does not check variant type. Numerical comparisons can become performed with bool values and seems to lead to unreliable behavior. Therefore, type checking should become involved to ensure that GPIO devices and abstract subscribers behave as expected.

Add ReturnType and InputType to Input and Output respectively. Then add both I/O types to a Subscriber to indicate any conversion in types.

Struct that stores Command and timestamp to be executed

Containerized and Device objects should be serializable to facilitate persistent runtime storage. Enabling these at the trait level allows for different implementations with a common interface. CSV will be the data format for log data; TOML will be the data format for storing sensor metadata

Log should be partitioned daily. Therefore a filename prefix should be given.

There should never be a case where an id is negative

Simply, "Poller" lacks meaning while "Poll Group" conveys intention and symbolism...

This seems like a bad design pattern. Instead, pathnames should be generated by implementing struct or trait.

Testing should occur by testing:

• ::read()
• ::rx()
• ::add_publisher()
• ::has_publisher()

After each call to poll(), observers should be queried to execute actions based on sensor readings.

A dedicated function for renaming Device::id() should be implemented for Device. The change should be propagated into IOEvent log.

Input::add_publisher() should return a reference to the existing/attached PublisherInstance. This is a low priority since no inputs built with builder should have this problem.

The ThresholdMonitor should only be available for inputs which return non-binary types (you cannot have a threshold on a binary value). Some type of state or marker should be stored to track available subscribers using Rust's built-in inferencing.

action should be refactored out of io

A trait called HasLog should be created to interact with log. The following functions should be implemented:

• has_log() -> bool - check if the current device has a log (#55 should be implemented first)
• add_log(Deferred<OwnedLog>) -> Result<()> - Attach log to device. An error should be returned if owned log already has an owner.

This complicates building and testing device instances. To simplify instance initialization, log field should be an option. The changes should also be propagated to DeviceLogBuilder.

load() should return Result<T, Err>, and a match should catch result and return new() if there is no value found

Meant for performing a transient operation requiring a Command and a Routine

A instance of Command called DynamicCommand should be created which stores a closure as a field. The struct should have a generic type to store multiple storage types.

To assist typing, an enum should be created that defines factory types as variants.

builders::pubsub_builder() should accept closure as fn that returns a subscriber type. This allows for dynamic arguments and universal builder function.

Instead of using ".dotenv" crate, manually read from a TOML file named as the PollGroup, if no file exists, then implement a load_or_new(&path) function and load default.