poooi / plugin-quest Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 7.0 2.83 MB

show quest info

License: MIT License

CSS 7.80% JavaScript 87.53% HTML 1.59% TypeScript 3.09%

plugin-quest's People

Contributors

Stargazers

Watchers

Forkers

dkwingsmt xoxoxoooxx lawvs gnattu sunnyezreal gakada

plugin-quest's Issues

Dependencies missing

Missing dependencies after running node fetch.js

> node fetch.js
A:\*****\plugin-quest\node_modules\babel-core\lib\transformation\file\options\option-manager.js:328
        throw e;
        ^

Error: Couldn't find preset "es2017-node7" relative to directory "A:\\*****\\plugin-quest"
......

plugin-quest/fetch.js

Lines 1 to 5 in add9a29

 require('babel-register')({ 

 extensions: ['.es'], 

 presets: ['es2017-node7', 'stage-0', 'react'], 

 plugins: ['add-module-exports', 'closure-elimination'], 

 })

npm install -D babel-preset-es2017-node7 babel-preset-stage-0 babel-preset-react

一直提示加载失败，兼容性问题

Electron v0.35.4 x64
Win 10 Pro x64
poi's version: Commit

如题，一直提示错误。
尝试了删除，重新安装，然后就卡 Installing.
看了一下插件目录，文件倒是下载下来了，但是好像并没有什么卵用？

关于月常水上打击部队的误解

任务 A43 + 后续任务 Bm04 的完成条件错误。
此任务链的要求应为 限制舰型，而非低速即可。

http://bbs.nga.cn/read.php?tid=9781134

a translation mode in the form of a task list

### Request to add a translation mode in the form of a task list.
Single task is not easy to view.
Thanks

Incorrect i18n parsing on modal conversion quests.

plugin-quest/assets/i18n/zh-CN.json

Line 179 in bbe64b4

 "equip": "秘书舰{{{secretary}}}在{{{slot}}}搭载未上锁的{{{fullyskilled}}}{{{maxmodified}}}{{{equipment}}}", 

In the case that maxed modification is required, but fully skilled is not , such structure will make the max-modification requirement take the position of the skill requirement, which resulted in an incorrect display. For example:

Edit: The display is still incorrect even after adding "fullyskilled": false, to data.json manually.

plugin-quest/assets/data.json

Lines 10442 to 10448 in bbe64b4

 { 

 "slot": 4, 

 "equipment": "瑞雲(六三四空)", 

 "convert": true, 

 "maxmodified": true, 

 "use_skilled_crew": true 

 }

use_skilled_crew should not be defined inside the slots by the way, it should be directly inside the requirements to be displayed.

已经完成了的任务出现在了“可执行”分类

版本：electron-v0.28.3-ia32
the latest master branch of poi
quest-info v1.1.1

仅出现在周常和月常任务中

5.0.0 crashes for English

As was mentioned on discord, filterNames is ["Composition Quest", 1, 2, ..., 11], so pluralize throws. It works after adding filterNames values in en-US.json:

  "Composition Quest": "Composition Quest",
  "Sortie Quest": "Sortie Quest",
  "Exercise Quest": "Exercise Quest",
  "Expedition Quest": "Expedition Quest",
  "Supply/Docking Quest": "Supply/Docking Quest",
  "Arsenal Quest": "Arsenal Quest",
  "Modernization Quest": "Modernization Quest",
  "Marriage Quest": "Marriage Quest",
  "Daily Quest": "Daily Quest",
  "Weekly Quest": "Weekly Quest",
  "Monthly Quest": "Monthly Quest",
  "Quarterly Quest": "Quarterly Quest",

Another thing, fetch.js is used as fetch.es in package.json.

建议新增任务完成状态分类「未知」

默认使用「已完成」，在多前置的情况下容易造成误会。

关于增加分类和显示任务完成情况

1、希望增加【日常】【周常】【月常】三个分类

2、将结婚系列任务【WB系列】单独独立出一个分类

3、希望类似 KCV 一样能够显示当天/周/月剩下的未完成的任务
（可以通过在上述新增分类下显示任务的完成情况来实现）

新加任务导致的出错问题

都是在 reqstr 函数上出的错，加了一些 print 信息之后显示如下：

任务 647

reqstr.coffee:153 Invalid requirements: {"category":"equipexchange","scraps":[{"name":"ドラム缶(輸送用)","amount":2}],"resources":[1200,0,0,3000]}, category:equipexchange, fn:function (local_args) {
      var new_f;
      new_f = function() {
        return f.apply(Object.assign(this, local_args), arguments);
      };
      return new_f.apply(new_f, arguments);
    }, ret:undefined. reason: TypeError: Cannot read property 'length' of undefined TypeError: Cannot read property 'length' of undefined

任务 649

Invalid requirements: {"category":"equipexchange","scraps":[{"name":"零式水上偵察機","amount":2}],"consumptions":[{"name":"新型航空機設計図","amount":2},{"name":"ネ式エンジン","amount":1}]}, category:equipexchange, fn:function (local_args) {
      var new_f;
      new_f = function() {
        return f.apply(Object.assign(this, local_args), arguments);
      };
      return new_f.apply(new_f, arguments);
    }, ret:undefined. reason: TypeError: Cannot read property 'length' of undefined TypeError: Cannot read property 'length' of undefined

任务 705

Invalid requirements: {"category":"modernization","times":2,"ship":"空母","consumptions":[{"ship":"轻母/空母","amount":5}],"resources":[0,0,5500,2500]}, category:modernization, fn:undefined, ret:undefined. reason: TypeError: fn is not a function TypeError: fn is not a function

705 我看出来是数据的 category 出问题，然而前面两个就不知道了……

[Review request] 任务条件

dkwingsmt@52d648d

左边的是原来的任务条件，

右边是经过我重构和翻译之后自动生成的任务条件。

然而疏忽难免，请大家帮忙一一检查是否有左右不一致的地方。

条目较多，麻烦了。

quest.json : reward_alum -> reward_bauxite

任务完成状况读取错误？

今天在做新飞机系列任务的时候遇到了这个情况。这个任务我还没开呢，但是出现在了“可执行”里面。
稍微调查了一下，发现是这个任务要求月常“海上护卫强化月间”作为前置，但这个月常我这个月还没完成呢(｡•ˇ‸ˇ•｡)
然后在我把任务切换到第三页，让任务插件了解我现在可以执行“海上护卫强化月间”（也即没有完成）之后这个任务就被归类到“未开放”里去了。
但是，为什么任务插件会奇怪地提前认为我可执行这个任务呢？

建議更新冬季及新年任務

建議更新冬季及新年任務
但新年任務應等候日本wiki確認條件
http://wikiwiki.jp/kancolle/

Quest plugin modernization

Coding

Use TypeScript

Parser

Explicit: avoid reading data from outside function parameters to make function dependency clear
Functional
Behavior unit testing

Quest data

Use JSON schema to verify content

“远征信息”插件远征38条件验证有误

远征38（东急2）成功条件是有4条以上各自携带2个以上桶，而插件似乎只验证总桶数>8...事实上例如三条三桶+一条一桶的配置远征仍然会失败（派出时poi会提示失败，估计api能收到失败信息？），但插件上显示配置可行的绿点。
望予修正，多谢。
另，远征24的大成功条件已经确证为至少4桶4闪，望能加入文字部分说明。

by @Yogomove at poooi/poi#973

Request latest update for quest log info

Several quest has not been updated, i recommended to export the latest working build into package.
Quest from A70,B70,F37 has not been update in the current released package. Although there is work progress in the git-hub, the released version has not been updated.

	require('babel-register')({
	extensions: ['.es'],
	presets: ['es2017-node7', 'stage-0', 'react'],
	plugins: ['add-module-exports', 'closure-elimination'],
	})

	{
	"slot": 4,
	"equipment": "瑞雲(六三四空)",
	"convert": true,
	"maxmodified": true,
	"use_skilled_crew": true
	}