polymeilex / libseat-rs Goto Github PK

https://docs.rs/crate/libseat/0.1.1/builds/399159

Looks like the custom_logger features (on by default) fails because it cannot find the #include <libseat.h> include for compiling log_handler.c, maybe the feature needs to be disabled for docs.rs build ?

For reference: https://docs.rs/about/metadata

The latest Smithay removed slog in favor of tracing. However slog is still in Smithay's dependency tree due to libseat's dependency on it.

I personally have never used logging in libseat, so I'm not sure if I'd mind its complete removal, but at the very least it should probably be put behind a feature flag. The most sensible solution is likely a migration to tracing.

Currently Seat::open will create a log handler, but only after libseat_open_seat() is called and returns a seat, making it impossible to log failing to open a seat properly. Additionally, while LogHandler itself is pub, the module log_handler itself is not, making it inaccessible to construct yourself (not that you'd want two log handlers).