I'm having problems finding a java library that is easy to use to connect to the bitcoin core api. Finally found this, but I need the getBlockTemplate function. Are there any plans to implement it, or do I have to keep looking?

Code would go to an endless loop when get a big string. The stack are listed below

 at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSHash(CrippledJavaScriptParser.java:156)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSExpr(CrippledJavaScriptParser.java:191)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSArray(CrippledJavaScriptParser.java:99)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSExpr(CrippledJavaScriptParser.java:189)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSHash(CrippledJavaScriptParser.java:146)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSExpr(CrippledJavaScriptParser.java:191)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSHash(CrippledJavaScriptParser.java:146)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSExpr(CrippledJavaScriptParser.java:191)
    at wf.bitcoin.krotjson.CrippledJavaScriptParser.parseJSExpr(CrippledJavaScriptParser.java:256)
    at wf.bitcoin.krotjson.JSON.parse(JSON.java:129)
    at wf.bitcoin.javabitcoindrpcclient.BitcoinJSONRPCClient.loadResponse(BitcoinJSONRPCClient.java:187)
    at wf.bitcoin.javabitcoindrpcclient.BitcoinJSONRPCClient.query(BitcoinJSONRPCClient.java:229)
    at wf.bitcoin.javabitcoindrpcclient.BitcoinJSONRPCClient.getRawTransaction(BitcoinJSONRPCClient.java:1283)

It would occurs every time when getRawTransaction("b6299d23e836d649a5a5012ebfebd2474b4d100d5334d7608d3c6c01b8204b45")

getaccountaddress doesn't work, can you please add it thank you.

Currently this requires ExtendedTxInput

Missing methods supported in 0.17.0 are ...

• getblocktemplate ( TemplateRequest )
• prioritisetransaction

It is currently not possible to generate 'legacy' addresses through getNewAddress()

The use of double leads to all sorts of rounding issues.
The network uses amounts with a fixed scale of 8

relates to #55

Missing methods supported in 0.17.0 are ...

• getzmqnotifications

Since bitcoin/bitcoin#12953 i wish have to work with new commands. but there is a way to do that in your client ?

You shouldn't keep amount in double. I suggest long in satoshi (like in BitcoinJ) or BigDecimal.

Hi! I couldn't find how to pass to signrawtransaction all the parameter options it supports now. I'm mostly interested in validating transactions without boradcast them, as stated here. Are you still working in the library? Can you add it? Can I send a PR?
Thanks!

It is not generally true that the key/value map returned from the Bitcoin client contains a value for the requested pair. For example vout is not present for coinbase transactions. The API must therefore use Object equivalents of primitive types.

This is an incompatible change.

https://bitcoin.org/en/developer-reference#generatetoaddress

wf.bitcoin.javabitcoindrpcclient.BitcoinRPCException: RPC Query Failed (method: getblockcount, params: [], response code: 415 responseMessage Unsupported Media Type, response: invalid content type, only application/json is supported

Getting Tx: 853e910bedb7c8213bc93cab7e8337e0a59731db1e0c8968d2e19355d850bdc5
Nov 29, 2018 6:44:36 AM wf.bitcoin.javabitcoindrpcclient.BitcoinJSONRPCClient$TransactionWrapper raw
WARNING: RPC Query Failed (method: getrawtransaction, params: [853e910bedb7c8213bc93cab7e8337e0a59731db1e0c8968d2e19355d850bdc5, 1], response code: 500 responseMessage Internal Server Error, response: {"result":null,"error":{"code":-5,"message":"No information available about transaction"},"id":"1"}

Got Tx: [tx=853e910bedb7c8213bc93cab7e8337e0a59731db1e0c8968d2e19355d850bdc5, vin=0, vout=0]

May returns a Tx object that has neither vin nor vout

It may be useful to align the version of this project to the one of bitcoin core. In that way it would be immediately obvious what scope of functionality can be expected to be supported.

Also see PR #48

We have a few incompatible changes lined up in branch 0.17.x. Now that this version of bitcoin core has been released, it is time to bring them in to master.

The question however arises what the next version should be. I propose a semantic versioning scheme, where an incompatible API change would call for a major version bump.

The next version would therefore be 1.0.0

Can not find any way to create raw transaction which has data in it's output list.
in bitcoin command, data can insert as one of outputs. e.g.
{
"mgt9WNsoi7pPY29ACTuWPVX73XGFVhD9Vi": 40,
"data": "ba3885e9aa5fd0949f40dc5d7905700fa039ef8ad425c60479cc52dfe16aa3e8"
}

but here amount of TxOut in double and can not use as String data.

Sorry, can not find any better way to contact.
if i missed something and there is a way in JavaBitcoindRpcClient, guide me to that.

Missing methods supported in 0.17.0 are ...

• getmemoryinfo ("mode")
• logging ( )
• uptime

Please add move to the client, thank you.

Missing methods supported in 0.17.0 are ...

• clearbanned
• disconnectnode "[address]" [nodeid]
• listbanned
• setban "subnet" "add|remove" (bantime) (absolute)
• setnetworkactive true|false

Perhaps like this

JavaBitcoindRpcClient => java-bitcoin-client

The repo name on github may then also want to change.

PS: most jars have a lower case name with dashes

When I try to move funds from one account to another, I get an exception that boolean cannot be converted to string. Checking the result map in loadResponse, it shows "result" -> "true".

I am using bitcoin-rpc-client in conjunction with walletnotify to get transaction data upon first confirmation. The problem is that getTransaction method returns Invalid Tx because of the following error under the hood:

No such mempool transaction. Use -txindex to enable blockchain transaction queries. Use gettransaction for wallet transactions.

I can set txindex, but it's redundant for me, as I am interested only in my wallet transactions, moreover AFAIU it will add some performance overhead.
I've found the source of the problem, but still can't understand the solution. Both getTransaction and getRawTransaction methods now do getrawtransaction under the hood which is inconvenient when one works with his own wallet transactions only

I think there is a typo in this function:
@OverRide
public String type() {
return mapStr(type()); <====== typo?
}

I think it should be:

    return mapStr("type");

could the method "fundRawTransaction" be added ?

https://github.com/bitcoin/bitcoin/releases/tag/v0.17.0

Missing methods supported in 0.17.0 are ...

• combinepsbt ["psbt",...]
• combinerawtransaction ["hexstring",...]
• converttopsbt "hexstring" ( permitsigdata iswitness )
• createpsbt [{"txid":"id","vout":n},...] [{"address":amount},{"data":"hex"},...] ( locktime ) ( replaceable )
• decodepsbt "psbt"
• decoderawtransaction "hexstring" ( iswitness )
• finalizepsbt "psbt" ( extract )
• fundrawtransaction "hexstring" ( options iswitness )
• signrawtransactionwithkey "hexstring" ["privatekey1",...] ( [{"txid":"id","vout":n,"scriptPubKey":"hex","redeemScript":"hex"},...] sighashtype )
• testmempoolaccept ["rawtxs"] ( allowhighfees )

When i execute below code it create a account with this email: [email protected] .

BitcoinJSONRPCClient bitcoin = new BitcoinJSONRPCClient(url);
String address = bitcoin.getNewAddress("[email protected]");

when i execute bitcoin-cli listaccounts in my terminal. I can see account created with my email but i can see some default balance in it . Here is the listaccounts output:

{
  "": -0.55385912,
  "[email protected]": 1.11942880,
}

I want when ever i call getNewAddress method it should create account with 0 BTC balance

This should be supported.

Missing methods supported in 0.17.0 are ...

• signmessagewithprivkey "privkey" "message"

$ bitcoin-cli fundrawtransaction

error code: -1
error message:

fundrawtransaction "hexstring" ( options )

Add inputs to a transaction until it has enough in value to meet its out value.
This will not modify existing inputs, and will add one change output to the outputs.
Note that inputs which were signed may need to be resigned after completion since in/outputs have been added.
The inputs added will not be signed, use signrawtransaction for that.
Note that all existing inputs must have their previous output transaction be in the wallet.
Note that all inputs selected must be of standard form and P2SH scripts must be
in the wallet using importaddress or addmultisigaddress (to calculate fees).
You can see whether this is the case by checking the "solvable" field in the listunspent output.
Only pay-to-pubkey, multisig, and P2SH versions thereof are currently supported for watch-only

Arguments:
1. "hexstring"           (string, required) The hex string of the raw transaction
2. options               (object, optional)
   {
     "changeAddress"     (string, optional, default pool address) The bitcoin address to receive the change
     "changePosition"    (numeric, optional, default random) The index of the change output
     "includeWatching"   (boolean, optional, default false) Also select inputs which are watch only
     "lockUnspents"      (boolean, optional, default false) Lock selected unspent outputs
     "feeRate"           (numeric, optional, default not set: makes wallet determine the fee) Set a specific feerate (BTC per KB)
   }
                         for backward compatibility: passing in a true instead of an object will result in {"includeWatching":true}

Result:
{
  "hex":       "value", (string)  The resulting raw transaction (hex-encoded string)
  "fee":       n,         (numeric) Fee in BTC the resulting transaction pays
  "changepos": n          (numeric) The position of the added change output, or -1
}
"hex"             

Examples:

Create a transaction with no inputs
> bitcoin-cli createrawtransaction "[]" "{\"myaddress\":0.01}"

Add sufficient unsigned inputs to meet the output value
> bitcoin-cli fundrawtransaction "rawtransactionhex"

Sign the transaction
> bitcoin-cli signrawtransaction "fundedtransactionhex"

Send the transaction
> bitcoin-cli sendrawtransaction "signedtransactionhex"

Missing methods supported in 0.17.0 are ...

• abandontransaction "txid"
• abortrescan
• bumpfee "txid" ( options )
• createwallet "wallet_name" ( disable_private_keys )
• getaddressesbylabel "label"
• getaddressinfo "address"
• importmulti "requests" ( "options" )
• importprunedfunds
• importpubkey "pubkey" ( "label" rescan )
• listaddressgroupings
• listlabels ( "purpose" )
• listwallets
• loadwallet "filename"
• removeprunedfunds "txid"
• rescanblockchain ("start_height") ("stop_height")
• sendmany "" {"address":amount,...} ( minconf "comment" ["address",...] replaceable conf_target "estimate_mode")
• sethdseed ( "newkeypool" "seed" )
• signrawtransactionwithwallet "hexstring" ( [{"txid":"id","vout":n,"scriptPubKey":"hex","redeemScript":"hex"},...] sighashtype )
• unloadwallet ( "wallet_name" )
• walletcreatefundedpsbt [{"txid":"id","vout":n},...] [{"address":amount},{"data":"hex"},...] ( locktime ) ( replaceable ) ( options bip32derivs )
• walletlock
• walletpassphrasechange "oldpassphrase" "newpassphrase"
• walletprocesspsbt "psbt" ( sign "sighashtype" bip32derivs )

Missing blockchain methods supported in 0.17.0 are ...

• getblockheader "hash" ( verbose )
• getblockstats hash_or_height ( stats )
• getchaintips
• getchaintxstats ( nblocks blockhash )
• getmempoolancestors txid (verbose)
• getmempooldescendants txid (verbose)
• getmempoolentry txid
• getmempoolinfo
• gettxoutproof ["txid",...] ( blockhash )
• preciousblock "blockhash"
• pruneblockchain
• savemempool
• scantxoutset ( )
• verifytxoutproof "proof"

Missing control methods supported in 0.17.0 are ...

• getmemoryinfo ("mode")
• logging ( )
• uptime

Missing mining methods supported in 0.17.0 are ...

• getblocktemplate ( TemplateRequest )
• prioritisetransaction

Missing network methods supported in 0.17.0 are ...

• clearbanned
• disconnectnode "[address]" [nodeid]
• listbanned
• setban "subnet" "add|remove" (bantime) (absolute)
• setnetworkactive true|false

Missing raw transaction methods supported in 0.17.0 are ...

• combinepsbt ["psbt",...]
• combinerawtransaction ["hexstring",...]
• converttopsbt "hexstring" ( permitsigdata iswitness )
• createpsbt [{"txid":"id","vout":n},...] [{"address":amount},{"data":"hex"},...] ( locktime ) ( replaceable )
• decodepsbt "psbt"
• decoderawtransaction "hexstring" ( iswitness )
• finalizepsbt "psbt" ( extract )
• fundrawtransaction "hexstring" ( options iswitness )
• testmempoolaccept ["rawtxs"] ( allowhighfees )

Missing util methods supported in 0.17.0 are ...

• signmessagewithprivkey "privkey" "message"

Missing wallet methods supported in 0.17.0 are ...

• abandontransaction "txid"
• abortrescan
• bumpfee "txid" ( options )
• createwallet "wallet_name" ( disable_private_keys )
• getaddressesbylabel "label"
• getaddressinfo "address"
• importmulti "requests" ( "options" )
• importprunedfunds
• importpubkey "pubkey" ( "label" rescan )
• listaddressgroupings
• listlabels ( "purpose" )
• listwallets
• loadwallet "filename"
• removeprunedfunds "txid"
• rescanblockchain ("start_height") ("stop_height")
• sendmany "" {"address":amount,...} ( minconf "comment" ["address",...] replaceable conf_target "estimate_mode")
• sethdseed ( "newkeypool" "seed" )
• signrawtransactionwithwallet "hexstring" ( [{"txid":"id","vout":n,"scriptPubKey":"hex","redeemScript":"hex"},...] sighashtype )
• unloadwallet ( "wallet_name" )
• walletcreatefundedpsbt [{"txid":"id","vout":n},...] [{"address":amount},{"data":"hex"},...] ( locktime ) ( replaceable ) ( options bip32derivs )
• walletlock
• walletpassphrasechange "oldpassphrase" "newpassphrase"
• walletprocesspsbt "psbt" ( sign "sighashtype" bip32derivs )

Missing ZeroMQ methods supported in 0.17.0 are ...

• getzmqnotifications

getinfo doesn't work, can you please add it thank you.

https://bitcoin.org/en/developer-reference#gettransaction

Can't compile on Mac or Linux because the two classes (BitcoinRpcExtension and BitcoinRPCException) have the same name, in the same package, but with different cases.

BitcoinRPCException should be renamed to avoid conflicts with BitcoinRpcException.