polkadot-js / common Goto Github PK

As brought up by @Stefie, this utility function is being used in both polkadot-js/apps and paritytech/substrate-light-ui so probably ought to pulled out to common

https://github.com/paritytech/parity/blob/0bb78814a60d1abc759ded380906a79cf3474f78/util/patricia_trie/src/triedbmut.rs

storage_root:

https://github.com/paritytech/polkadot/blob/master/substrate/state-machine/src/ext.rs#L112

storage_root with triemutdb:

https://github.com/paritytech/polkadot/blob/master/substrate/client/db/src/lib.rs#L403

  const keyring = new Keyring();
  
  keyring.setAddressPrefix(68);
  keyring.encodeAddress(...); // encodes with prefix
  keyring.encodeAddress(..., 42); // pass in optional prefix

Moving towards getting rid of the setAddressPrefix global (also has impacts on api/types for Address, AccountId & AccountIndex)

As far as I know,

in SLIP-0010, deriving child key on ed25519 curve means:

1. create hmac of key and chaincode
2. slice first 32 byte (IL) as key(the seed to generate new key), and the other 32 byte (IR) for chaincode to make entropy in next generation of keys.

but util-crypto/nacl's deriveHard() generates blake2 hash of concatenated(master_secret('ed25519 seed'), IL, IR).

Is there a missing component in the key derivation?

From https://www.npmjs.com/package/secp256k1 needed for polkadot-js/client#183

Change fromString to use fromUtf8, remove the Utf8 version. Same with to, just get rid of toString completely in that case, use impl of toUtf8

The devDependency @polkadot/ts was updated from 0.1.31 to 0.1.32.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Implementing https://github.com/maciejhirsz/substrate-bip39 as to be used in the Parity Signer

The devDependency @polkadot/dev was updated from 0.20.24 to 0.20.25.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/dev is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

We are testing our application with jest.
After updating the polkadot api, we couldn't run our tests anymore, because of following error:

TypeError: Object.defineProperty called on non-object
        at Function.defineProperty (<anonymous>)

      at Object.<anonymous> (../node_modules/@polkadot/util-crypto/schnorrkel/schnorrkel-js/polyfill.js:9:10)
      at Object.<anonymous> (../node_modules/@polkadot/util-crypto/schnorrkel/schnorrkel-js/index.js:11:1)
      at Object.<anonymous> (../node_modules/@polkadot/util-crypto/schnorrkel/keypair/fromSeed.js:10:42)

The line failing is:

We circumvent the problem right now, by setting the node_env to another value for our tests.

... We need to trim down the pyramid by a small amount - for now dev, api, client & apps as unique enough.

Along the same way as done in util-rlp

https://github.com/polkadot-js/common/blob/master/packages/type-extrinsics/src/democracy.ts#L23

As implemented in https://github.com/paritytech/polkadot/pull/262/files

It is not quite right in the crypto package. (Note: Doing this requires a version bump and needs updates in other repos, eg. client and apps)

In https://github.com/polkadot-js/common/tree/master/packages/util-crypto/src/blake2, we could get rid of blake2bAsHex and blake2bAsU8a, and instead just use blake2AsHex and blake2AsU8a (but making the bitLength argument optional). Meaning we'd get rid of the blake2 subdirectory (the second subdirectory). Based on discussion with @jacogr we are just using blake2b, not blake2s, so we can get rid of the subdirectory approach
Not since there is only 2b, can flatten the whole thing.
Assume that the only use of the subdirectory is inside that directory, so it shouldn't be necessary to update other repos, but double check anyway if anything points to blake2/blake2b/*.ts.

So the only thing that we should do that has been suggested i.e. top-level. Instead of this -

https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/blake2/asHex.ts#L19

export default function blake2AsHex (data: Uint8Array, bitLength: number = 256): string {
  return blake2bAsHex(data, bitLength);
}

We should just do the following, which is basically what's inside the 2b directory

export default function blake2AsHex (data: Uint8Array, bitLength: number = 256): string {
  return u8aToHex(
    blake2bAsU8a(data, bitLength)
  );
}

Note that in the blake2b subdirectory, the default value for bitLength is 512, whereas the calling functions in the outer directory have a default value of bitLength as 256. We should use the 256 default, since all our hashes are 32 bytes

... massive impact all the way up, but the sooner, the better.

Currently slated for TS 3.1 (Aug 2018, https://github.com/Microsoft/TypeScript/wiki/Roadmap#31-august-2018)

Closed in 2f1aebe

In view of the hacking incidents of the previous period, as an improvement: the account is created using the true random number method.
True random number source:

• Video/Camera.
• Microphone.
• Vibration sensor.
• User touch record.
• Temperature Sensor.
• Photoelectric Sensors. etc
• or use https://www.random.org/ api

Look likes:

Polkawallet same issue: polkawallet-io/polkawallet-RN#120

1. Parse DEBUG=foor,bar polkadot.js ...
2. Inside logging,

• when debugKeys.includes(key), l.debug(...) -> l.log(...)
• when !debugKeys.includes(key), l.debug(...) -> () => void

isHex (value: any): value is string has the side-effects -

return isHex(value)
  ? (value.length - 2) / 2
  : value.length // here it is _not_ a string

Better would be to just return boolean

Currently the generation is not available although the docs are there -

polkadot-js/dev#132

Introduced in paritytech/substrate#1730

The devDependency @polkadot/dev was updated from 0.24.4 to 0.24.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/dev is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

https://github.com/paritytech/substrate/wiki/External-Address-Format-(SS58)

Currently we only support the even case where the ss58 is taken - also support the odd case where the actual Accountid is used.

The devDependency @polkadot/dev was updated from 0.22.1 to 0.22.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/dev is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Not the entropty/mini secret route (compat is broken)

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.4.5 to 7.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

paritytech/schnorrkel-js#7

It is still using the first-generation derivation

The devDependency @polkadot/ts was updated from 0.1.38 to 0.1.39.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

related to this issue paritytech/substrate#2332
the ss58 check for generate addr checksum has changed
but this lib not match for this modification.
https://github.com/polkadot-js/common/blob/master/packages/keyring/src/address/encode.ts

hope to fix it soon, thx

The devDependency @polkadot/ts was updated from 0.1.49 to 0.1.50.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This one is a bit involved, so it probably makes sense starting with 1, seeing how it goes (implementing across the tree, i.e. here, api & apps) and then taking it further.

Basically, atm any value actually refers to the base type. For this example, let's take BlockNumber. In effect, it is type BlockNumber = BN, the idea is -

// probably may not be needed to pass generic, probably just Uint8Array (sliceables)
interface ParamEncoder <S> {
  encode (): S;
  toJSON (): any;
}

interface ParamDecoder <C, O> {
  decode (input: S): C;
  fromJSON (input: any): C;
}

interface BaseParam <T> { // or BasePrimitive, or BaseType, or...
  value: T;
}

class BlockNumber implements ParamEncoder<Uint8Array>, BaseParam<BN> {
  value: BN;

  encode (): Uint8Array {
    // ... convert to sliceable
  }

  toJSON (): any {
    // yes, we have utils for this, just a sample
    return '0x' + this.value.toString(16);
  }

  static decode (input: Uint8Array): BlockNumber {
    return new BlockNumber(...);
  } 

  static fromJSON (input: any): BlockNumber {
    return new BlockNumber(...);
  }
}  

The benefits we get -

1. consistent interface for all values
2. encoding/decoding is not done in different places across the codebase
3. instead of import encoder from '@polkadot/primitives/bn/encoder'; enoder(bn) we just do bn.encode()

BlockNumber here is actually an interesting one -

1. It may encode differently depending on chain (sizes, Nonce & Balance are currently good examples of this)
2. It shares the same type with others, only differring in length, i.e. Balance & Nonce are also with the same logic.
3. With the above in mind, it probably makes a bit more sense doing Nonce or Balance first (the latter has further-reaching UI impacts, so Nonce conevrs all the bases, but has a lesser footprint)

Decoding is wrong along the same line of #165

The DB interfaces needs to be adapted since lmdb uses transactions by default. (So BaseDb needs to expose part of the TransactionDb interfaces)

The devDependency @polkadot/dev was updated from 0.21.3 to 0.21.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/dev is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Which is just mnemonicToSecret(seed).subarray(0, 32)

Just don't want to be doing the externally, i.e. in the UI

https://flow.org/en/docs/linting/

... needs a check in apps & client to convert, passing false explicitly where applicable

e.g. currently we have u8aFromBuffer, the equivalent bufferToU8a should be made available. An alias could look like the following:

const bufferToU8a = require('../u8a/fromBuffer');

module.exports = bufferToU8a;

(buffer, number, hex, u8a, ...)