Giter Club home page Giter Club logo

Comments (2)

x-0o0 avatar x-0o0 commented on June 4, 2024

Additional comment for the issue

According to the logs that are provided by _printChanges(),
at the first, the states are well-assigned but immediately .destination(.dismiss) is called from the parent reducer via navigationDestination method:

received action:
  AppReducer.Action.secondTapped
- AppReducer.State(_destination: nil)
+ AppReducer.State(
+   _destination: .first(
+     FirstReducer.State(
+       _destination: .second(
+         SecondReducer.State(_destination: nil)
+       )
+     )
+   )
+ )

received action:  // ❌ unexpected action is called
  AppReducer.Action.destination(
    .presented(
      .first(
        .destination(.dismiss)
      )
    )
  )
  AppReducer.State(
    _destination: .first(
-     FirstReducer.State(
-       _destination: .second(
-         SecondReducer.State(_destination: nil)
-       )
-     )
+     FirstReducer.State(_destination: nil)
    )
  )

from swift-composable-architecture.

stephencelis avatar stephencelis commented on June 4, 2024

I believe this is a vanilla SwiftUI bug with navigationDestination, though if you can show it working there we can look into if it's a TCA bug.

We provide a workaround in our SwiftUINavigation package, but have decided against doing so in TCA, since it introduces a flakey code path that could break at any time when Apple fixes things. There's recent discussion here about how the modifier has regressed in iOS 17, and a possible workaround you can bring to your TCA project: pointfreeco/swiftui-navigation#121

I'm going to convert this to a discussion, since it appears to be an Apple bug and not a bug with the library.

from swift-composable-architecture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.