Comments (2)
Additional comment for the issue
According to the logs that are provided by _printChanges()
,
at the first, the states are well-assigned but immediately .destination(.dismiss)
is called from the parent reducer via navigationDestination
method:
received action:
AppReducer.Action.secondTapped
- AppReducer.State(_destination: nil)
+ AppReducer.State(
+ _destination: .first(
+ FirstReducer.State(
+ _destination: .second(
+ SecondReducer.State(_destination: nil)
+ )
+ )
+ )
+ )
received action: // ❌ unexpected action is called
AppReducer.Action.destination(
.presented(
.first(
.destination(.dismiss)
)
)
)
AppReducer.State(
_destination: .first(
- FirstReducer.State(
- _destination: .second(
- SecondReducer.State(_destination: nil)
- )
- )
+ FirstReducer.State(_destination: nil)
)
)
from swift-composable-architecture.
I believe this is a vanilla SwiftUI bug with navigationDestination
, though if you can show it working there we can look into if it's a TCA bug.
We provide a workaround in our SwiftUINavigation package, but have decided against doing so in TCA, since it introduces a flakey code path that could break at any time when Apple fixes things. There's recent discussion here about how the modifier has regressed in iOS 17, and a possible workaround you can bring to your TCA project: pointfreeco/swiftui-navigation#121
I'm going to convert this to a discussion, since it appears to be an Apple bug and not a bug with the library.
from swift-composable-architecture.
Related Issues (20)
- onChange not work for state change by setter HOT 1
- Default title text for alerts generates log errors when using string catalogs
- Mapping AnyPublisher to Effect with the Latest Swift Composable Architecture HOT 1
- StackState/StackReducer related leak HOT 3
- Publisher animation is not working HOT 3
- Stack based navigation throw error when write to userdefault in reducer and use scenePhase environment key HOT 1
- Sendable warnings (Animation) HOT 2
- Drop `Equatable` constraint for `Value` in `_OnChangeReducer` HOT 1
- When using switch store onAppear method not being ran in child HOT 1
- Xcode Cloud can't build projects that uses Composable Architecture v1.4.0 HOT 1
- libiraty tuist errir HOT 1
- Static dependencies HOT 3
- Extension for Reducer.State/Action causes a compilation error with the new @Reducer macros HOT 2
- Circular reference error using @Reducer with an extension on reducer's State HOT 2
- The .legacyAlert modifier on a child view will be ignored. HOT 11
- Crash in 1.5.2 - Unwrapping in IfLetStore, line 88 HOT 5
- 1.5.4 action from run not called HOT 7
- Build error "Undefined symbols" when building with internal type in a package HOT 1
- Tutorial documentation bug in TCA 1.5.6 HOT 1
- Preview Build Fails in Swift Package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-composable-architecture.