The .legacyAlert modifier on a child view will be ignored. about swift-composable-architecture HOT 11 CLOSED

Issue persists on
swift-composable-architecture.git @ 1.5.0
swiftui-navigation.git @ 1.2.0

from swift-composable-architecture.

Hi @kdeda, can you please describe exactly what the problem is, and the steps to reproduce the problem. It is not clear right now.

Also, the project you have provided is quite complex. I would recommend trying to minimize it a great deal to make it easier for someone to help. Ideally it should be a project only involving legacyAlert since that is what you are reporting a problem with.

from swift-composable-architecture.

Say you have a main FeatureA with a ViewA that has 2 child features (FeatureB and FeatureC)
FeatureA can trigger and handle its own .legacyAlert

Each child feature, FeatureB and FeatureC has its own view, ViewB and ViewC
Each child feature can trigger and handle their own .legacyAlert

When these 2 child features are integrated into the main FeatureA/ViewA
the management of .legacyAlert is interrupted.

The attached Xcode project should demonstrate the issue.

from swift-composable-architecture.

Also, the project you have provided is quite complex. I would recommend trying to minimize it a great deal to make it easier for someone to help. Ideally it should be a project only involving legacyAlert since that is what you are reporting a problem with.

I tried to make it as short as possible.
One Parent Feature with 2 Child Features using Switch and CaseLet to switch between features.

from swift-composable-architecture.

The top "Alert Me" Action goes to the FeatureA
The "Switch to Other" changes the current child view/feaure displayed
The bottom "Alert Me" Action goes to the FeatureB or FeatureC

from swift-composable-architecture.

@kdeda I'm pretty certain is a vanilla SwiftUI problem with the original iOS 13 alert view modifier, which our library simply calls under the hood. One of the reasons why we have an "I have determined whether this bug is also reproducible in a vanilla SwiftUI project" checkbox for issues is that a lot of these bugs are not TCA-specific, and it's good to confirm that vanilla behavior works first.

If I recall, the general workaround is to throw alerts into parts of the view hierarchy where they are better behaved, e.g. inside a background modifier, though you may want to search for vanilla solutions to the problem.

I'm going to close this for now, but if you do determine that the issue is reproducible only in TCA, please file a new issue that demonstrates it working in vanilla SwiftUI.

from swift-composable-architecture.

Thank you,
I forgot about the entire vanilla thing, since I rarely use it.

from swift-composable-architecture.

Also your previous code worked which lead me to believe these where related ...

from swift-composable-architecture.

Bingo moving around the location .legacyAlert is attached makes a difference.
So we have a workaround.

from swift-composable-architecture.

This is just a vanilla SwiftUI bug and is not related to TCA at all. Here is a simple reproduction of the problem in plain SwiftUI:

import SwiftUI

struct AppView: View {
  @State var isAlertPresented = false

  var body: some View {
    VStack {
      Button {
        isAlertPresented = true
      } label: {
        Text("Alert Me")
      }
      Child1()
        .border(.yellow)
    }
    .alert(isPresented: self.$isAlertPresented) {
      Alert(title: Text("Hello"))
    }
  }
}

struct Child1: View {
  @State var isAlertPresented = false

  var body: some View {
    VStack {

      HStack {
        Button {
          self.isAlertPresented = true
        } label: {
          Text("Alert Me")
        }
      }
    }
    .alert(isPresented: self.$isAlertPresented) {
      Alert(title: Text("Hello"))
    }
  }
}

The first alert button works but the second does not. But if you comment out the alert(isPresented:) in the AppView body then the second alert button will work, but of course the first will not.

It seems there is a SwiftUI bug on Mac that prevents multiple alert modifiers from working.

Since this is not an issue with our library I am going to convert it to a discussion.

from swift-composable-architecture.

Oh sorry, I didn't see @stephencelis's response!

from swift-composable-architecture.