Giter Club home page Giter Club logo

poe-overlay-community-fork's Issues

Suggestion: Please give me a way to ONLY use MY browser, not the browser control you have

πŸš€ feature request

Is your feature request related to a problem? Please describe.
I HATE, with a BURNING RAGE PASSION, the browser control (or whatever it is) that you open web pages in. I know you have the tech to open my ACTUAL browser (in my case chrome) because I can open a Wiki or PoeDB page in chrome with the "alternate" keybinds.

Describe the solution you'd like
Rather than have multiple keybinds, have a setting that lets us pick "our" browser, versus whatever god awful browser control you guys are using by default, and have that apply to all keybinds, instead of multiple sets of keybinds.

Describe alternatives you've considered
I would begrudgingly accept a second keybind slot to open trades from CTRL+D in an ACTUAL browser.

Additional context

Suggestion: Add One-Button interactions

It should be possible to set hotkeys for several interactions that should be executed on a single button press.

For example:

  • invite a player
  • custom reply like sold

Hope I didn’t miss any major interaction. If I did please add to this issue.

Edit: Removed afk and dnd since it is already possible via Command module

Suggestion: Make Overlay not steal focus from PoE on Ctrl+D

πŸš€ feature request

In Awakened PoE Overlay, I can quickly Ctrl+D several items in my inventory once after the other while vendoring things. Because PoE Overlay takes focus on Ctrl+D popup, I have to re-select the PoE window after each Ctrl+D.

Chaos recipe helper

πŸš€ feature request

Using stash API search though stash and highlight items needed to make a chaos recipe

Requested by Efey

Remove references to old repo

This has been moved from github.com/ijemafe/PoE-Overlay to github.om/PoE-Overlay-Community/PoE-Overlay-Community-Fork. We should update all references to the old name.

Allow Overlay to be displayable while maintaining user input to game

πŸš€ feature request

Describe the solution you'd like
Allow PoE-Overlay dialogs to be shown while the user is playing the game.

Describe alternatives you've considered

Additional context
If this is implemented it will allow the foundation for more features to be implemented

Regression: Height of evaluate window is too big for some items

🐞 bug report

Describe the bug
When evaluating some items the evaluate overlay is taller than it should be. Seems to happen mostly with simple items with no properties (currency, skill gems, etc)

To Reproduce

  1. Evaluate a fossil (or a chaos orb)

Expected behavior
Proper overlay height

Screenshots
Old:
EvaluateUnnamedOld
New:
EvaluateUnnamedNew

Black flash when closing the popup on Vulkan

🐞 bug report

Describe the bug
Black flash when you close the overlay popup with vulkan

To Reproduce

Switch to Vulkan
Start a search on any item with ctrl + d
click on any result in the list to close the popup

black flash

Expected behavior
Just like direct X 11 version, no flash when closing the popup

Screenshots

🌍 Your Environment

windows 10 family 64 bits
poe overlay 0.6.28
steam lastest version of the game
playing in windowed fulscreen 1440p@120Hz

Mod: # added passive skills are jewel sockets (cluster jewel)

Describe the bug
The "# added passive skills are jewel sockets" mod on cluster jewels isn't listed in the overlay and can't be searched.

Steps to reproduce the behavior:

  1. Price-check a cluster jewel with the "# added passive skills are jewel sockets" mod

Expected behavior
The mod is listed and searchable for

Screenshots
PoE

🌍 Your Environment

  • OS: Win10 x64
  • Version: e.g. 0.7.1 installed
  • PoE: e.g. Steam 3.11.1 English

Bad Translations (German)

There are several translations that should be changed.

ubersetzung1
ubersetzung2
ubersetzung3

The automatic/initial search option should also be changed:
"FΓΌhren Sie die erste Suche aus" -> "Gegenstand automatisch suchen"

Add Localization for New Phrases

🐞 bug report

Describe the bug
Localization needed for newly added phrases:
-'Set Shortcut'
-'Cancel Setting Shortcut'
-'Reset'
-'Results'

To Reproduce
Set Shortcut:
-Open Overlay Settings
-Find any keyboard shortcut icon (looks like a keyboard)
-Hover over it

Cancel Setting Shortcut:
-Open Overlay Settings
-Find any keyboard shortcut icon (looks like a keyboard)
-Click it
-Hover over the now visible 'X' icon

Reset:
-Open item search overlay (ctrl+d on an item)
-Click the 3 lines in the top left to change filter options
-see the Reset button at the bottom of the now visible black box.

'Results':
-Open item search overlay (ctrl+d on an item)
-Click the 3 lines in the top left to change filter options
-see the 'Count' text near the bottom of the box. i.e. 30 Count.

Expected behavior
Phrases should be localized to the supported languages.
Count should be changed to Result and localized. English is set to Results, other languages are not.

Screenshots
image
image
image

🌍 Your Environment

  • OS: Window 10
  • Version: 0.6.8
  • PoE: Steam 3.10.2/c English

Suggestion: Provide Windows/all portable installs as ZIP

Request
Provide Windows/all portable installs as ZIP. It's much simpler to just extract into the existing folder instead of running the .exe. Especially in Window with the UAC. I haven't been able to get it to extract or run in Win10 (unless it did but there was no end-user feedback).

Solution
Please provide as ZIP or 7z file for a portable install.

Current Workaround
I'm currently opening it in 7zip to extract the files into my existing folder.

Suggestion: Use bulk item (item exchange) for currencies / consumable instead of normal trade

πŸš€ feature request

Is your feature request related to a problem? Please describe.
When you price check currencies, fossils, cards, etc etc, you always have trades instead of item exchange. In some case it's fine, but when someone have like 30 stack of the same card, it displays 30times the same name instead of once like in item exchange

Example (you can probably find other examples like this):
image
image
/edit: I don't understand also why it's red with different results when I search it... :/

Describe the solution / alternatives you'd like
Either group names, use the item exchange, or if it's too complicated, allow us to filter out names (like the ignore in the trade site)

Thanks for your work ! :)

Flask modifiers return Invalid Stat error and fail to pull results

🐞 bug report

Describe the bug

Item evaluation fails on various flask modifiers no matter what kind of range they are searched in
Seems to happen mostly on prefix mods, but I haven't been able to test every mod for flasks.

Affected Mods (Not sure if this list is complete)
P: Alchemist's
P: Experimenter's

To Reproduce
Pull up Item Evaluation window on a flask item
Select modifiers and run a search

Expected behavior
Should return regular search results, instead returns "No Data Found" followed by "2: Invalid stat provided: Explicit.stat_#########"

Screenshots

image

image

🌍 Your Environment

  • OS: Win10 64bit
  • Version: 0.7.1
  • PoE: Steam 3.11.0d English

Unable to bind certain keys under command tab

🐞 bug report

Describe the bug
Unable to assign End or Home and similar buttons under command tab

To Reproduce

  1. Create a command (under command-tab)
  2. Attempt to add End as shortcut

Expected behavior
Button should be assigned

Screenshots
Not applicable

🌍 Your Environment

  • OS: W10 Pro 2004
  • Version: 0.7.1 portable
  • PoE: Not needed to reproduce bug

Remove Pricing Method Tagging option

🐞 bug report

Describe the bug
The Tagging method is again GGG ToS

To Reproduce
Navigate Setting -> Evaluate -> Pricing Method and switch to Tagging
Price and item in your stash (in game) and click a result from a price check. This will auto tag your item.

Expected behavior
This Setting should not longer be enabled

Readme wrongly says the original PoE Overlay "was converted to closed source"

It seems like Kyusung4698 released the code of the new version(1.0.2) on github a few days ago.
While it may not be possible to use this code without the closed source platform overwolf, it still makes the original PoE overlay open source.
I suggest something like "was converted to require the closed source platform overwolf" instead.

Mod: Reduced Mana Reserved

πŸ›Έ Item modifier report

The Modifier is being searched incorrectly.
Because It's "reduced", the search value is negative. Due to it being negative, you have to put the "min" in "max" and visa versa. in order to search "1% reduced or more"

Item modifier
% Reduced Mana Reserved

Copied item data

Rarity: Unique
Conqueror's Efficiency
Crimson Jewel
--------
Limited to: 1
--------
Item Level: 1
--------
3% reduced Mana Cost of Skills
4% increased Skill Effect Duration
2% reduced Mana Reserved
--------
The stone may yet bleed.
--------
Place into an allocated Jewel Socket on the Passive Skill Tree. Right click to remove from the Socket.
--------
Note: ~price 20 chaos

Screenshots

image

Search performed:
https://www.pathofexile.com/trade/search/Standard/yX9D7glcR

Expected:
https://www.pathofexile.com/trade/search/Standard/7ZOwPY2t5

(Note the change in the min/max values of the "#% Increased Mana Reserved" stat filter)

🌍 Your Environment

  • Version: v0.6.28

Problem Searching for Unique Flasks

🐞

Bug Report

There is something wrong with how PoE Overlay searches unique flasks. From what I can see it grabs the implicits and the explicits and searches. As soon as you click off any implicits, the search completes and returns the correct results.

Examples:
Lion's Roar: returns no results with all mods selected. As soon as you unselect the +3000 armor (the implicit), the search results show properly.
Forbidden Taste: no results with all mods selected. Unselect chance to dodge attack hits and chance to dodge spell hits, results show up as normal.

To Reproduce
Search any unique flask, the bug worked for all the ones I owned.

Screenshots
Broken
roar broken
Working (after de-selecting the implicit)
roar working

🌍

Your Environment

  • OS: Win10 Pro
  • Version: 0.6.28
  • PoE: Steam 3.10.2/c English

Suggestion: Allow rebinding of Stash tab navigation (CTRL+Scroll)

Problem: Many players like to rebind their scroll wheel to send click inputs while modifier keys are held (ToS compliant since it's only one action per input) , specifically in this case i want to be able to hold down control and scroll to move items in and out of stash. as of now, that means i have to disable the CTRL+Scroll stash navigation, one of my favorite features of overlay.

Request: Allow the CTRL+scroll functionality to be set to another modifier key in the config

Mod: Chance to Poison on Hit being searched as "local" even though it's global

Copying my original bug report from the dead version: https://github.com/Kyusung4698/PoE-Overlay/issues/710

πŸ›Έ Item modifier report

Current item modifier

%# CHANCE TO POISON ON HIT (LOCAL)

Expected item modifier

%# CHANCE TO POISON ON HIT

Copied item data

Rarity: Rare
Hate Barb
Vaal Rapier
--------
One Handed Sword
Physical Damage: 22-87
Elemental Damage: 4-94 (augmented)
Critical Strike Chance: 6.50%
Attacks per Second: 1.30
Weapon Range: 14
--------
Requirements:
Level: 66
Dex: 212 (unmet)
--------
Sockets: G G 
--------
Item Level: 74
--------
+25% to Global Critical Strike Multiplier (implicit)
--------
Adds 4 to 94 Lightning Damage
Attacks have 20% chance to cause Bleeding
27% increased Damage with Bleeding
25% chance to Poison on Hit
35% increased Damage with Poison
18% chance to Blind Enemies on Hit with Attacks
--------
Redeemer Item

Screenshots

Searching for my item with "Chance to poison" through overlay (Not found)
image
Searching through official trade to make sure it's found (not using "local" version of mod, but global), it is found:
image
Item I was searching for in my stash:
image

🌍 Your Environment

  • Version: e.g. 0.6.9 portable
    0.6.28 (2020-05-09) (installed)
  • PoE: e.g. Steam 3.10.0/e English
    Current Steam version (3.10.1?)

Ctrl+D never works

When using Ctrl+D on an item to price check it always simply says "An Error Occurred" instead of the price, and the following error is in the log:

[2020-06-22 14:38:31.659] [warn] TypeError: Cannot read property 'id' of undefined
    at file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:18197913
    at Array.map (<anonymous>)
    at a.project (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:18197846)
    at a._tryNext (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17081057)
    at a._next (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17080959)
    at a.next (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17069070)
    at a.notifyNext (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17081494)
    at a._next (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17076243)
    at a.next (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17069070)
    at a.notifyNext (file:///C:/Program%20Files/poe-overlay/resources/app.asar/dist/main.82dd510b23ec29c19749.js:1:17081494)

Using version 0.7.1.

Uninstalling, manually removing %appdata\roaming\poe-overlay and reinstalling did not fix the issue.

Suggestion: Chain Evaluations

It should be possible to "chain" evaluations, meaning that there is no more need to press ESC to select the next item to evaluate.

We might have to test first, if it is possible to copy from poe if the window doesn't have focus.

Suggestion: Support for private leagues

Are there any plans for the ability to price check private leagues? Even the ability to open the trade site in an external browser with the private league id in the url would be nice.

Installation Aborted

image

For some reason I'm getting Installation Aborted when I'm trying to install "poe-overlay-Setup-0.6.28.exe" What could that be about?

Partial icon in Windows Taskbar

🐞 bug report

Describe the bug
The app icon (from the settings menu) doesn't show properly in the windows task bar

Screenshots

image

🌍 Your Environment

  • OS: Win 10 x64
  • Version: 0.7.1
  • PoE: 3.11.0

Evaluate Setting seemto offer the option to add profiles but it doesn't work.

🐞 bug report

Describe the bug

On the Settings menu, the Evaluate part, has a section called "Preselected Profiles".
Under it, the is the "Default" profile and next to it there is a "+" sign, which I assume is to add different Evaluate profiles, but clocking on it does nothing.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Settings
  2. Click on Evaluate
  3. Scroll down to Preselected Profiles
  4. See error of not being able to click on the "+" to create more profiles.

Expected behavior

I expect to be able to create different profiles by clicking on the "+" symbol so I can store different types of evaluation (normal one with the 10% difference, a "uniques" one with no tolerance to check for exact rolls on the values...

Screenshots

image

🌍 Your Environment

  • OS: Win 10 x64
  • Version: 0.7.1 portable
  • PoE: Steam 3.11.1 English

Small AppImage issues

  • The icon is stored in a 0x0 folder instead of 256x256 which is its size. I packaged the AppImage on AUR for Arch Linux and this turns out to be an issue for example on KDE, where the icon is not rendered in the start menu.
mv /usr/share/icons/hicolor/0x0 /usr/share/icons/hicolor/256x256
  • Comment on poe-overlay.desktop is not grammatically correct
Comment=A Overlay for Path of Exile. Built with Electron and Angular.
>>>
Comment=An overlay for Path of Exile. Built with Electron and Angular.
  • The icon could be named something better than just Name=poe-overlay, it looks a bit weird
    image

Mod: Search for Flask quality

You can't search for flask quality.

Copied item data

Rarity: Magic
Alchemist's Quicksilver Flask of Adrenaline
--------
Quality: +20% (augmented)
Lasts 3.50 (augmented) Seconds
Consumes 20 of 50 Charges on use
Currently has 0 Charges
40% increased Movement Speed
--------
Requirements:
Level: 16
--------
Item Level: 61
--------
25% increased Movement Speed during Flask effect
25% increased effect
33% reduced Duration
--------
Right click to drink. Can only hold charges while in belt. Refills as you kill monsters.

Screenshots
image

🌍 Your Environment

PoE 3.11 standalone

Suggestion: Add version number/version date to poe-overlay

πŸš€ feature request

Is your feature request related to a problem? Please describe.

I tried to check if poe-overlay is already the most current version, but can't. While autoupdate is technically on it would be nice to be able to check

Describe the solution you'd like

add info to the settings

Describe alternatives you've considered

on launch display a image stating basic information about the program

Additional context

Legacy software did struggle with updates, so there is distrust

ps: the template should state edit below. My text was commented out.

[LINUX] Can't see game over black foreground

I get a black screen with PoE Overlay on bottom left, from time to time for a few seconds it switches back to the game.

Am using poe-overlay-0.7.1.AppImage

Arch Linux
KDE
Nvidia 440.82
Both on DX11 and Vulkan renderers
Windowed Borderless

image

Seems like this issue on upstream https://github.com/Kyusung4698/PoE-Overlay/issues/431

I've tried the workaround mentioned here https://www.reddit.com/r/pathofexile/comments/hbmksa/poe_overlay_community_fork_v071_release_100/fvbmcrk/ to no avail.

EDIT: Got it to work, albeit crappily.

  1. Launch PoE Overlay
  2. Disable HW acceleration in PoE Overlay (right click on tray icon - uncheck checkbox)
  3. Launch PoE
  4. For KDE, compositing must be active. You can toggle the state either via they key combination SHIFT+ALT+F12, or via terminal, where you can also verify that it is enabled:
$ qdbus org.kde.KWin /Compositor org.kde.kwin.Compositing.suspend
$ qdbus org.kde.KWin /KWin supportInformation | grep "Compositing is"
Compositing is not active
$ qdbus org.kde.KWin /Compositor org.kde.kwin.Compositing.resume
$ qdbus org.kde.KWin /KWin supportInformation | grep "Compositing is"
Compositing is active

If you can't toggle compositing on, verify that you don't have OpenGLIsUnsafe=true in ~/.config/kwinrc, if so, set it to False or remove the line, and reboot.

  1. Turn game into Windowed mode. Windowed Fullscreen/Fullscreen won't work for me
  2. Vsync needs to be on (in the game)
  3. If you still can't see the game, press ALT+ENTER once or twice to fullscreen/unfullscreen the game
  4. Stretch the game to fullscreen

image
9) If RNG gods are with you, you now have working overlay, although the performance seems like ass (60 FPS lock on 144Hz screen for me perhaps)

Add Git Workflow Documentation to DEVELOPERS.md

Up to this point, we have merged pull requests into the master branch, cutting releases at significant milestones.

There is now a v0.7.0 release from master snapshotting the changes up to this point. There is also now a dev branch.

We should discuss what our pull request, merge, and release processes are for accepting changes:

  • Merge PRs into master or dev? If dev, disallow commits to master without a dev merge and subsequent release?
  • What is the release process (branches, tagging, builds)?

Linux Support

Add complete Linux support:

  • Building/Developing on Linux
  • Running on Linux

100% support for Harvest League features

Each league, libggpk is used to parse data (items, maps, etc.) and add it to PoE-Overlay. We should automate this process and add the resulting files for Harvest League.

Suggestion: Logout via port kill

πŸš€ feature request

Is your feature request related to a problem? Please describe.
logout via port kill, /exit could be to slow

Describe the solution you'd like
6112 - Game Client port (udp/tcp)
https://www.npmjs.com/package/kill-port for implementation

Additional context
need one of you UI guys for a predefined setting with changeable keybind, I'll do the port killing logic in the background

Can't disable autoupdate

I'm packaging POC for Arch, and thus need to disable the autoupdate check in the AppImage as it is pointless in that case.

I tried removing resources/app-update.yml, but that just errors out.

What is the correct way to disable the check?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.