podverse / podcast-feed-parser Goto Github PK

I'd like to use this parser to parse value time split tags. It looks like this feature is not yet supported by the parser. I would like to attempt to add support for the <podcast:valueTimeSplit> tag.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:alternateEnclosure tag to the podcast-feed-parser > index.js file.

Link to the alternateEnclosure spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

This package works great for a great range of feeds. However I'm having trouble with feeds that use the xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd" in their nodes. Is there a config option I've missed that will allow this?

A feed with Namespace is not valid according to this parser when I pass it through podcastFeedParser.getPodcastFromFeed(rawFeed, options);

The raw feed is below (the actual values are dummy values)
Options are below that

To Reproduce

<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd">
	<channel>
		<title>Podcast 1</title>
		<description>Description...</description>
		<link>https://www.website.com/podcast</link>
		<copyright>(c) 2023 - .</copyright>
		<docs>http://blogs.law.harvard.edu/tech/rss</docs>
		<docs>http://phobos.apple.com/static/iTunesRSS.html</docs>
		<language>de-ch</language>
		<lastBuildDate>Fri, 22 Sep 2023 10:25:41 +0200</lastBuildDate>
		<pubDate>Fri, 22 Sep 2023 10:25:41 +0200</pubDate>
		<managingEditor>[email protected]</managingEditor>
		<webMaster>[email protected]</webMaster>
		<generator>Webmaster's capable fingers</generator>
		<image>
			<url>https://website.ch/stream/srp/fit-statt-fett/r1-podcast-3000x3000.jpg</url>
			<title>Podcast 1.</title>
			<link>http://www.website.ch/</link>
			<description>Podcast</description>
			<width>200</width>
			<height>200</height>
		</image>
		<ttl>15</ttl>
		<itunes:owner>
			<itunes:name>Podcast 1.</itunes:name>
			<itunes:email>[email protected]</itunes:email>
		</itunes:owner>
		<itunes:category text="Sports"/>
		<itunes:author>Podcast 1 .</itunes:author>
		<itunes:explicit>No</itunes:explicit>
		<itunes:keywords>experten, experte, fett, fit, medizin, recht, multimedia, erotik, eros, gesundheit, arbeit, arbeitsrecht, heimwerker, kino, gastronomie, wirtschaft, bildung, literatur</itunes:keywords>
		<itunes:subtitle>Podcast 1.</itunes:subtitle>
		<itunes:summary>Summary.</itunes:summary>
		<itunes:image href="https://2021.radio1.ch/stream/srp/fit-statt-fett/r1-podcast-3000x3000.jpg"/>
		<item>
			<title>Training</title>
			<link>https://www.website.ch/podcast</link>
			<description></description>
			<author>[email protected] (1634)</author>
			<category>Sports</category>
			<pubDate>Fri, 22 Sep 2023 10:20:38 +0200</pubDate>
			<guid>{PODCAST-1}</guid>
			<enclosure url="valid_link_to.mp3" length="3259873" type="audio/mpeg"/>
			<itunes:duration xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd">03:19</itunes:duration>
			<itunes:keywords xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd">Keyword1,Keyword2</itunes:keywords>
			<itunes:category xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd" text="Sports"/>
			<itunes:author xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd">1634</itunes:author>
			<itunes:subtitle xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd">Subtitle</itunes:subtitle>
			<itunes:summary xmlns:itunes="http://www.itunes.com/DTDs/Podcast-1.0.dtd"></itunes:summary>
		</item>

	</channel>
</rss>

    const options: PodcastFeedParserOptions = {
        fields: {
            meta: ["default", "ttl", "keywords"],
            episodes: ["default", "keywords"]
        },
        // an error
        required: {
            meta: [],
            episodes: []
        },
        uncleaned: {
            meta: [],
            episodes: []
        }
    };

Expected behavior
I would have thought there was a way to process these podcasts with the namespace.

Environment (please complete the following information):

• Macbook
• Node Version: 14
• I'm actually using an older version but I've tried with the latest and it's the same

Thanks for your help and the package.

I read through the docs: https://www.npmjs.com/package/@podverse/podcast-feed-parser - but don't see how to set the userAgent my app will use when making HTTP calls to podcast feed URLs.

Some podcast hosting platforms validate requests based on userAgents and it's generally a best-practice to provide a good userAgent:

• https://pub.dev/packages/just_audio#working-with-headers
• https://developers.whatismybrowser.com/learn/browser-detection/user-agents/user-agent-best-practices

Can you help provide an example on how to set it?

It would be extremely valuable for development and testing purposes if we had a sample podcast RSS feed that contains valid data for every possible podcast RSS feed namespace.

The feed should contain:

• A channel (podcast) level tag.
• Multiple item (episode) level tags. (At least 2, and possibly more if there is a good reason for it, but otherwise keep the number of episodes to a minimum.)
• Valid examples of the most commonly used namespaces for channel and item.
• If there are links to content (like mp3s) the content has to be available in the public domain.
• Include examples for all of the closed Podcasting 2.0 namespaces. Documentation
• Some of the Podcasting 2.0 namespaces may require other standardized files. For example, the podcast:chapters namespace provides a link to an external JSON file that has its own standards. Ideally we will have sample files for these some day as well, but those sample files are not required for this issue.
• Since this is for dev purposes the content in the feed should be neutral, either lorem ipsum style, or just not political or controversial.

In a separate issue we can add a process for running a localhost server so you can access the RSS via network requests locally.

There's a lot of different ways that this could be accomplished, so please let us know if you have any questions about what direction to go in.

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:guid tag to the podcast-feed-parser > index.js file.

Link to the guid spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:license tag to the podcast-feed-parser > index.js file.

Link to the license spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:person tag to the podcast-feed-parser > index.js file.

Link to the person spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:trailer tag to the podcast-feed-parser > index.js file.

Link to the trailer spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Describe the bug
The npm version badge and screenshot in the README shows information for what one gets from npm install podcast-feed-parser, not npm install @podverse/podcast-feed-parser.

Expected behavior
Change the badge and screenshot to be the forked version.

Screenshots

Additional context
I was using the upstream repository (i.e. podcast-feed-parser) and essentially found this repo looking for a fix to #14 -- my guess is this fork is a continuation of the upstream work? It'd perhaps be nice to explain that itself somewhere, or if it's already written out obviously ignore (and let me know if so!)

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:episode tag to the podcast-feed-parser > index.js file.

Link to the episode spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:location tag to the podcast-feed-parser > index.js file.

NOTE: I started to add the podcast:location tag months ago, but the code is commented out in the file, and I don't know if it works. If you could uncomment, test, and update the code if needed we'd really appreciate it.

Link to the location spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

It would be useful for development purposes to be able to run a server locally that lets us make network requests to localhost to access sample RSS feeds.

• If a server library is needed, add it as a devDependency so it is not included in the released module version.
• Include instructions for running the server locally and making network requests to it. Add these instructions within the CONTRIB.md file in the "Development workflow" section (or somewhere else you think is a better home for it).
• If you need an RSS feed for dev testing, I recommend @johnchidgey's RSS feed for Causality.

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

Hey there!

I noticed that this repository's default branch is develop, but it also has a master branch, which is what is published on NPM. Is there a purpose for the develop branch, or would you be interested in changing the default to master and deleting develop?

Thanks!

Describe the bug
The pinned version of xml2js is vulnerable to this vulnerability which dependabot will flag.

To Reproduce
Steps to reproduce the behavior:

1. Install podcast-feed-parser
2. Enable dependabot

Expected behavior
Upgrade to >0.5.0

Podcasting 2.0 is a collective of app developers making new podcast app features possible by extending the RSS spec. One of the goals of the podverse/podcast-feed-parser repo is to support all of the Podcasting 2.0 namespaces.

For this issue, add support for the podcast:season tag to the podcast-feed-parser > index.js file.

Link to the season spec

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.