Immediate issue

The HSRmHighlight documentation states:

:HSRmHighlight <rm_all>: If the rm_all argument is given, removes all the highlighting in the current buffer. If not, does the same but for every line in visual selection.

Removing all highlights works fine.

However visually selecting a range and runing the function throws the following error:

E481: No range allowed

I tried both visual line and line selections, and both throw the same error.

I just realized that it was an issue with the Highlight command as well: the command doesn't work on what is currently visually selected; but it works when nothing is selected, it will highlight what was last selected.

Reproduction steps:

1. Visually select anything.
2. Run :HSHighlight 1 (the command line should show :'<,'>HSHighlight 1).

3. E481: No range allowed

4. You should be back in normal mode at this point, run :HSHighlight 1 again.
5. What was previsouly selected is now properly highlighted.

Other unexpected behavior

:HSRmHighlight will apparently remove more than what was last selected:

Removing line-wise highlights

Reproduction steps:

1. Highlight line n with color X (<S-v> mapping).
2. Highlight line n + 1 with color Y
3. Run :HSRmHighlight without anything visually selected.
4. Both lines should be erased except the first character of line n (in color X). it should only have erased the last thing we selected (the last highlight, in color Y).

Removing "regular" highlights

Reproduction steps:

1. Highlight a few characters on a line with color X.
2. Highlight some other characters on that line with color Y.
3. Run :HSRmHighlight without anything visually selected.
4. The entire line highlights are erased. Both X and Y colors.

The relative position of the highlighted ranges does not matter.

Bonus

It appears that the :HSRmHighlight command also erases highlights from other plugins such as indent-blankline, fortunately that's a temporary issue.

Hi,

If I export selected lines/words, close file and reopen it and import color selections, it's not complete, and I don't sure if it problem with my configuration, or doing some wrong.

-- HighStr.nvim -------------------------------------------------------------------------------------------------------------------------------------------
local high_str = require("high-str")

high_str.setup({
	verbosity = 0,
	saving_path = "/tmp/highstr/",
	highlight_colors = {
		-- color_id = {"bg_hex_code",<"fg_hex_code"/"smart">}
		color_0 = {"#0c0d0e", "smart"},	-- Cosmic charcoal
		color_1 = {"#e5c07b", "smart"},	-- Pastel yellow
		color_2 = {"#7FFFD4", "smart"},	-- Aqua menthe
		color_3 = {"#8A2BE2", "smart"},	-- Proton purple
		color_4 = {"#FF4500", "smart"},	-- Orange red
		color_5 = {"#008000", "smart"},	-- Office green
		color_6 = {"#0000FF", "smart"},	-- Just blue
		color_7 = {"#FFC0CB", "smart"},	-- Blush pink
		color_8 = {"#FFF9E3", "smart"},	-- Cosmic latte
		color_9 = {"#7d5c34", "smart"},	-- Fallow brown
	}
})
vim.api.nvim_set_keymap(
    "v",
    "<F3>",
    ":<c-u>HSHighlight 1<CR>",
    {
        noremap = true,
        silent = true
    }
)

vim.api.nvim_set_keymap(
    "v",
    "<F4>",
    ":<c-u>HSRmHighlight<CR>",
    {
        noremap = true,
        silent = true
    }
)

I have been highlighting my neorg notes, which works as expected. Then I am able to save them with the HSExport command, however, when I attempt to import them again, the highlights appear but seem to highlight more than what was saved. E.g if I highlight a word and save it with HSImport, then I exit the buffer and open it again and type HSImport, the word will be highlight and some of the spaces before it. In some cases it even highlights the entire line even though I selected one word. How can I fix this? Any help would be appreciated! @pocco81

Whenever I try to highlight a text, it throws this error
Undefined variable: v:lua

Could you please resolve this?

Is there a way to set up an autocmd (or something) to call HSHighlight when entering visual mode and then call HSRmHighlight when exiting visual mode? I have them mapped to F3/F4 as shown in the README but having 'the system' do it automatically would be even better.

Hello @pocco81, I would like to ask if this great project is still active in development.

Thank you 👍 .

neovim 0.5 only builds with lua 5.1 or compatible (i e luajit 2.1 ). Can probably remove the line completely as it is also impossible to build neovim 0.5 without lua 5.1 or luajit.

I find this plugin interesting.
However, there are some improvements I would find useful:

• Allowing highlight using text-motions would be interesting.
• Allow, in normal mode, unhighlight the highlighting under cursor.
• As in another feature request, ability to jump to the next or previous highlighting.

What do you think?

Example:

HSExport /path/to/file1.txt
HSExport /path/to/file2.txt

HSImport /path/to/file1.txt

Title.
on adding highlight maybe adding some entries in a file
and the file is read on plugin load to get a save state of markers

Hi, great plugin : )

in my case i cannot save the highlightings

I highlight something and then :HSExport path/

but it outputs E488: Trailing characters

I've tried with ~/path/path/
also creating the folder.

Probably doing something wrong on my side.

Just for future reference and anyone wondering how to achieve removing all highlights in the open buffer in one go, see below for global function snippet.

function _G.highstr_highlight_remove_all()
  local api = vim.api
  local buffer_current_number = api.nvim_eval([[bufnr('%')]])
  local line_last = vim.fn.line('$')

  api.nvim_buf_clear_namespace(buffer_current_number, 0, 1 - 1, line_last)
end

You can call this function as follows: lua _G.highstr_highlight_remove_all()

Cheers for the great plugin !

E.g. Highlighting a selection of just one unicode symbol actually highlights nothing

It would be great to add those commands:

• Add/remove highlight to all of the instances of the selected word (normal mode) or string (visual mode)

• In current buffer only
• In all buffers

• Jump to the next/previous string belonging to the same highlight group

• In current buffer only
• In all buffers

Hey there,

I've been using your plugin to finally fill in that void of being able to highlight lines persistently across buffers.

The export and import stuff is great too, helps me keep my place when trying to learn large code bases.

The only thing I feel is lacking here is a "jump to previous" and "jump to next" highlight feature.

The use case being, you're studying a large code base, and making highlights along the way, you export and some time later, you import. It would be nice if you did not have to remember where your highlights were and could cycle thru them, jogging your memory.

The default value for saving_path is currently:

saving_path = "/tmp/highstr/"

But when configuring it like this in Windows:

saving_path = "C:\\Work\\"

then the cords.txt file is created in the C:\tmp\highstr directory.

Currently using with one dark theme, but the highlight is not highlighting texts in vim terminal for me.