pnpnpn / retry-decorator Goto Github PK

The Chromium project (www.chromium.org) pulls in retry-decorator indirectly through the catapult (https://github.com/catapult-project/catapult/) and gsutil (https://github.com/GoogleCloudPlatform/gsutil) source repositories. In order for Chromium to be pulled into various Linux source distributions there's a requirement that all of the third party files pass the Linux licensecheck utility. Currently there are many files in the retry-decorator repository missing per-file licenses. From a current run of licensecheck, they are:

$ licensecheck -r . | grep "No copyright"
./setup.py: *No copyright* UNKNOWN
./retry_decorator/__init__.py: *No copyright* UNKNOWN
./retry_decorator/retry_decorator.py: *No copyright* UNKNOWN

We'd like to ask that per-file licenses be added to these files to make it easier to integrate retry-decorator not only into Chromium, but also Linux distributions in general. Thanks.

Is it possible to execute some code before retrying?

For example:

try:		
	return function(base_db, sql_string, sql_vars, debug_sql)
except (AttributeError, MySQLdb.OperationalError):
	base_db.__init__()
	return self.retry_db_errors(function(base_db, sql_string, sql_vars, debug_sql))

Could you please consider to add tests/ and CHANGES.txt into release?

Hi!

Could you add a setup.cfg and enable the bdist universal option?

[bdist_wheel]
universal = 1

It would make installing the library via py2 and py3 easier.

And then upload this wheel to PyPI as a new version?

Could you please tag 1.1.0?

See https://github.com/pnpnpn/retry-decorator/blob/master/retry_decorator/retry_decorator.py#L34:
when callback_by_exception is defined and in effect, then run_one_last_time is defaulted to False.

1. why is it so?
2. what's the purpose of run_one_last_time to begin with? To be able to swallow exceptions by the retry logic?

In any case, run_one_last_time should always default to True.

Is it possible to use this extension for multiple exceptions?

that parameter name should be replaced with "wait_secs" or "interval_secs" or something - it doesn't look like it's a timeout at all, but the interval between retries from what I can see.