Giter Club home page Giter Club logo

sp-dev-fx-property-controls's Introduction

sp-dev-fx-property-controls

Property controls for the SharePoint Framework solutions.

If you are looking for content controls, please check following repository for those - https://github.com/pnp/sp-dev-fx-controls-react

Get Started

More information to get started can be found documentation of this repository: documentation.

Have issues or questions?

Please use following logic on submitting your questions or issues to right location to ensure that they are noticed and addressed as soon as possible.

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com.

When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

If you have ideas for new features or feedback, let us know by creating an issue in the issues list. Before you submit a PR with your improvements, please review our project guides.

Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

"Sharing is Caring"

Disclaimer

THIS CODE IS PROVIDED AS IS WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.

sp-dev-fx-property-controls's People

Contributors

ajixumuk avatar anoopt avatar c-eiser13 avatar dependabot[bot] avatar ellinge avatar erwinvanhunen avatar estruyf avatar gautamdsheth avatar guidozam avatar hiltongiesenow avatar hugoabernier avatar jakestanger avatar jeannetryvalere avatar joaojmendes avatar joelfmrodrigues avatar jrodriguesstorm avatar lafe avatar mhomol avatar nanddeepn avatar rlarave avatar rocketboy1908 avatar rogerzhang-catapultsystems avatar russgove avatar s-kainet avatar spdavid avatar spplante avatar sudharsank avatar thechriskent avatar vesajuvonen avatar wardwilmsen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sp-dev-fx-property-controls's Issues

Color Pickers optionally return Color Objects

Category

  • Enhancement
  • Bug
  • Question

Desired Behavior

The PropertyFieldColorPicker and the PropertyFieldSwatchColorPicker both return CSS-compatible strings, but it would be nice if they could optionally return an object with more details. This was originally requested by sprider (Issue #52).

By default, both property fields would return strings. However, an optional valueAsObject (boolean) property would be added that, when true, would set the targeted property to an IColor (import { IColor } from 'office-ui-fabric-react/lib/utilities/color';) object instead. The selectedColor property could also be specified as either a string or an IColor object.

The IColor interface returns:

{
  str: string; //CSS-compatible string
  hex: string; //Hex value (does not reflect alpha)
  r: number; //Red
  g: number; //Green
  b: number; //Blue
  h: number; //Hue
  s: number; //Saturation
  v: number; //Value
}

image

Use components outside of a spfx project

Category

[ ] Enhancement

[ ] Bug

[x ] Question

Version

Please specify what version of the library you are using: [1.5.0]

Question

I would like to know, if there is a way to use these components outside of a spfx context ?
In my case I would like to create a Panel and add some controls in it.
To do that I created a React project and added the built files in a SharePoint page.
My problem is when I'm trying to integrate these react components in my project, it doesn't build
--> spfx context

Thanks!

Taxonomy Property Control picker doesn't not work with Termset GUID

Category

[ ] Enhancement
[X ] Bug
[ ] Question

Version

Please specify what version of the library you are using: [ 1.5.0 ]

Expected / Desired Behavior / Question

Taxonomy picker property control getTermStores() method is designed to work with TermsetGUID but doesn't work if termsetGUID is provided. The method is part of SPTermStorePickerService.ts class under \src\services.

Observed Behavior and fix

The groups don't load when Termset GUID is provided.
The fix is to change the code in the getTermStores() method to be a substring check instead of equal to.

Current code (not working)
termGroups = termGroups.map((group: IGroup) => {
group.TermSets.Child_Items = group.TermSets.Child_Items.filter((termSet: ITermSet) => termSet.Name === termsetNameOrId || termSet.Id.toLowerCase() === termsetNameOrId.toLowerCase());
return group;
});

Fixed Working code
termGroups = termGroups.map((group: IGroup) => {
group.TermSets.Child_Items = group.TermSets.Child_Items.filter((termSet: ITermSet) => termSet.Name === termsetNameOrId || termSet.Id.toLowerCase().indexOf(termsetNameOrId.toLowerCase()) !== -1);
return group;
});

Could we re-validate the above change and release an update. Please let me know if there are more queries.

Steps to Reproduce

Initialize and call the termstore method as below.
let termPickerHostProps : ISPTermStorePickerServiceProps = {
limitByGroupNameOrID: "",
limitByTermsetNameOrID: termSetGuid,
excludeSystemGroup: true
};
let termsService : SPTermStorePickerService = new SPTermStorePickerService(termPickerHostProps, context);
termsService.searchTermsByName("d").then((terms : IPickerTerm[]) => {
return resolve(terms);
}).catch((response: any) => {
return reject("Error in getTermSetCount for termSet ID " + termSetGuid + "Error = " + response.message);
});

Thanks!
Asish

[PropertyFieldDateTimePicker] Add ability to hide labels in front of the pickers

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: 1.7.0

Expected / Desired Behavior / Question

I expected the PropertyFieldDateTimePicker should have a look and feel similar to the date time picker we had in SharePoint list.
screen shot 2018-07-04 at 5 01 50 pm

I would like to suggest add a property to the control, such that user can disable the label.

Observed Behavior

Now we have labels before date time pickers property control, however, no any other default property controls nor pnp property controls has label in front of the controls. If we use date time picker control together with another property controls, the date time picker control looks odd.

screen shot 2018-07-04 at 5 15 48 pm

Steps to Reproduce

N/A

PropertyFieldListPicker - has a dependency on "@microsoft/sp-http" that is not declared in the manifest

Category

  • Enhancement
  • Bug
  • Question

Version

1.7.0

Expected / Desired Behavior / Question

A selection list when editing the webpart properties.

Observed Behavior

An error after adding the webpart to the page.
image

`[SPLoaderError.loadComponentError]:
***Failed to load component "115bf84d-5af9-4ff7-88e3-8b2c8d192cdf" (BookmarksWebPart).
Original error: ***The entry point for component "115bf84d-5af9-4ff7-88e3-8b2c8d192cdf" (BookmarksWebPart) has a dependency on "@microsoft/sp-http" that is not declared in the manifest.

***INNERERROR:
***The entry point for component "115bf84d-5af9-4ff7-88e3-8b2c8d192cdf" (BookmarksWebPart) has a dependency on "@microsoft/sp-http" that is not declared in the manifest.
***CALLSTACK:
Error
at t [as constructor] (https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-06-08.007/sp-pages-assembly_en-us_17eeb54eb455f1d2680d2ddff54b1859.js:656:15770)
at new t (https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-06-08.007/sp-pages-assembly_en-us_17eeb54eb455f1d2680d2ddff54b1859.js:1401:22633)
at Function.e.buildErrorWithVerboseLog (https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-06-08.007/sp-pages-assembly_en-us_17eeb54eb455f1d2680d2ddff54b1859.js:1401:14508)
at Function.e.buildLoadComponentError (https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-06-08.007/sp-pages-assembly_en-us_17eeb54eb455f1d2680d2ddff54b1859.js:1401:10707)
at https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-06-08.007/sp-pages-assembly_en-us_17eeb54eb455f1d2680d2ddff54b1859.js:1401:65121`


Content of my manifest.json
`{
"$schema": "https://developer.microsoft.com/json-schemas/spfx/client-side-web-part-manifest.schema.json",
"id": "115bf84d-5af9-4ff7-88e3-8b2c8d192cdf",
"alias": "BookmarksWebPart",
"componentType": "WebPart",

// The "" signifies that the version should be taken from the package.json
"version": "
",
"manifestVersion": 2,

// If true, the component can only be installed on sites where Custom Script is allowed.
// Components that allow authors to embed arbitrary script code should set this to true.
// https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
"requiresCustomScript": false,

"preconfiguredEntries": [{
"groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other
"group": { "default": "Other" },
"title": { "default": "Bookmarks" },
"description": { "default": "" },
"officeFabricIconFontName": "Page",
"properties": {
"description": "Bookmarks"
}
}]
}`


The error does not appear in the local workbench.

image

Steps to Reproduce

  1. Create a SPFx webpart
  2. Install sp-dev-fx-property-controls package
  3. Add PropertyFieldListPicker control as mentioned in https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyFieldListPicker/
  4. Execute the app using gulp serve
  5. Add the app to a page.

Can not set property 'Operation' of undefined

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[* ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!

Observed Behavior

If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a
suggestion or asking a question delete this section.

Steps to Reproduce

If you are reporting an issue please describe the steps to reproduce the bug in sufficient detail to allow testing. If you are making
a suggestion or asking a question delete this section.

Submission Guidelines

Delete this section after reading

  • All suggestions, questions and issues are welcome, please let us know what's on your mind.
  • Remember to include sufficient details and context.
  • If you have multiple suggestions, questions, or bugs please submit them in separate issues so we can track resolution.

Thanks!

Dutch localization

Category

[x] Enhancement
[ ] Bug
[ ] Question

Add Dutch localization labels

PropertyFieldColorPicker Palette Icon alignment Issue

Category

  • Bug

Version

1.6.0

Browser

All major

Expected

Fix the alignment issue

Observed Behavior

The color palette icon is moving towards right on SharePoint pages with webpart zone but the same works as expected in workbench when we debug

Workbench page output
with workbench page

Sharepoint page output
with sharepoint page
Note: I do not have any other customization or webparts in this page

Steps to Reproduce

  1. Create a SPFx webpart
  2. Install sp-dev-fx-property-controls package as mentioned in https://sharepoint.github.io/sp-dev-fx-property-controls/
  3. Add PropertyFieldColorPicker property
  4. Execute the app using gulp serve
  5. Open the local workbench page in browser and add the app
  6. Edit the PropertyFieldColorPicker property
  7. Notice the icon alignment issue
  8. Package the app the check the same from a Sharepoint page with webpart zones.

Thanks!

People Picker console error

Category

[ ] Enhancement

[ X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.4.2 ]

Expected / Desired Behavior / Question

Typing a partial user name returns that user in the suggestions pane

Observed Behavior

no user is displayed and a script error appears in the console

Steps to Reproduce

  1. WIth the control in a web part, open the properties panel.
  2. Add a user to the control
  3. save the page containing the web part
  4. edit the page again and remove the user from the control
  5. now type the name of a known user
  6. most of the time this sequence will trigger the error.

image

Looking at the source code leads me to believe that under some conditions, the searchPeople method in SPPeopleSearchService.ts is called with the 'this' object undefined.

// the method throwing the error :

public searchPeople(query: string, principalType: PrincipalType[]): Promise<Array> {
if (Environment.type === EnvironmentType.Local) {
// If the running environment is local, load the data from the mock
return this.searchPeopleFromMock(query);
} else {
// If the running env is SharePoint, loads from the peoplepicker web service

// this line throws the error that "this.context.pageContext" is undefined

  const userRequestUrl: string = `${this.context.pageContext.web.absoluteUrl}/_api/SP.UI.ApplicationPages.ClientPeoplePickerWebServiceInterface.clientPeoplePickerSearchUser`;

This was reproducible in both Chrome and FireFox

Dave

make webpart controls usable in propertypane

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[ ] Bug

[x ] Question

so why do w have. separate repo for property pane controls , an another for controls to be used in the body of a webpart? is it possible to encapsulate a controls that can be used in a webpart so that it could also be used in a property pane? could save a lot of effort.
Thanks!

PropertyFieldListPicker - type error in ** this.context ** in the sample object properties.

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [
Beta 1
]

Expected / Desired Behavior / Question

this.context in PropertyFieldListPicker would map to a valid or included type.

Observed Behavior

Get error that type of property 'context' are incompatible.
Error output:
file: 'file:///c%3A/Dev/sp/lrn/spfx/no-framework00/src/webparts/noFramework00/NoFramework00WebPart.ts' severity: 'Error' message: 'Argument of type '{ label: string; context: WebPartContext; onPropertyChange: any; properties: INoFramework00WebPar...' is not assignable to parameter of type 'IPropertyFieldListPickerProps'. Types of property 'context' are incompatible. Type 'WebPartContext' is not assignable to type 'IWebPartContext'. Types of property 'httpClient' are incompatible. Type 'HttpClient' is not assignable to type 'HttpClient'. Two different types with this name exist, but they are unrelated. Types have separate declarations of a private property '_httpClientBase'.' at: '59,55' source: 'ts'

This is in a newly created No Framework project.
Using the latest Generator.
I get the same error in a React based project.

Steps to Reproduce

Install the packages.
Add the imports, etc.
Add the PropertyField sample code to the existing groupFields collection.

Thanks!

Term selected via the suggestions does not select it in the tree view

Category

[ ] Enhancement
[x] Bug
[ ] Question

Version

Please specify what version of the library you are using: [v1.5.0@next]

Observed Behavior

When choosing a term from the suggestions, it will not get automatically selected in the tree view.

Steps to Reproduce

Type in the term input box, open the tree view, the term is not selected.

German localization

Category

[x] Enhancement
[ ] Bug
[ ] Question

Add German localization labels

PropertyFieldPeoplePicker validation error does not clear as expected.

Category

  • Enhancement
  • Bug
  • Question

Version

[1.6.0]

Expected / Desired Behavior / Question

Added validation function to onGetErrorMessage property of a PropertyFieldPeoplePicker field. Failed validation on purpose to display error message. Then updated to a valid value and expected the error message to clear.

Observed Behavior

Error message is still displayed after a valid value is selected.

PropertyFieldTermPicker: Term is selected even if Cancel is clicked in the Terms Tree Pane

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.5.0 ]

Expected / Desired Behavior / Question

The Term is not selected in the picker if it is checked in the tree and then Cancel is clicked

Observed Behavior

The Term is selected even if Cancel is clicked

Steps to Reproduce

  1. Open test web part
  2. Open Property Pane
  3. in TermPicker click on the icon to display Taxonomy tree
  4. Select (check) Belgium
  5. Click Cancel
  6. OBSERVED: Belgium is selected in the picker

PropertyFieldColorPicker Palette Icon alignment issue in IE11

Category

  • Bug

Version

1.5.1 and above including beta

Expected

Fix the alignment issue as you see below or open the color palette as a callout
chrome

Observed Behavior

In IE11 the PropertyFieldColorPicker Palette Icon seems to hide when active which creates mild confusion on closing.
ie 11

Steps to Reproduce

  1. Create a SPFx webpart
  2. Install sp-dev-fx-property-controls package as mentioned in https://sharepoint.github.io/sp-dev-fx-property-controls/
  3. Add PropertyFieldColorPicker property
  4. Execute the app using gulp serve
  5. Open the local workbench page in IE11 and add the app
  6. Edit the PropertyFieldColorPicker property
  7. Notice the icon alignment issue

Thanks!

1.6.0 Release Date

Category

  • Question

Version

1.6.0

Hi Team,
Any idea about the expected release date for 1.6.0?

Thanks!

PropertyFieldListPicker add optional property for target site

Category

[ X] Enhancement

[ ] Bug

[ ] Question

Expected / Desired Behavior / Question

Add an optional property to allow the target site url to be configured so that the component can load lists from a different site (it is a common development scenario to have components that read data from the root site for example)

Observed Behavior

Control default to loading lists from the current site.

Happy to help if the suggestion gets approved.
Thanks,
Joel

PropertyFieldListPicker

Category

[x ] Enhancement

[ ] Bug

[ ] Question

PropertyFieldListPicker should have a select all/deselect all to let the user deselect/select all lists,

Validation for PropertyFieldCollectionData

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [ 1.6.0 ]

Expected / Desired Behavior / Question
I want to perform some validations on Collection Data, for this i require callback option for validation of Collection Data. Either of onGetErrorMessage or onPropertyChange would help. These properties are available in some of the controls such as listPickers fieldPicker etc..

Would appreciate any help on how to get these properties for PropertyFieldCollectionData as well.

Thanks!

PropertyFieldCollectionData causes gulp serve to throw error

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [ 1.6.0 ]

Expected / Desired Behavior / Question

Project using PropertyFieldCollectionData should run without error when running gulp serve.

Observed Behavior

Project throws an error when running gulp serve after adding the code from the tutorial here: https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyFieldCollectionData/.

The error is very long, but here's the top of it with some stack trace info:

Error - [webpack] 'dist':
./node_modules/@pnp/spfx-property-controls/lib/propertyFields/collectionData/PropertyFieldCollectionDataHost.js
Module not found: Error: Can't resolve 'PropertyControlStrings' in 'D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\collectionData'
resolve 'PropertyControlStrings' in 'D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\collectionData'
  Parsed request is a module
  using description file: D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\package.json (relative path: ./lib/propertyFields/collectionData)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file: D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\package.json (relative path: ./lib/propertyFields/collectionData)
    resolve as module
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\collectionData\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\collectionData\lib doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\propertyFields\lib doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\lib\lib doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\spfx-property-controls\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\@pnp\lib doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\node_modules doesn't exist or is not a directory
      D:\Development\test-spfx-debug\node_modules\lib doesn't exist or is not a directory
      D:\Development\node_modules doesn't exist or is not a directory
      D:\Development\lib doesn't exist or is not a directory
      D:\node_modules doesn't exist or is not a directory
      D:\lib doesn't exist or is not a directory

Steps to Reproduce

  1. Create a new SPFx web part project with the yeoman generator
  2. npm install spfx-property-controls
  3. Add the code from the tutorial mentioned above
  4. Run gulp serve

New Control: Rich text editor for React

Rich text is essential in every application. I haven't seen Rich Text Editor control in Office-UI-Fabric-React which can be used in SFPx Web Parts. This control will be great addition to reusable control list.

Thanks in advance.

PropertyFieldNumber control suggestion

Category

[ x ] Enhancement

[ ] Bug

[ x ] Question

Version

Please specify what version of the library you are using: [ 1.4.1 ]

Expected / Desired Behavior / Question

It would be great if I could configure a property as a Function. This function can be used to validate the number in the field. This would allow me to have more control over the input number. A quick example for only allowing evens:

PropertyFieldNumber('EvenNumber', {
    key: 'EvenNumber',
    evalutationError: 'Only even numbers please!',
    evaluation: function(value) { return value % 2 == 0; }
})

If the evaluation function fails it could display the custom message which could default to "The custom evaluation failed.".

Taxonomy picker for enterprise

Category

  • [x ] Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [1.6.0]

Expected / Desired Behavior / Question

When opening the term picker list, today the complete tree is expanded.
This does not work for comprehensive trees of taxonomy. We intend to use it for our organisation tree with about 3700 nodes in the tree. This loads extremely slow and picking the right term is a nightmare with a huge vertical scrollbar and bad performing scrolling (especially in IE).
Enhancement would be:

  • Having the option to expand and collapse the nodes (not leaf nodes) in the taxonomy tree (just as in good old SharePoint ;). The tree should be collapsed as default and only the immediate children of the root should be visible.
  • Asynchronous load of subtrees. The subtrees should not be loaded until the user actually expand the node to avoid pre-loading of extreme trees. The best would be that the level shown is loaded +1 to maximize usability (e.g. load is always one level "ahead" of user).

Use case: We have our (quite comprehensive) organisation tree synchronized as a termset (manually as the flat list provided by SharePoint in predefined termset "Department" is useless when it is flat). The user profiles have a custom property filled with the term corresponding to their organisational belonging. On pages we have developed (looking forward to the announced "Page details") a property pane where we use this control to pick an organisation unit, the page belongs to. The we use that property to:

  • Roll-up content (based on search) from specific organisation (sub)trees
  • Roll-up targeted content to user based on their profile data

Steps to Reproduce

Create a huge termset and use it in this control, then you will quickly see the bad usability of working with the control.

[PropertyFieldOrder] Appending to an array doesn't reflect in order

Category

  • Enhancement
  • Bug
  • Question
    Pretty sure this is a bug because I'd expect changing the property would affect this field

Version: [1.8.0]

Expected / Desired Behavior

I expected to be able to sort an array that drew it's contents from the PropertyFieldMultiSelect field.

Observed Behavior

Once I choose an option with the PropertyFieldMultiSelect it doesn't show up in the PropertyFieldOrder until I refresh my browser window. (all of this is on a hosted SP workbench.

Steps to Reproduce

  1. Add both of these field controls and connect them to the same property.
  2. Try selecting items from the MultiSelect and see if the OrderField updates

quick sidenote:
My actual flow is actually slightly more complicated as I am dynamically loading up the MultiSelect options with the @pnp/sp library.

Thanks!

You should put out demos for these

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

  • Enhancement
  • Bug
  • Question

It would help with the testing...

PropertyFieldColorPicker unable to set alpha value

Category

[ ] Bug

[ ] Question

Unable to set the alpha color property value in the PropertyFieldColorPicker control. Because of this when the focus is out of the property pane, the value goes back to RGB only instead of RGBA.

The color control should work as shown in the below example to get the RGBA values
https://casesandberg.github.io/react-color/
Note: Happens only when style: PropertyFieldColorPickerStyle.Full

Sortable multi-field picker

Category

[x ] Enhancement

[ ] Bug

[ ] Question

I am trying to achieve a webpart which displays information about the current website in a kind of bulletin list or profile style e.g. Projectname, Projectnumber, Budget, Project Responsible... which are stored in a list in the current site.
For this it would be awesome to have a controll that allows to select and order fields from a list.

Ideally, you could move the fields (up, down) into the order you would want them to be used in the webpart and the attached property would return a sorted list of fields.

I guess you could also use this to specify the order of fields in a list view.

PropertyControlStrings can't be resolved for PropertyFieldDateTimePicker control.

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ Beta.1 ]

Expected / Desired Behavior / Question

Solution should build and run in the workbench.

Observed Behavior

Get multiple errors during build. Errors are that PropertyControlStrings can't be resolved.
I think this is used in multiple files in the package.
Example:
./node_modules/@pnp/spfx-property-controls/lib/propertyFields/dateTimePicker/PropertyFieldDateTimePickerHost.js Module not found: Error: Can't resolve 'PropertyControlStrings' in '/mnt/c/Dev/sp/lrn/spfx/react00/node_modules/@pnp/spfx-property-controls/lib/propertyFields/dateTimePicker

Steps to Reproduce

Install packages
Add Property Pane field
gulp serve

Thanks!

PropertyFieldCheckboxWithCallout: 'checked' property is undefined

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Version: [ 1.3.0 ]

Issue Description

Configured the PropertyFieldCheckboxWithCallout in a webpart. When i checked or unchecked the checkbox the value is not getting stored in the properties. When i tried to display the property value it is giving me as 'undefined'

Thanks!

MultiSelect acts like a simple Dropdown

Category

[ ] Enhancement

[x] Bug

[x] Question

Version

Hi,
I'm trying to use the latest version of the MultiSelect control in my SP2016 onpremise environment. If I try to include the very basic example into my project it only shows up a DropdownControl. Is this control generally capable to work in an onpremise environment? And if so, how? ;-)

grafik

The code I used:

PropertyFieldMultiSelect('multiSelect', { key: 'multiSelect', label: "Multi select field", options: [ { key: "EN", text: "EN" }, { key: "FR", text: "FR" }, { key: "NL", text: "NL" } ], selectedKeys: this.properties.multiSelect })

And of course with the correct properties:

multiSelect: string[];

Other Controls like the DateTimePicker are working fine...

Single selection not working in the enhanced term picker

Category

[ ] Enhancement
[x] Bug
[ ] Question

Version

Please specify what version of the library you are using: [v1.5.0@next]

Expected / Desired Behavior / Question

When single selection in termpicker is turned on, it only seems to work in the tree view, not in the input field.

PropertyFieldPeoplePicker Validation does not work as expected.

Category

[ ] Enhancement

[X] Bug

[ ] Question

Expected / Desired Behavior / Question

Added validation function to onGetErrorMessage property of a PropertyFieldPeoplePicker field. Wrote the validation function to fail on purpose and expected to see error message in property pane under the people picker field.

Observed Behavior

No error message was displayed.

Notes:

  1. Specifically, it looks like there is an issue on line 162 of PropertyFieldPeoplePickerHost.tsx where the error message logic is only run if the result is 'undefined'.
  2. I updated that line locally to see what the error message would look like and observed that the css was not rendering as expected. The people picker did not have a red outline and the error message was not displayed in red text.

Control for adding collection data / list dynamically

Category

  • Enhancement
  • Bug
  • Question

New control

Add a new control which allows to added collection data as web part properties. By providing such a control, the user could dynamically add logic to its control based on the inserted information. Like for example if you want to show the weather of multiple locations. With this type of control, you could specify the fields + their types in web part, the control renders the list plus corresponding inputs and the user can add the required information while configuring the web part on the page.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.