pmqs / archive-zip-simplezip Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 4.0 241 KB

Perl5 interface to read/write Zip files

Perl 100.00%

archiver bzip2 deflate inflate lzma perl perl-module perl5 perl5-module streaming unzip zip zip64 zlib

archive-zip-simplezip's People

Contributors

Stargazers

Watchers

Forkers

mstock vrag86 manwar clayne

archive-zip-simplezip's Issues

t/010main-unzip.t fails

On some smoker systems t/010main-unzip.t fails. Sample reports may be seen here: http://matrix.cpantesters.org/?dist=Archive-Zip-SimpleZip%200.029

A pattern is not visible for me. From my smokers I see some test failures on centos7, fedora28, freebsd12, but there are also passes on these systems with different perl versions. It passes on all of my debian and ubuntu systems, but it fails on Andreas' debian/sid smoker: http://www.cpantesters.org/cpan/report/85f214ce-025c-11ea-a69d-87f2a4f3b5ea

In some reports the following is logged:

# Uncompression Error: Memory usage limit was reached

Indeed, my smoker run with a memory limit of 1 GB (which should be plenty in most situations). But even if I remove the limit, the test is failing.

A strace log is also not helpful.

Error when i try extract file to full path

Error "Cannot create path 'home': File exists"
$member->extract('/home/dev023/app/d/m/d/e/zdev023/st/sh.pl');
Why you try make this dir w/o checking for exist?
Please, fix it

Maybe use File::Path::mkpath is better?
Or check directory existence (-e $dir and -d $dir) before try create it?

Broken cpan release

This module is currently missing on cpan: https://metacpan.org/pod/Archive::Zip::SimpleZip

The latest commit which fixes the broken build 0321ab0 seems to be missing in the version on cpan, so t/000prereq.t fails and it wont install for me on either Mac or Linux perl 5.30.

111const-deflate.t running more tests than expected

It looks like after this change upstream pmqs/IO-Compress@6e877cc

111const-deflate.t test is now failing, as more constants now exist, so an extra 4 tests are running and throwing out the amount of expected tests to run.

Output when attempting to install

# perl                      5.030003
# Archive::Zip::SimpleZip   0.035
# Archive::Zip::SimpleUnzip 0.035
# IO::Compress::Base        2.096
# IO::Compress::Zip         2.096
# IO::Compress::Lzma        Not Installed
# IO::Uncompress::Base      2.096
# IO::Uncompress::Unzip     2.096
# IO::Uncompress::UnLzma    Not Installed
# Compress::Raw::Zlib       2.096
# Compress::Raw::Bzip2      2.096
# Compress::Raw::Lzma       Not Installed
# zlib                      1.2.11
# bzip2                     1.0.8, 13-Jul-2019

# Looks like you planned 83 tests but ran 4 extra

AutoFlush broken

Can't locate object method "_autoflush" via package "IO::Compress::Zip" at C:/Strawberry/perl/site/lib/Archive/Zip/SimpleZip.pm line 249.

Test failures in t/000prereq.t - IO::Compress::Bzip2 version is 2.102, need 2.096

Hello,

I got these test failures while trying to install Archive::Zip::SimpleZip

Are you deliberately expecting exact versions of those dependencies?

Thanks!

t/000prereq.t ............. 1/14
#     Failed test (t/000prereq.t at line 62)
#          got: '2.102'
#     expected: '2.096'
# IO::Compress::Bzip2 version is 2.102, need 2.096

#     Failed test (t/000prereq.t at line 62)
#          got: '2.102'
#     expected: '2.096'
# IO::Uncompress::Bunzip2 version is 2.102, need 2.096
#
#
# perl                      5.030003
# Archive::Zip::SimpleZip   0.039
# Archive::Zip::SimpleUnzip 0.039
# IO::Compress::Base        2.102
# IO::Compress::Zip         2.102
# IO::Compress::Bzip2       2.102
# IO::Compress::Lzma        Not Installed
# IO::Compress::Xz          Not Installed
# IO::Compress::Zstd        Not Installed
# IO::Uncompress::Base      2.102
# IO::Uncompress::Unzip     2.102
# IO::Uncompress::Bunzip2   2.102
# IO::Uncompress::UnLzma    Not Installed
# IO::Uncompress::UnXz      Not Installed
# IO::Uncompress::UnZstd    Not Installed
# Compress::Raw::Zlib       2.101
# Compress::Raw::Bzip2      2.101
# Compress::Raw::Lzma       Not Installed
# Compress::Stream::Zstd    Not Installed
# zlib                      1.2.11
# bzip2                     1.0.8, 13-Jul-2019
#
#
# Looks like you failed 2 tests of 14.
t/000prereq.t ............. Dubious, test returned 2 (wstat 512, 0x200)

Version mismatches in t/000prereq.t

t/000prereq.t fails on some of my smokers like this:

#     Failed test (t/000prereq.t at line 54)
#          got: '2.092'
#     expected: '2.091'
# IO::Compress::Lzma version is 2.092, need 2.091

#     Failed test (t/000prereq.t at line 54)
#          got: '2.092'
#     expected: '2.091'
# IO::Uncompress::UnLzma version is 2.092, need 2.091
# 
# 
# perl                      5.026002
# Archive::Zip::SimpleZip   0.033
# Archive::Zip::SimpleUnzip 0.033
# IO::Compress::Base        2.092
# IO::Compress::Zip         2.092
# IO::Compress::Lzma        2.092
# IO::Uncompress::Base      2.092
# IO::Uncompress::Unzip     2.092
# IO::Uncompress::UnLzma    2.092
# Compress::Raw::Zlib       2.092
# Compress::Raw::Bzip2      2.092
# Compress::Raw::Lzma       2.092
# zlib                      1.2.11
# bzip2                     1.0.8, 13-Jul-2019
# lzma                      5.2.4
# 
# 
# Looks like you failed 2 tests of 6.
t/000prereq.t ............. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

Document and/or Police Zip-Slip vulnerability

https://github.com/snyk/zip-slip-vulnerability

uncompr error with content()

$data=$z->content("foo.txt"); gives error: Can't call method "uncompr" on an undefined value at /usr/share/perl5/IO/Uncompress/Base.pm line 917.

This happens on different machines with slightly different versions of used modules, eg IO::Compress 2.081 and 2.084 so it looks like the error is caused by simpleunzip.

Can't extract after read content

When i try extract file after read his content, file extracted is empty
I guess need to seek curent position of file, but Member hasn't this method.

Test failures when optional modules not present or wrong version

https://cpantesters.org/cpan/report/bacc1c1a-ad53-11ea-a83c-75d8f4ffae69

From: Alceu Rodrigues de Freitas Junior
Subject: FAIL Archive-Zip-SimpleZip-0.035 5.30.2 OpenBSD
Date: 2020-06-13T08:56:11Z

This distribution has been tested as part of the CPAN Testers
project, supporting the Perl programming language.  See
http://wiki.cpantesters.org/ for more information or email
questions to [email protected]


--
Dear Paul Marquess,

This is a computer-generated report for Archive-Zip-SimpleZip-0.035
on perl 5.30.2, created by CPAN-Reporter-1.2018.

Thank you for uploading your work to CPAN.  However, there was a problem
testing your distribution.

If you think this report is invalid, please consult the CPAN Testers Wiki
for suggestions on how to avoid getting FAIL reports for missing library
or binary dependencies, unsupported operating systems, and so on:

http://wiki.cpantesters.org/wiki/CPANAuthorNotes

Sections of this report:

    * Tester comments
    * Program output
    * Prerequisites
    * Environment and other context

------------------------------
TESTER COMMENTS
------------------------------

Additional comments from tester:

this report is from an automated smoke testing program
and was not reviewed by a human for accuracy

------------------------------
PROGRAM OUTPUT
------------------------------

Output from '/usr/bin/make test':

PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
# 
# 
# perl                      5.030002
# Archive::Zip::SimpleZip   0.035
# Archive::Zip::SimpleUnzip 0.035
# IO::Compress::Base        2.093
# IO::Compress::Zip         2.093
# IO::Compress::Lzma        2.093
# IO::Uncompress::Base      2.093
# IO::Uncompress::Unzip     2.093
# IO::Uncompress::UnLzma    2.093
# Compress::Raw::Zlib       2.093
# Compress::Raw::Bzip2      2.089
# Compress::Raw::Lzma       2.093
# zlib                      1.2.11
# bzip2                     1.0.8, 13-Jul-2019
# lzma                      5.2.5
# 
# 
t/000prereq.t ............. ok
t/001main.t ............... ok
IO::Compress::Zip: Bzip2 not available at lib/Archive/Zip/SimpleZip.pm line 247.
# Looks like you planned 10342 tests but only ran 2588.
# Looks like your test died just after 2588.
t/010main-unzip.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 7754/10342 subtests 
Label not found for "last SKIP" at t/Test/More.pm line 883.
# Looks like you planned 4164 tests but only ran 2755.
# Looks like your test died just after 2755.
t/020main-unzip-stream.t .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1409/4164 subtests 
	(less 1 skipped subtest: 2754 okay)
t/111const-deflate.t ...... ok
t/999pod.t ................ ok
t/meta-json.t ............. ok
t/meta-yaml.t ............. ok

Test Summary Report
-------------------
t/010main-unzip.t       (Wstat: 65280 Tests: 2588 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10342 tests but ran 2588.
t/020main-unzip-stream.t (Wstat: 65280 Tests: 2755 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 4164 tests but ran 2755.
Files=8, Tests=6273,  3 wallclock secs ( 0.30 usr  0.12 sys +  2.30 cusr  0.93 csys =  3.65 CPU)
Result: FAIL
Failed 2/8 test programs. 0/6273 subtests failed.
*** Error 255 in /mnt/cpan_build_dir/goku/Archive-Zip-SimpleZip-0.035-0 (Makefile:884 'test_dynamic')

------------------------------
PREREQUISITES
------------------------------

Prerequisite modules loaded:

requires:

    Module                 Need  Have   
    ---------------------- ----- -------
    IO::Compress::Base     2.093 2.093  
    IO::Compress::Lzma     2.093 2.093  
    IO::Uncompress::Base   2.093 2.093  
    Perl::OSType           0     1.010  

build_requires:

    Module                 Need  Have   
    ---------------------- ----- -------
    ExtUtils::MakeMaker    0     7.45_01

configure_requires:

    Module                 Need  Have   
    ---------------------- ----- -------
    ExtUtils::MakeMaker    0     7.45_01

opt_requires:

    Module                 Need  Have   
    ---------------------- ----- -------
    IO::Compress::Lzma     2.093 2.093  
    IO::Uncompress::UnLzma 2.093 2.093  


------------------------------
ENVIRONMENT AND OTHER CONTEXT
------------------------------

Environment variables:

    AUTOMATED_TESTING = 1
    DBD_MYSQL_TESTDB = test
    DBD_MYSQL_TESTHOST = localhost
    DBD_MYSQL_TESTPASSWORD = 
    DBD_MYSQL_TESTPORT = 3306
    DBD_MYSQL_TESTUSER = goku
    EXTENDED_TESTING = 1
    PATH = /home/goku/perl5/perlbrew/bin:/home/goku/perl5/bin:/home/goku/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin
    PERL5LIB = /home/goku/perl5/lib/perl5
    PERL5OPT = 
    PERL5_CPANPLUS_IS_RUNNING = 5206
    PERL5_CPAN_IS_RUNNING = 5206
    PERL5_CPAN_IS_RUNNING_IN_RECURSION = 58182,5206
    PERLBREW_HOME = /home/goku/.perlbrew
    PERLBREW_PATH = /home/goku/perl5/perlbrew/bin
    PERLBREW_ROOT = /home/goku/perl5/perlbrew
    PERLBREW_SHELLRC_VERSION = 0.88
    PERLBREW_VERSION = 0.88
    PERL_CR_SMOKER_CURRENT = Archive-Zip-SimpleZip-0.035
    PERL_EXTUTILS_AUTOINSTALL = --defaultdeps
    PERL_LOCAL_LIB_ROOT = /home/goku/perl5
    PERL_MB_OPT = --install_base "/home/goku/perl5"
    PERL_MM_OPT = INSTALL_BASE=/home/goku/perl5
    PERL_MM_USE_DEFAULT = 1
    PERL_USE_UNSAFE_INC = 1
    SHELL = /usr/local/bin/bash
    TERM = xterm-256color

Perl special variables (and OS-specific diagnostics, for MSWin32):

    $^X = /usr/bin/perl
    $UID/$EUID = 1001 / 1001
    $GID = 999 999 1001
    $EGID = 999 999 1001

Perl module toolchain versions installed:

    Module              Have    
    ------------------- --------
    CPAN                2.28    
    CPAN::Meta          2.150010
    Cwd                 3.78    
    ExtUtils::CBuilder  0.280234
    ExtUtils::Command   7.45_01 
    ExtUtils::Install   2.14    
    ExtUtils::MakeMaker 7.45_01 
    ExtUtils::Manifest  1.72    
    ExtUtils::ParseXS   3.40    
    File::Spec          3.78    
    JSON                4.02    
    JSON::PP            4.04    
    Module::Build       0.4231  
    Module::Signature   0.83    
    Parse::CPAN::Meta   2.150010
    Test::Harness       3.43_02 
    Test::More          1.302175
    YAML                1.30    
    YAML::Syck          n/a     
    version             0.9924  


--

Summary of my perl5 (revision 5 version 30 subversion 2) configuration:
   
  Platform:
    osname=openbsd
    osvers=6.7
    archname=amd64-openbsd
    uname='openbsd'
    config_args='-dsE -Dopenbsd_distribution=defined -Dccflags=-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -Dmksymlinks'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -fstack-protector-strong -D_FORTIFY_SOURCE=2 -I/usr/local/include'
    optimize='-O2'
    cppflags='-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='4.2.1 Compatible OpenBSD Clang 8.0.1 (tags/RELEASE_801/final)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags ='-Wl,-E  -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/lib /usr/lib
    libs=-lm -lc
    perllibs=-lm -lc
    libc=/usr/lib/libc.a
    so=so
    useshrplib=true
    libperl=libperl.so.20.0
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-R/usr/libdata/perl5/amd64-openbsd/CORE'
    cccdlflags='-DPIC -fPIC '
    lddlflags='-shared -fPIC  -fstack-protector-strong -L/usr/local/lib'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_TIMES
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_CTYPE
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
  Built under openbsd
  %ENV:
    PERL5LIB="/home/goku/perl5/lib/perl5"
    PERL5OPT=""
    PERL5_CPANPLUS_IS_RUNNING="5206"
    PERL5_CPAN_IS_RUNNING="5206"
    PERL5_CPAN_IS_RUNNING_IN_RECURSION="58182,5206"
    PERLBREW_HOME="/home/goku/.perlbrew"
    PERLBREW_PATH="/home/goku/perl5/perlbrew/bin"
    PERLBREW_ROOT="/home/goku/perl5/perlbrew"
    PERLBREW_SHELLRC_VERSION="0.88"
    PERLBREW_VERSION="0.88"
    PERL_CR_SMOKER_CURRENT="Archive-Zip-SimpleZip-0.035"
    PERL_EXTUTILS_AUTOINSTALL="--defaultdeps"
    PERL_LOCAL_LIB_ROOT="/home/goku/perl5"
    PERL_MB_OPT="--install_base "/home/goku/perl5""
    PERL_MM_OPT="INSTALL_BASE=/home/goku/perl5"
    PERL_MM_USE_DEFAULT="1"
    PERL_USE_UNSAFE_INC="1"
  @INC:
    /home/goku/perl5/lib/perl5/5.30.2/amd64-openbsd
    /home/goku/perl5/lib/perl5/5.30.2
    /home/goku/perl5/lib/perl5/amd64-openbsd
    /home/goku/perl5/lib/perl5
    /usr/local/libdata/perl5/site_perl/amd64-openbsd
    /usr/local/libdata/perl5/site_perl
    /usr/libdata/perl5/amd64-openbsd
    /usr/libdata/perl5

Broken: missing lzma.h

Can not install from CPAN because of missing lzma.h during compilation.
Version 0.039.

Add IO::Compress::Lzma to PREREQ_PM

See Perl-Toolchain-Gang/ExtUtils-MakeMaker#345

SimpleZip does not work with all eligible IO::Compress::Zip parameters

The package uses its own %PARAMS, and throws exception when parameter is not listed where. But Efs param, for example, does not listed.
This can be avoided in calling program by something like $Archive::Zip::SimpleZip::PARAMS{efs} = [IO::Compress::Base::Common::Parse_boolean, 0];, but this solution smells.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.