pmndrs / use-asset Goto Github PK

I use the dark theme and the black titles are not that distinguishable from the background.

To enable dark theme go to Settings > Appearance > select Dark

Some frameworks like Next performs data prefetching in the server-side, providing the initial data for the whole app. Libraries like swr and react-query takes advantage of this by using the prefetched data as the initial cache data and performs the fetch process/cache invalidation only on client-side.

Asset hydration helps because React SSR cannot handle nor does not support Suspense (CM, however, supports this) and since the asset is guaranteed to have an initial data, the component does not have to suspend during SSR and the potentially suspending component can safely present its success UI.

I think something like asset.hydrate(args, data) or useAsset(asset, args, initialData) is a good API. Thoughts?

Does it need to have react-three-fiber and three as peer dependencies at all? It seems pretty generic, but perhaps I'm missing something.

I'm looking into using react-three-fiber and use-asset for one of my projects, and I've noticed that the infinite load example doesn't work on my display. Looking into the code, this condition for triggering fetching may never be true for larger screens:

e.target.scrollTop > content.current.scrollHeight - 1000

It's a very minor thing, but I was wondering if it makes sense to increase this threshold and make it independent of the screen size, e.g. something like:

e.target.scrollTop > content.current.scrollHeight / 2

And thanks very much for all the awesome work on the poimandres familiy of libraries! I really appreciate how you use the most interesting features of React to make sure that all the different use cases stay performant and simple to use. 👍

So that Typescript knows what type of variable is returned from e.g. asset.read() and you don't have to do something like this when consuming the asset:

const stuff = asset.read( name, ...args ) as StuffType // `as StuffType` should ideally not be necessary

Is there reload api for refresh the asset?