pmant / node-botvac Goto Github PK

Hello @Pmant!
Let me introduce myself, I am Roberto Ostinelli, Neato Robotics' Director of Cloud Services.

I'm impressed with the work that you've put into integrating with our robots! Great job!

Given the interest that we've seen from developers like yourself and around the forums we've listened and have just released the Neato Developer Network. In there, amongst other things you will find official documentation and SDKs for JavaScript, iOS and Android (for now, we plan on expanding to other languages too!).

This issue is for you to consider switching to proper OAuth instead of the internal logins mechanisms that you are using in this gem. BTW these mechanisms and other things have already been integrated in the official Neato JavaScript SDK, so maybe all this needs is a port to node?

It would be the official way to proceed, and you would avoid some improper implementations. For example, you should not pass token and platform here: they are not needed, raise errors on our systems - since tokens are invalid - and this could eventually result in the blocking of user accounts by our automated systems if abused. We definitely wouldn't want that!

Please note that all of this is in Beta, we're a small team but are doing our best!

All the best,
r.

PS: I've opened the same issue on the gem that, to my knowledge, started it all. :)

Adding support for persistent maps and boundaries including getting the persistent maps, getting the boundaries, setting the boundaries, cleaning a (polygon type) boundary (zone) would be very beneficial to your module. This would allow for zone and spot cleaning support with plugins that use node-botvac.

Hi, the current version of node-botvac on npm is 0.4.0. It would be really cool if you release the current 0.4.1 with the axios 0.21.1 dependency on npm. I use your package as a dependency in homebridge-neato and users currently get a security warning because of the old axios dependency in 0.4.0.

Hey there,

I just noticed that when I use getRobots() on my robots it doesn't return the secret. So when I run robot.getState() I get the error message: "No serial or secret".

Any clues what might cause this? Or how to fix it?

This line

1. response success, callback gets called, errors occurs in callback
2. Line 33 catches the error and calls the callback again.

Would it be possible to extend the lib to control the robot via left,right,forward commands?