Giter Club home page Giter Club logo

pjsip-ios's People

Contributors

hiroeorz avatar pmairoldi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

pjsip-ios's Issues

Add Video Support and an Example

Hi Pierre, Would you have time to enable Video along with a demo sample to your library or would you rather we fork off and submit a pull request for the video to get added to your master?

Memory Leaks

Is PJSIP a light weight and memory efficient library? by memory efficient I mean no memory leaks etc.
Actually my application is having 170 MB while running on Xcode plus M facing memory-leaks in instrument tool too.

Podspec improvements

Following up from the Twitter discussion, I'd recommend moving away from LIBRARY_SEARCH_PATHS and HEADER_SEARCH_PATHS. For libraries, use vendored_libraries.

-  s.libraries = 'g7221codec-arm-apple-darwin9', 'gsmcodec-arm-apple-darwin9', 'ilbccodec-arm-apple-darwin9', 'pj-arm-apple-darwin9', 'pjlib-util-arm-apple-d
+  s.vendored_libraries = 'Pod/pjsip-lib/*.a'


   s.xcconfig = {
     'GCC_PREPROCESSOR_DEFINITIONS' => 'PJ_AUTOCONF=1',
-    'HEADER_SEARCH_PATHS'  => '$(PODS_ROOT)/pjsip-ios/Pod/pjsip-include',
-    'LIBRARY_SEARCH_PATHS' => '$(PODS_ROOT)/pjsip-ios/Pod/pjsip-lib'
   }

You are using public_header_files which unfortunately flattens the hierarchy of the headers. Taking a peak into them, there is a structure built up of multiple components:

  • #include <pj/activesock.h>
  • #include <pj++/file.hpp>
  • #include <pjmedia/alaw_ulaw.h>
  • #include <pjnath/config.h>
  • #include <pjsip/sip_types.h>
  • etc

It looks like you've found a workaround for this by using HEADER_SEARCH_PATHS and preserve_paths. You could move towards using subspecs to expose the headers in the correct directories, which can be done with something like the following:

Pod::Spec.new do |s|
  s.subspec 'Codec' do |codec_subspec|
    codec_subspec.header_dir = 'pjmedia-codec'
    codec_subspec.public_header_files = # should contain the pjmedia-codec headers
  end

  s.subspec 'Audiodev' do |audio_dev_spec|
    audio_dev_spec.header_dir = 'pjmedia-audiodev'
    audio_dev_spec.public_header_files = # should contain audiodev{,_imp}.h, audiotest.h, etc
    audio_dev_spec.vendored_libraries. = 'Pod/pjsip-lib/libpjmedia-arm-apple-darwin9.a' # the libraries for this component
  end

Update to pjproject-2.4.5

Can you please help me update project to 2.4.5? 2.3 and 2.4 builds good, but 2.4.5 fails.
Here is my config_site.h (I need sip-tls)
And armv7.log

and console log:

./build.sh 
Downloading pjsip...
######################################################################## 100.0%
Using pjproject-2.4.5...
Unarchiving...
Creating config.h...
Building for armv7...
cp: pjlib/lib/libpj-arm-apple-darwin9.a: No such file or directory
cp: pjlib-util/lib/libpjlib-util-arm-apple-darwin9.a: No such file or directory
cp: pjmedia/lib/libpjmedia-arm-apple-darwin9.a: No such file or directory
cp: pjmedia/lib/libpjmedia-audiodev-arm-apple-darwin9.a: No such file or directory
cp: pjmedia/lib/libpjmedia-codec-arm-apple-darwin9.a: No such file or directory
cp: pjmedia/lib/libpjmedia-videodev-arm-apple-darwin9.a: No such file or directory
cp: pjmedia/lib/libpjsdp-arm-apple-darwin9.a: No such file or directory
cp: pjnath/lib/libpjnath-arm-apple-darwin9.a: No such file or directory
cp: pjsip/lib/libpjsip-arm-apple-darwin9.a: No such file or directory
cp: pjsip/lib/libpjsip-simple-arm-apple-darwin9.a: No such file or directory
cp: pjsip/lib/libpjsip-ua-arm-apple-darwin9.a: No such file or directory
cp: pjsip/lib/libpjsua-arm-apple-darwin9.a: No such file or directory
cp: pjsip/lib/libpjsua2-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libg7221codec-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libgsmcodec-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libilbccodec-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libresample-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libspeex-arm-apple-darwin9.a: No such file or directory
cp: third_party/lib/libsrtp-arm-apple-darwin9.a: No such file or directory
Making universal lib...
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjlib/lib-i386/libpj-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjlib-util/lib-i386/libpjlib-util-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjmedia/lib-i386/libpjmedia-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjmedia/lib-i386/libpjmedia-audiodev-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjmedia/lib-i386/libpjmedia-codec-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjmedia/lib-i386/libpjmedia-videodev-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjmedia/lib-i386/libpjsdp-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjnath/lib-i386/libpjnath-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjsip/lib-i386/libpjsip-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjsip/lib-i386/libpjsip-simple-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjsip/lib-i386/libpjsip-ua-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjsip/lib-i386/libpjsua-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: pjsip/lib-i386/libpjsua2-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libg7221codec-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libgsmcodec-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libilbccodec-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libresample-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libspeex-arm-apple-darwin9.a (No such file or directory)
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't open input file: third_party/lib-i386/libsrtp-arm-apple-darwin9.a (No such file or directory)
cp: lib/*: No such file or directory
Done

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.