plouc / go-gitlab-client Goto Github PK

Hi

I would like to use this library, could you add a license?

I'd choose MIT: http://choosealicense.com/licenses/mit/

https://github.com/plouc/go-gitlab-client/blob/master/projects.go#L74

It says project path (namespace + project name) has to be passed with delimiter escaped (/ => %2F), but we can do that automatically with QueryEscape from net/url.

Can make a PR.

First off, this project has been a life saver! I started writing something similar for my small project but that started getting too big. I ran into a bit of an issue try to get commit refs

According to the docs the response from GET /projects/:id/repository/commits/:sha/refs looks like this:

[
  {"type": "branch", "name": "'test'"},
  {"type": "branch", "name": "add-balsamiq-file"},
  {"type": "branch", "name": "wip"},
  {"type": "tag", "name": "v1.1.0"}
]

Which is not the same as CommitRef{} :

type CommitRef struct {
	Id   string `json:"id" yaml:"id"`
	Sha  string `json:"sha" yaml:"sha"`
	Type string `json:"type" yaml:"type"`
}

I'd be happy to make a pull request with an accurate struct. Thanks! :)

It seems Gitlab emits an event with the project_id as an int64, but the AddProjectWebhook takes an id of type string https://github.com/plouc/go-gitlab-client/blob/master/hooks.go#L91

Any particular reason why it was done this way or can I go ahead and do a PR with the fix?

Could you add a function to fetch information on a specific issue?

Also interested in pull requests :)

Thanks!

I want the commit under the branch of this project, but this method does not have a second argument

What am I supposed to do ?

We need to support the pagination http://doc.gitlab.com/ee/api/#pagination as for now any list will be truncated which make the API useless as is.