@bloodbare Or ist this something that will be solved in plone.app.multilingual?

Once all settings have been moved to plone.app.registry, we should be able to remove portal_properties.

The PLIP was originally intended to be merged into the 4.x branch. Therefore we came up with the idea to sync the old (portal property based) settings with the new (p.a.registry based) settings to keep backwards compatibility. The old sync code needs to be removed now.

With Plone 5 the plan is now to get rid of the portal properties, write an upgrade step for old profiles and amend the code in coredev that uses the old properties.

Unless things have changed and I just never noticed, undo works like 1 out of every NEVER times. Let's just remove this until the implementation is more solid. Remove these and any references to them.

• Products/CMFPlone/skins/plone_scripts/undo.py
• Products/CMFPlone/UndoTool.py
• Products/CMFPlone/skins/plone_forms/undo_form.pt
• Products/CMFPlone/skins/plone_images/undo_icon.png
• Products/CMFPlone/skins/plone_forms/undo_form.pt.metadata
• Products/CMFPlone/skins/plone_images/undo_icon.png.metadata
• Products/CMFPlone/skins/plone_deprecated/undo_icon.gif
• Products/CMFPlone/skins/plone_deprecated/undo_icon.gif.metadata

Move to z3c.form and browser views.

This also references something called "portal_feedback". I don't know what or where that is. I can't find it in this product so maybe find out first where that actually lives and consolidate to one package.

Can we rename these while we are at it? Its more like author_feedback, not portal_feedback.

Then update author views mentioned in #78 to point to the correct new views.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/send_feedback.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/send_feedback.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_feedback.vpy
• portal_feedback?

Convert to z3c.form. This affects the following files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/ownership_form.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/change_ownership.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/change_ownership.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/ownership_form.cpt.metadata

Make sure the new browser views get the appropriate security settings.

https://github.com/plone/Products.ATContentTypes

This would be the following views and their metadata files: https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_content:

• document_view.pt
• event_view.pt
• file_view.pt (don't forget the weird redirect cases)
• image_view.pt
• image_view_fullscreen.pt
• link_redirect_view.py (again, weird case so be careful)
• link_view.pt
• newsitem_view.pt

In addition, let's make sure that the plone.app.contenttypes version of these views is implemented first and then migrate:

• folder_full_view.pt
• folder_full_view_item.pt
• folder_summary_view.pt
• folder_tabular_view.pt

I think that these migrate as well and that there is another plip which is basically redoing these listings but it needs to be confirmed:

• folder_listing.pt

I think this also means that having ATContentTypes will require also having CMF plone unless these get migrated to views as they move over. I encourage they do but realize this is a lot of work, and maybe its just easier requiring CMF. Also for customization reasons - people in the past did a lot TTW with this. It's up to whomever closes this to be the arbitrator of how nice they want to be.

In addition, we need to migrate the edits and what not that go with them. This includes the following in https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_form_scripts:

• document_edit.cpy
• document_edit.cpy.metadata
• event_edit.cpy
• event_edit.cpy.metadata
• file_edit.cpy
• file_edit.cpy.metadata
• image_edit.cpy
• image_edit.cpy.metadata Plone
• link_edit.cpy
• link_edit.cpy.metadata
• newsitem_edit.cpy
• newsitem_edit.cpy.metadata
• validate_event_edit.vpy
• validate_file_edit.vpy
• validate_image_edit.vpy
• validate_link_edit.vpy
• validate_newsitem_edit.vpy

We also have to decide if we still want to support formlib-based control panel at all in Plone 5.

RE: https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_title.vpy

This is a tricky one. I've done grepping in the past and seen this guy littered throughout the code. That was about a year ago but it could still be around. At the moment the task is to find out who is referencing this and why so we can make a better decision about it. If its coming completely from cpy's, which might be the case, please update all the tickets for those components and then point them to greener pastures.

To be honest, I have no idea what this feature is. So, if you know what it is, can you please move it to browser views? Based on the name and the code, I think it should go to p.a.content.

Also heed this note:

  "NOTE: This form is used in two different ways - from folder_contents,
  allowing you to publish several things at once, and from the state
  drop-down. In the first case, the 'paths' request parameter is set;
  in the second case, giving the relative paths to the content object
  to manipulate; in the second case, this parameter is omitted and the
  path of the context is used."

In migrating, I would make 2 separate views and do the simple case first.

Files:

• Products/CMFPlone/skins/plone_forms/content_status_history.cpt
• Products/CMFPlone/skins/plone_form_scripts/content_status_modify.cpy
• Products/CMFPlone/skins/plone_forms/content_status_history.cpt.metadata
• Products/CMFPlone/skins/plone_form_scripts/content_status_modify.cpy.metadata
• Products/CMFPlone/skins/plone_form_scripts/validate_content_status_modify.vpy

Migrate to a browser view inplone.app.content then delete in cmfplone. Make sure the templates that reference this script/page are updated (just grep to find it).

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/saveDefaultPage.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/saveDefaultPage.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/select_default_page.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/select_default_page.cpt.metadata

The functionality is deprecated.

Move into plone.app.content. Make sure to update the views that reference it (grep around).

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/selectViewTemplate.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/selectViewTemplate.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/select_default_view.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/select_default_view.cpt.metadata

The portal_password_reset tool can be removed once we removed skins and replaced the pw-reset functionality in plone.app.users.

https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_ecmascript

Look around to make sure these aren't being implicitly called anywhere. Some of these might actually be able to be deprecated long term but a straight translation will work for now.

RE: https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_images

Some if the things in plone_images need to go to sunburst, and some need to go to... I don't know. A lot of these are from back in the day when we didn't have sprints

When in doubt, just delete it. These icons all need modernizing and the css that does with them as well. There are ones of particular interest that we should be careful about, for example anything that kss or javascript needs to display interaction (content tree +/-, spinners, ...what else?).

I would actually be pretty happy to see someone update the entire default icon set to something modern, sprited, and all css overlaid but thats up to the expert themers in the community. Everything in this directory falls under "plone theme" EXCEPT, some tool icons (which we see in the ZMI).

Tool icons can stay until we have no more tools. If there is a way to get those to point to actual resources then all the better.

Don't forget to delete the directory registration when its empty.

There might be some widgets and tests that are missing.

Figure out when this is called and how to move it solely to plone.app.discussion. The former may be the harder part. It may actually just be deprecated.

https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_content/discussionitem_view.pt

At minimum, please migrate as is to a z3c.form and views. If you want to be fancy and extra super awesome, make this work behind an API and throw some love into that UI. That would be making member_search_results be a json response and the form just updating based on that. Implementers choice!

This stuff is O.L.D.

Files:

• Products/CMFPlone/tests/member_search.txt
• Products/CMFPlone/skins/plone_forms/member_search_form.pt
• Products/CMFPlone/skins/plone_forms/member_search_results.pt
• Products/CMFPlone/skins/plone_forms/member_search_form.pt.metadata
• Products/CMFPlone/skins/plone_forms/member_search_results.pt.metadata

Products.MailHost is used by other Zope projects as well. Therefore we have to integrate an adapter that reads the mail settings from p.a.registry if Products.CMFPlone is installed.

We will need an upgrade step that takes the old portal property-based GS files and converts those settings into the new p.a.registry-based settings. This task should be started after changing the prefix of the p.a.registry entries from plone.app.controlpanel.* to plone.*.

I think these have already been migrated. I see the corresponding .pt files in the deprecated folder: https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_deprecated/personalize_form.cpt

If that is the case, just confirm and delete the rest of these vestigal organs.

Files affected:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/personalize.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/personalize.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_emailaddr.vpy

I'm surprised if this isn't done already and these aren't just legacy things laying around. If its there for a reason, the first step is to figure out why this wasn't done as a browser view to begin with, then migrate into plone.app.discussion.

Affected Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/discussion_reply.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/discussion_reply_form.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/discussion_reply_form.cpt.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_talkback.vpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/discussion_reply_preview.pt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/discussion_reply_preview.pt.metadata

This is related to the skins removal / plone.app.users PLIP.

This should be the last task once the PLIP has been merged into Plone 5.

There are two options on this plip: this minimal way and the "wholy crap this thing is ancient and I want to make it nicer" way. I'll accept either.

Minimum: Update to z3c and browser views.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/sendto.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/sendto.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_sendto.vpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/sendto_form.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/sendto_form.cpt.metadata

Archetypes / ATContentTypes related tools:

• portal_atct (move into ATContentTypes)
• portal_factory (move into ATContentTypes)
• portal_form_controller (move into ATContentTypes)
• portal_metadata (move into Archetypes)

The functionality is deprecated.

There is a note in the PLIP that says "Already migrated to browserviews during Wine sprint (but not yet z3c.form)". Your task, should you chose to accept it, is to find this code, and then migrate to z3c.form.

Keep in mind this is something that people customize a lot.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/send_feedback_site.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/send_feedback_site.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_templates/send_feedback_confirm.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_templates/contact-info.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_templates/contact-info.cpt.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_site_feedback.vpy

Last but not least, migrate this template to a way that can be overridden in zcml, then update the tool that invokes it:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_templates/site_feedback_template.pt

AKA Just delete it: https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_deprecated

I'm open to argument on this but since its a major release and we have a chance to clean, for love of sanity, let's clean.

Easiest first PLIP ticket ever.

Make sure to update the code in the view at @@personal-information (where is this? a different package?) to reflect the new view.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/portrait_delete.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/portrait_delete.cpy.metadata

Convert to z3c.form and browser views where needed.

Files affected:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_prefs/plone_memberprefs_panel.pt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_prefs/plone_memberprefs_panel.pt.metadata

The functionality is deprecated.

This may be started in a branch of ProductsPasswordResetTool. Check at https://github.com/plone/Products.PasswordResetTool/tree/plip-13260-cpy-removal and make sure the below files are there. Make sure this build points to this branch... then delete!

Files affected:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/plone_change_password.py
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_prefs/password_form.pt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_prefs/password_form.pt.metadata

I am nervous about the integration of this and the member_prefs stuff, which is at #88 . I'm pretty sure PasswordReset is the right package but I could be wrong here.

This is a bit of an eye crosser. Find a way to get rid of https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/cmf_legacy/TitleOrId.py

Summary: Grep until you can't grep no more. Lets find out where this is being used first and then make decisions on how to replace it. Likely that we make this some utility, or if its being used on plone items then we fix the base class to support and replace.

https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_content/author.cpt

https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_content/author.cpt.metadata

This is a larger task than it seems, but not huge. Just don't plan on one hour. The way the author routing works is a bit legacy as well. If we want to keep that method and people need help I have some ideas on how to make it happen.

Take heed of this note in the cpt::

  "NOTE: This form is used in two different ways - from folder_contents,
  allowing you to publish several things at once, and from the state
  drop-down. In the first case, the 'paths' request parameter is set;
  in the second case, giving the relative paths to the content object
  to manipulate; in the second case, this parameter is omitted and the
  path of the context is used."

I think that warning should be heeded, but the new implementation of folder contents listing might not need. The fact that note is needed is a canary in a coal mine. Start with the simplest case, which is the state drop down. This might be a "chuck the code and rewrite" candidate since this should be a simple browser view if anything. You may want to just use plone.api to simplify things. Don't overthink this.

Then look at the multiple items case. I think @vangheem is working on rewriting a lot of this so consult with him on whether or not this will still be needed.

This touches the following files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/content_status_history.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/content_status_history.cpt.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/content_status_modify.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/content_status_modify.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_content_status_modify.vpy

As a proof of concept I used monkey patches for the sync mechanism. Those patches need to be removed.

I'm not sure if this is addressed in the new folder listing plip or not. Please coordinate with them to see if its already re-implemented. If not, move to a utility or something. I swear @vangheem has this code already... somewhere...

Note that this is referenced from folder_contents, and that will need to be updated to reflect the new paths.

Files Rename:

• Products/CMFPlone/skins/plone_scripts/folder_rename.cpy
• Products/CMFPlone/skins/plone_scripts/object_rename.py
• Products/CMFPlone/skins/plone_scripts/folder_rename.cpy.metadata
• Products/CMFPlone/skins/plone_forms/folder_rename_form.cpt
• Products/CMFPlone/skins/plone_forms/folder_rename_form.cpt.metadata
• Products/CMFPlone/skins/plone_form_scripts/validate_folder_rename.vpy

Files Copy:

• Products/CMFPlone/skins/plone_scripts/folder_copy.cpy
• Products/CMFPlone/skins/plone_scripts/folder_copy.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_copy.cpy
• Products/CMFPlone/skins/plone_scripts/object_copy.cpy.metadata

Files Cut:

• Products/CMFPlone/skins/plone_scripts/folder_cut.cpy
• Products/CMFPlone/skins/plone_scripts/folder_cut.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_cut.cpy
• Products/CMFPlone/skins/plone_scripts/object_cut.cpy.metadata

Files Paste:

• Products/CMFPlone/skins/plone_scripts/folder_paste.cpy
• Products/CMFPlone/skins/plone_scripts/folder_paste.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_paste.cpy
• Products/CMFPlone/skins/plone_scripts/object_paste.cpy.metadata

Files Delete:

• Products/CMFPlone/skins/plone_scripts/folder_delete.cpy
• Products/CMFPlone/skins/plone_scripts/folder_delete.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_delete.cpy.metadata
• Products/CMFPlone/skins/plone_scripts/object_delete.cpy

https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_3rdParty

Does js calendar get deprecated because of mockup?

Is this event used anymore? https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_3rdParty/event-registration.js

There is a change that this could just straight up be deleted.

Check to see if this, like a lot of other things, is already in plone.app.content. If not, migrate and then delete from here. Make sure to grep and update anything that might point this way.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/setConstrainTypes.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/setConstrainTypes.cpy.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/folder_constraintypes_form.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/folder_constraintypes_form.cpt.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/validate_folder_constraintypes.vpy

RE: https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/calendar_popup.pt

I think that it should be moved to Products.ATContentTypes, since the calendar widget relies on it. The Plone 5 version should be replaced with mockup.

We currently use interfaces to define the default values for our p.a.registry settings. We should add proper default values to registry.xml in Products.CMFPlone to make it easy for integrators to look up (or copy and override) those settings.

Move to browserviews, figure out whats up with a metadata file and no image associated with it.

Files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/history_form.pt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/history_comparison.pt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_images/history_compare_with_previous_inline.png.metadata

This pertains to the following files:

• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/delete_confirmation_page.cpt
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_forms/delete_confirmation_page.cpt.metadata
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/delete_confirmation.cpy
• https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/skins/plone_form_scripts/delete_confirmation.cpy.metadata

The controlpanel code will be refactored into Products.CMFPlone at some point. Also it does not make sense to use the plone.app.controlpanel prefix for global settings.

There are plenty of patches in https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/patches

We should review them, if any can be dropped by our dependency on Python 2.7 or by progress of Zope, etc.

And on the 5th day, they all revolted

Everything at https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_styles should be in plonetheme.sunburst. Yes, this means that the custom folder will no longer work.

Si-o-na-ra.

Also, be sure to unregister these as folder directories.

I had huge plans to rework login completely but this might fall out of scope of what we can actually do in a small amount of time. Instead, lets integrate gils branch and then make plans after that. The main thing we need to add in this release are TEST CASES (non doc test test cases). Be smart about them and don't do features that are likely to deprecate immediately. You might want to just remove things as well, for the sake of this being a major release and having the opportunity to do so.

@esteele: How angry do you get thinking about having login as a separate package? Does it makes sense?

@gforcada 's work on the migration is at: https://github.com/gforcada/login_forms

Once that is merged in, remove everything at https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_login

Other relevant files:

• Products/CMFPlone/skins/plone_ecmascript/login.js
• Products/CMFPlone/tests/LoginAndLogout.txt
• Products/CMFPlone/tests/testSSOLogin.py
• Products/CMFPlone/tests/emaillogin.txt
• Products/CMFPlone/tests/testEmailLogin.py
• Products/CMFPlone/tests/testLoggedIn.py