platformsh-templates / django4 Goto Github PK

What in this template can be improved or added as a feature?

Template should self auto-update via source operations and workflows

What exactly should be updated?

necessary github workflow files

How important is this feature to you?

N/A

Additional context

No response

What in this template can be improved or added as a feature?

DDEV support is coming, add .ddev.site to ALLOWED_HOSTS

What exactly should be updated?

add .ddev.site to ALLOWED_HOSTS

How important is this feature to you?

Sure helps people.

Additional context

No response

What in this template can be improved or added as a feature?

It would be very helpful to have an official version of this with Pip support not just Pipenv.

What exactly should be updated?

Should be as simple as adding a requirements.txt file, updating the build commands in platform.app.yaml similar to what Eric has here: https://github.com/ehmatthes/django-simple-deploy/blob/main/simple_deploy/templates/platform.app.yaml

I guess mainly it'd be good to know if there's anything else that changes with Pip vs Pipenv. I would say anecdotally that Pip is far more common than Pipenv at this point in the Django community.

How important is this feature to you?

It helps me move forward with confidence and recommend Platform.sh to others vs other hosting providers.

Additional context

No response

Describe the bug

When source operations toolkit is run on Django 4, neither the Pipfile or poetry.lock file can be found.

Include some logs

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Reproducing

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Expected behavior

If anything, we would expect that - since the default app is running pip:

• Pipfile is detected, but fails to update (pipenv not installed)
• poetry.lock is detected, but fails to update (poetry not installed)

Your environment

See above

Screenshots

No response

Additional context

Temporary pipeline fix implemented in #23

Describe the bug

routes.yaml contains initial comment block from services.yaml

Include some logs

https://github.com/platformsh-templates/django4/blob/c81bb9322904890dc604a37a0121c6d0137585ad/.platform/routes.yaml

Reproducing

https://github.com/platformsh-templates/django4/blob/c81bb9322904890dc604a37a0121c6d0137585ad/.platform/routes.yaml

Expected behavior

contains correct docs

Your environment

n/a

Screenshots

No response

Additional context

No response

What in this template can be improved or added as a feature?

Currently the settings.py is missing settings for email:
https://docs.djangoproject.com/en/4.0/topics/email/

What exactly should be updated?

EMAIL_HOST = os.getenv("PLATFORM_SMTP_HOST")
EMAIL_PORT = os.getenv("PLATFORM_SMTP_PORT", 25)

How important is this feature to you?

Not a blocker

Additional context

No response