plasmapower / assert-request Goto Github PK

This is supported by supertest

request.get('/foo').assert(res => myPromiseAssertion(res))

Should be a simple change to something like:

'use strict';

const assert = require('assert');

module.exports = {
  assert: function (fn) {
    return this.then(function (res) {
      return Promise.resolve(fn(res))
        .then(value => assert(value))
        .then(() => res);
    });
  }
};

$ cat test_app.js
/* eslint-env node,mocha */
var express = require('express');
var app = express();

app.post('/', function (req, res) {
  res.json({
    'response_type': 'ephemeral',
    'text': 'hi there\nhi\n'
  });
});

var AssertRequest = require('assert-request');
var request = AssertRequest(app.listen());

describe('basic', function () {
  it('json.post', function () {
    return request.post('/', {
      body: { 'key': 'value' },
      json: true
    })
      .type('application/json')
      .status(200)
      .json({
        'response_type': 'ephemeral',
        'text': 'hi there\nhi\n'
      });
  });
});

json: true in request will automatically encode the sending and receiving body.

One possible fix is to check if (typeof res.body === 'object') in mixins/json.js but I'm not sure its the best solution so havn't submitted a PR.

A cookies mixin could be very helpful in some cases in simplifying use cases of the header mixin.

Please consider to make the license more clear adding a LICENSE file at the root of the repo or mentioning it in a "license" section in the README.

I know that package.json has it, but I think that one of those solutions would make it very visible.

Thanks for the module and release it under MIT

I really like the idea of this. But I can't get it to work (Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.).
I would really appreciate a whole lot more of examples and may be links to projects that are already using it.

Is it possible to set request headers somehow?

With superagent and supertest you use .set()
https://github.com/visionmedia/supertest/blame/d0c14578cd51eab83019ee7d5a46d21a2ae5b170/Readme.md#L48-L60

TypeError: AssertRequest(...).post(...).set is not a function
TypeError: AssertRequest(...).set is not a function

( [email protected] )