planeta / linux Goto Github PK

All these kfrees inside ovey_verbs.c must be ref_down

Adding and deleting devices must participate in reference counting for the module usage. Opening and closing device must count for the device usage.

rmmod ovey must delete existing devices. If some device is open, the driver must not be removed.

Function rxe_udp_encap_recv is responsible for receiving the RoCE packets. For each packet, it linearizes the skb:

This operation hurts performance a lot and must be removed from the critical path. Unfortunately, it requires non-trivial changes through the whole driver code, as accessing packet becomes less trivial.

When posting a UD WQE, the user-level buffer code provides the full address (destination GID), instead of AH handle. This seems to be unnecessary because it increases the message size and happens in the kernel anyway. Why do the same work twice?

To solve the issue, the following structure must be unshared from the user code (similar changes to be done in rdma-core repo)

The API must be restructured to pass AH handle instead of AV.

The corresponding snippets in the rdma-core are following:

https://github.com/planetA/rdma-core/blob/54c238172ce90ee3513c946eeaa25965f88e7620/providers/rxe/rxe.c#L605-L607

https://github.com/planetA/rdma-core/blob/54c238172ce90ee3513c946eeaa25965f88e7620/kernel-headers/rdma/rdma_user_rxe.h#L58-L67

https://github.com/torvalds/linux/blob/d652ea30ba32db12fe8365182fad5ba2e7c22822/drivers/infiniband/core/verbs.c#L1202

https://github.com/torvalds/linux/blob/d652ea30ba32db12fe8365182fad5ba2e7c22822/include/rdma/ib_verbs.h#L4280