pladaria / html5-websocket Goto Github PK

Please add support for browser compilation by adding a "browser" entry on the package.json file.

This file should contain:

// Export native window.WebSocket on browsers
module.exports = WebSocket;

Modernizr checks for WebSocket.CONNECTING. Copy constants from prototype to class.

We have been successfully using html5-websocket v1.0.0 but the upgrade to v2.0.0 breaks our builds: https://travis-ci.org/wireapp/wire-web-api-client/builds/263607663

The main error is:

Expected 'Hello, World!' to be 'Echo: Hello, World!'.

It comes from a test where an echo server is created:

server = new WebSocketServer({port: WEBSOCKET_PORT});
server.on('connection', (ws) => {
  ws.on('message', (message) => server.clients.forEach((client) => client.send(`Echo: ${message}`)));
});

The test then checks if the echoed message from the server can be received:

client.connect().then((socket) => {
  expect(socket).toBeDefined();

  socket.onmessage = (event) => {
    expect(event.data).toBe(`Echo: ${message}`);
    done();
  };

  socket.send(message);
}).catch(done.fail);

This doesn't seem to work anymore. Do you think it's related to your major upgrade of "ws"? 8a28994

Here is our test setup:

• https://github.com/wireapp/wire-web-api-client/blob/v0.1.2/spec/WebSocketClientSpec.js#L12

If I use the WebSocket constructor for ReconnectingWebSocket, I can write

rws.on('open', () => { ... });

After switching to html5-websocket, the code using WebSocket no longer works, and I have to switch to onopen etc.