placeos / backoffice Goto Github PK

Describe the bug
Creating a new user in Backoffice, after saving the user is created but the name is blank.

To Reproduce
Steps to reproduce the behavior:

1. Go to users.
2. Add new user.
3. Enter required details, name, email etc.
4. Save new user
5. New user will appear in the user list with no name

Expected behavior
Username should be shown in the user list and when inspecting the user.

Screenshots
If applicable, add screenshots to help explain your problem.

Zones can now have parents

• field name is parent_id - so could you please add a zone dropdown in new and edit
• Have a tab for viewing the children of a zone - same as the get a list of zones request with the param parent=zone-parent-id

Please filter out the current zone_id from the results when showing that zone. As we don't want a zone to be its own parent

Would it be possible to add a toggle button to hide or show the password too?

Documentation: https://placeos.docs.apiary.io/#reference/0/zones/get-zone-children-metadata
(Get and update metadata, not listed there is a delete - same as update just with delete verb)

Currently blocked by PlaceOS/rest-api#13

Describe the bug
Debug dialogue auto-closes. This is an issue as often you want to stop debugging so you can scroll around the debug window freely.

Basically you are capturing information and then you want to analyse that information (without it jumping to the bottom when new data comes in - so you'll stop debugging to do this)

To Reproduce
Steps to reproduce the behavior:

1. debug a driver
2. stop debugging (so you can look at the history of the debugging output)
3. debug window disappears

Expected behavior
Once the debug window is open, the user should be able to toggle it open and closed
Auto-open is good and it should never auto-close.

Screenshots

Describe the bug
Editing a user to add the username after creation causes an error when saved.

To Reproduce
Steps to reproduce the behavior:

1. Go to users
2. Edit a user
3. Change/Enter something in the name field
4. Save
5. Error

Expected behavior
User should save with updates.

Screenshots
If applicable, add screenshots to help explain your problem.

Integrate Kibana into a Backoffice tab with a graceful fallback if Kibana is unavailable.

Supported by PlaceOS/local#3

We need to be able to change the commit

Rendered settings pane does not resize after initial paint

Request here is /modules?system_id=sys- but it should be /modules?control_system_id=sys-
currently it's listing all modules

Ensure that the login page is always styled.

• you SHOULD NOT be able to change the commit on a Driver repository
• you SHOULD be able to change the commit on an Interface repository
• commits for interfaces are for the purpose of rolling back, so do not fetch the commits when creating an Interface repository
• you SHOULD use the commits endpoint when someone wants to update an Interface repository

relevant PR: PlaceOS/rest-api#21

We've added these additional fields to help minimise the number of requests required by the staff app
https://github.com/PlaceOS/models/pull/11/files

Would you please add them to the forms in backoffice

Describe the bug
Unable to delete users due to error.

To Reproduce
Steps to reproduce the behavior:

1. Go to: http://pwcme.dev.place.tech/backoffice/#/users/user-En-GsyA5DTr/about
2. Try to delete the no name user

Expected behavior
User should be deleted.

Screenshots
If applicable, add screenshots to help explain your problem.

Folder Name and Repository Type should not be editable.

Describe the bug
When editing a zone it shows the zone has multiple tags which are not readable although the zone itself only shows a single tag.

To Reproduce
Steps to reproduce the behavior:

1. Go to a zone with a tag.
2. Click edit.
3. Observe tag field in edit modal and compare with actual tags.

Expected behavior

1. If multiple tags in edit modal they should all be expandale and/or readable.
2. Tags in edit modal should match zone tags.

Screenshots
If applicable, add screenshots to help explain your problem.

It saves the driver but fails to save the settings:
gets stuck here

Seems to be the case with most pop-ups.
This is an example when adding a new driver

The field module.control_system_id is really only for logic modules where it must be set.
For all other types of drivers it should not be set in 99.99% of cases

You probably shouldn't be able to change this to a different system either (as you are adding it to the system you are currently viewing)

Display and allow editing of settings for Zone, Driver, System and Module at Unencrypted, Support and Admin encryption levels.

There should be a view of the merged results.

When the debug box is open, everytime a new message comes in it scrolls to the top, but the new messages come in at the bottom.

Could you please change it to scroll to the bottom. Thanks 👍

debug box:

Describe the solution you'd like
Under the admin section, it would be great if we had a license management tab where we can see how many system licenses are consumed and set the number of licenses purchased via the client.

Using an internal account we can increase or decrease the amount of purchased licenses, in turn preventing the client from adding more licenses without limit than what they have purchased.

Describe alternatives you've considered
Nil

Additional context
Prevent additional license usage beyond what has been purchased.

When closed (even if never opened) the console prevents interaction with anything that would otherwise be obscured by the console at it's default open size.

If you resize it, it still only obscures interactions under where the console would be at its default size.

Bit of a weird one, luckily it's not usually obscuring too much usually but was a strange but as the mouse still changes for the resize hovers (tested in chrome)

When adding a new driver, if you select the wrong repository and then switch to a different one

Then the driver list doesn't update and remains listing the old driver list.

Describe the bug
Viewing the application list it is empty but the header shows it does have items counted.

To Reproduce
Steps to reproduce the behavior:

1. go to domains
2. select a domain
3. click applications

Expected behavior
List of applications should be shown to match the count.

Screenshots
If applicable, add screenshots to help explain your problem.

When viewing an individual module, the 'Stop Module' button does not generate any requests when interacted with.

Similarly, when on a system view, interacting with the module state control always results in a start request being sent.

So you can see the full commit message

• For a logic module, configuring the system via the selection drop down is a requirement
• For all other types, hide this drop-down

When adding a module from the control system view, never show the system dropdown
(continue showing the pre-selected system when adding a logic module)

You can't get function signatures from module that is not running.

Please check the state of the module and disable selection of modules that are not running from the executable drop-down.

This also applies to the view-state and reload-module options on the pop-out menu

Opening, closing and changing tabs etc causes a bank space to build up

Looks like something to do with a-terminal height calculation

This is a nice component from the WIP website.
Could we have something similar in backoffice?

Looks like add new list is being filtered by the front-end?
On one system I have the option to add two modules, on the other only one.
Makes the same request to the backend which returns both results.. But front-end is only showing one result and only in this system.. Refreshing the page made no difference either.

Then the other system

Currently says "add zone zone-123355 to system My Room"

Should use zone name like "add zone Friendly Zone Name to system My Room"

Weird behaviour where the request succeeds but then also gets a timeout?

This one really trips me out as I thought they were both the same request?

I have a feeling this might only be happening to me and the requests are being load balanced between two services sharing the port?
Is this something that ever happens to you @caspiano ?

Like it's probably nothing to do with Backoffice @MrYuion - just putting this issue here for discussion.

Attempting to register a new application from within the domain tab results in a 404.

• This list needs the details (IP or URI) displayed in the same way as the modules tab
• logic modules should not appear on this list (as they can only exist in a single system)
• How does searching work? I can't seem to filter using IP address for instance

Describe the bug
When adding a new user that duplicates an existing users email address it generates an error and fails to save - can the error message be descriptive to point the user to the actual failure? Current Ajax error does not assist in triaging the issue.

To Reproduce
Steps to reproduce the behavior:

1. Go to users.
2. Add new user.
3. Create new user with same email address as an existing user.

Expected behavior
Error should state user could not be saved as email already exists.

Screenshots
If applicable, add screenshots to help explain your problem.

View error on a failed execute request does not show the error response.

Please add a header to the colour column state

Colours for regular browser mode:

• black, not running
• red, running and disconnected (live state from binding)
• green, running and connected (live state from binding)

Default to the database listed connected state until the binding data comes through

For dark mode:

• white for not running

Describe the bug
When viewing a system, settings inherited from zones do not display in the "Merged" tab until after an edit has been made to the system level settings.

To Reproduce
Steps to reproduce the behavior:

1. Apply setting to a zone
2. Navigate to a system within this zone
3. Look at "Merged" tab - zone level settings do not show
4. Edit system level settings
5. Move backed to "Merged" tab - both zone and system level settings now show.

Expected behavior
"Merged" tab should show full merged settings when viewed.

Adding a module to a system causes it to appears at the top of the list.

After Selecting another system and then coming back or refreshing, then the module is at the bottom of the list, where it should be.

Describe the bug
Where a zone has multiple children the count is not updated in the nav bar.

To Reproduce
Steps to reproduce the behavior:

1. Add children to a zone.
2. Go to the Children page.
3. Children list will be shown but count remains at one in the navigation

Expected behavior
Children count should reflect the number of children items in a zone.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: OS X
• Browser: chrome

Describe the bug
Applications shows a count of 4, I know there are applications there but they are not shown.

To Reproduce
Steps to reproduce the behavior:

1. Go To Domains -> Applications
2. No Applications are shown despite the count.

Expected behavior
Applications are shown.

Screenshots

Basically it would be a waste of processing to parse each value on the server-side (as the main purpose of this API is debugging)
So before displaying the state can you parse each keys value?

The details request returns defaults such as port which are not being used currently.
The various fields that can be returned are: details response => driver add form field

name => Name
generic_name => Module name
description => Description
tcp_port => Default Port number
udp_port => Default Port number
uri_base => Default URI
default_settings => to be added to unencrypted settings as a second API call after object creation

If possible the default settings should be placed into the unencrypted settings object (this will require a second API call however it is definitely useful and required to make things seamless)

In terms of the driver role

• If tcp_port or udp_port are present then default it to Device
• if uri_base is present then default it to Service
• otherwise default it to Logic as it does currently

When clicking toggle on a running and disconnected module, it calls start and notifies that stop was successful.

Experimentally it seems to be toggling based on connected status, versus the running state (where it should be using running state as the only indicator)

The notification always indicates that the module was stopped no matter if it calls start or stop.

Clicking send on a function where all parameters are optional stops the component from updating (can't select a different function) and does not execute the command.

Describe the bug
When adding a new zone, entering text in the parent zone should produce a dropdown with a list of available zones to select as parent.

To Reproduce
Steps to reproduce the behavior:
1.Add new zone.
2. Start typing in parent zone field.
3. no drop down.

Expected behavior
drop down should be available to select zones filtered by text entered.

Screenshots
If applicable, add screenshots to help explain your problem.

Describe the solution you'd like
Is it possible to a show a date with the commit hash to make it easier to identify, having to correlate with the hash to find the latest is not ideal.

Describe alternatives you've considered
Having the commit selector to default to the most recent if no commit is selected?