pkp / staticpages Goto Github PK

Hey,

in the StaticPageForm there seems to be a unnecessary code duplication in the fetch method.

On the lines 80 - 87 smarty variables get assigned when $request->getContext(); is not falsy.

On the lines 89 - 96 the same things happen.

Is there a reason for the second time of setting the variables?

Currently static pages must be associated with a specific context. Permit site-wide (context_id=0) static pages, and ensure that they can be administered through the Site Administrator's tools.

As foreign keys have been added to the initial migration, existing tables need to be upgraded as well.

Notice the solution will need to handle the cleanup of orphaned data (invalid context_id and static_page_id).

Ideas:

• https://github.com/pkp/orcidProfile/blob/main/OrcidProfilePlugin.php#LL1646C6-L1646C6
• pkp/pln#53 (review)

There are useless constructors:

See:

and