Describe the bug
After it did not work on the production website, I made a clean install of OJS 3.4.0.5 in MAMP and activated the Immersion theme to see if I could adjust the section colors here. I can adjust section colors per issue and save but they always return to the standard black for all sections (production site and MAMP). Picking colors for the journal description and announcements does work.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Issues'
2. Select Issue, click 'Edit'
3. On 'Issue Data' scroll down to 'Color Picker'
4. Select colors for sections
5. Click 'Save'
6. Check journal frontend > all sections black
7. Check backend: All sections black under 'Color Picker'

Expected behavior
The section colors should reflect the selection upon saving.

Desktop (please complete the following information):

• OS: macOS 14.4.1 (23E224)
• Browser: Chrome, Safari, Firefox]

Additional context
The journal uses two languages, English (default) and Japanese. I noticed that I have to upload the logo and issue covers separately for each language to correctly display. May this interfere with saving the section colors?

Rename variables and method calls according to new OJS 3.2.0 release for searchAuthorDetails.tpl.

Occasionally seeing the following error in our logs:

Undefined index: enabled in plugins/themes/immersion/ImmersionThemePlugin.inc.php on line 197

The line in question: https://github.com/pkp/immersion/blob/master/ImmersionThemePlugin.inc.php#L197

The homepage results in a fatal error if no issue has been published. I think this will also happen if there is no "current" issue.

[04-Dec-2018 11:09:17 Europe/London] PHP Fatal error:  Uncaught Error: Call to a member function getId() on null in /home/nate/Projects/pkp/ojstemp/plugins/themes/immersion/ImmersionThemePlugin.inc.php:110
Stack trace:
#0 /home/nate/Projects/pkp/ojstemp/lib/pkp/classes/plugins/HookRegistry.inc.php(107): ImmersionThemePlugin->addIssueTemplateData('TemplateManager...', Array)
#1 /home/nate/Projects/pkp/ojstemp/lib/pkp/classes/template/PKPTemplateManager.inc.php(856): HookRegistry::call('TemplateManager...', Array)
#2 /home/nate/Projects/pkp/ojstemp/pages/index/IndexHandler.inc.php(75): PKPTemplateManager->display('frontend/pages/...')
#3 /home/nate/Projects/pkp/ojstemp/lib/pkp/classes/core/PKPRouter.inc.php(390): IndexHandler->index(Array, Object(Request))
#4 /home/nate/Projects/pkp/ojstemp/lib/pkp/classes/core/PKPPageRouter.inc.php(232): PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(Request), Array, false)
#5 /home/nate/Projects/pkp/ojstemp/lib/pkp/classes/core/Dispatcher.inc.php(134): PKPPageRouter->route(Object(Request))
#6 /home/nate/Projects/pkp/ in /home/nate/Projects/pkp/ojstemp/plugins/themes/immersion/ImmersionThemePlugin.inc.php on line 110

For better compatibility with the plugin release tool, it would be helpful to add an exclusions.txt file that lists any files/directories that should not be included in release packages. This may include git files, packages, tests, or anything else that is usually excluded.

See: pkp/pkp-lib#5560

Hi,
we just have setup the OpenID provider to allow users to login with their ORCID.
However, OpenID login is only possible via the "register" page, not via the pop up login window: The pop-up window only allows for legacy registration. So users who have registered using their ORCID will have difficulties to log in to the site.

Possible Solutions:
a) add the OpenID Providers to the login pop-up window
b) disable the login pop-up window, so that users can only login via the "register" page.

OJS Version 3.3.0.8
Immersion Theme 1.1.0.0

Yours,
Felix

Describe the bug
The Issue level DOIs aren't displayed

To Reproduce
Steps to reproduce the behavior:

1. Assign a dummy DOI to an issue and publish
2. Click on current
3. Scroll down to description
4. DOI for the issue does not appear

Expected behavior
DOI as link should show up somewhere

Screenshots
DOI assigned:

DOI doesn't appear:

Desktop (please complete the following information):

• OS: macOS 11.0.1
• Browser Firefox
• Version OJS Version: 3.2.1.1; Immersion version: 1.0.5

Good day,
I have not seen a search button or bar on the theme.
I need to add a search button, along side the Current, Archives and About buttons. Please, which file do I need to edit to do that? I am comfortable with html, and CSS.

Thank you for this bold theme.

You used to be able to adjust colour by section but that doesn't seem to exist in 3.2.

Describe the bug
In homepage, a section that has been added in "website -> advanced -> additional contents" is not displayed properly.
It seems like div statements are cut away.

To Reproduce
In the following static page, two columns (in the same line) are created through some div statements:
https://esperienzesociali.it/esperienzesociali/redazione

Unifortunatel, in homepage the same code does not work and the browser puts the two div statements one under the other:
https://esperienzesociali.it/esperienzesociali

Expected behavior
As in the first page (two columns, one aside the other)

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser: Brave
• Version of OJS: 3.4.0.3

Additional context
Add any other context about the problem here.

See: pkp/healthSciences#173

Hello support,

Am not sure why the usage graph display an undefined on the x - axis

as shown here https://prnt.sc/hyCMXBIib895

also check here live https://ijessonline.com/index.php/ijess/article/view/2

Kind Request Simon

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

If you happen to have a link in your "about the journal" text, it won't be obvious in the "about the journal" callout at the top of a journal homepage. I acknowledge that this is a bit of an edge case since links aren't super common there.

Hi,
we just have setup the OpenID provider to allow users to login with their ORCID.
However, OpenID login is only possible via the "register" page, not via the pop up login window: The pop-up window only allows for legacy login. So users who have registered using their ORCID will have difficulties to log in to the site.

Possible Solutions:
a) add the OpenID Providers to the login pop-up window
b) disable the login pop-up window, so that users can only login via the "register" page.

OJS Version 3.3.0.8
Immersion Theme 1.1.0.0

Yours,
Felix

In journal section metadata, there's a qualifier to omit the author name from a journal section. This is, by an large, a workaround for journals publishing articles that don't have "an author". Stuff like errata or abstracts collections or any other number of things. These are usually uploaded by managing editors or other journal staff who are also authors of legitimate materials.

This is from 3.x and up.

The immersion theme displays these author names even if the radial to not display them is selected.

https://www.dropbox.com/s/8dbtg72gj75pz6x/Screenshot%202020-05-28%2011.12.22.png?dl=0

You can find the relevant setting in Journal>Sections>Edit>Omit Author from Journal section...

I'd add that this should also omit the author from citations, the article landing page, and any other associated metadata. But even better, it should be possible to just not have an author. :)

see: pkp/pkp-lib#5623

Related to: pkp/pkp-lib#4612

Describe the bug
Health Science theme has fatal error on search.tpl page when running on php 8.0 (+?)

To Reproduce
Steps to reproduce the behavior:

1. Use the health science theme
2. Visit the search page where the search filters would be displayed.

Expected behavior
Search page should load without errors.

Additional context
Page throws an error:
PHP Fatal error: Uncaught Error: Attempt to modify property “value” on null in /var/www/html/cache/t_compile
Found this to be a similar issue:
https://forum.pkp.sfu.ca/t/ojs-3-3-0-11-search-page-not-loading-in-health-sciences-theme/74391
Which was stated to be fixed with the change in this commit (on the second file, search.tpl):
default theme fix - pkp/ojs@d876fbc
However, the circumstance that we're running into is the same as the OP, on PHP 8.0 (not PHP 8.1). Updating with the change from the default theme has been tested working with php 7.4.30 and 8.0. It is presumed that PHP 8.1 would have the same issue.

Related Issues:
Health Sciences - pkp/healthSciences#220
Classic - pkp/classic#100

Tested with OJS 3.1.2 and the current master branch of the Immersion theme.
Associated PHP error:

PHP Fatal error:  Uncaught Error: Call to a member function getId() on null in /var/www/ojs-3.1.2/plugins/themes/immersion/ImmersionThemePlugin.inc.php:320
Stack trace:
#0 /var/www/ojs-3.1.2/lib/pkp/classes/plugins/HookRegistry.inc.php(107): ImmersionThemePlugin->addToIssueForm('issueform::disp...', Array)
#1 /var/www/ojs-3.1.2/lib/pkp/classes/form/Form.inc.php(174): HookRegistry::call('issueform::disp...', Array)
#2 /var/www/ojs-3.1.2/controllers/grid/issues/form/IssueForm.inc.php(94): Form->fetch(Object(Request))
#3 /var/www/ojs-3.1.2/classes/controllers/grid/issues/IssueGridHandler.inc.php(160): IssueForm->fetch(Object(Request))
#4 /var/www/ojs-3.1.2/classes/controllers/grid/issues/IssueGridHandler.inc.php(132): IssueGridHandler->editIssueData(Array, Object(Request))
#5 /var/www/ojs-3.1.2/lib/pkp/classes/core/PKPRouter.inc.php(390): IssueGridHandler->addIssue(Array, Object(Request))
#6 /var/www/ojs-3.1.2/lib/pkp/classes/core/PKPComponentRouter.inc.php(257): PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(Request in /var/www/ojs-3.1.2/plugins/themes/immersion/ImmersionThemePlugin.inc.php on line 320

...In this case, we have the following two options which appear on the dashboard under Website settings > Appearance:

• Show journal’s summary / description on the homepage
• Select a background colour for this section

However, these options are directly linked to the Journal summary content which is input in Journal settings > Masthead > Journal summary; it would make more sense to display these options directly underneath the Journal summary content editor. Furthermore, the terminology does not match (description => summary).

Same thing applies to the Section descriptions, which should be at the same place that we can add, edit, or remove Section titles and descriptions. It should be found in Journal settings > Sections.

For example, in the Announcements section (Website settings > Announcements), the user can select whether or not they want to display them on the homepage, and what background colour they want for this section. This makes sense, as they are updating their announcements in the same page.

Describe the bug
Using two locales (English and Japanese), the frontend does not pick up translations for months in the download stats of an article or the publication date of an issue (see screenshots).

To Reproduce
Steps to reproduce the behavior:

1. Activate additional locale/language
2. Check frontend.

Expected behavior
The publication date in Japanese should be 2024年5月1日 not 2024 May 1.
The download graph should display Japanese months as in the locale language file (1月 2月 3月 etc., not Jan Feb Mar etc.).

Screenshots
Publication date in Japanese

Publication date in English

Downloads in Japanese

System Information:

• OJS 3.4.0.5
• Immersion Theme 1.1.2.2
• PHP 8.2.6

Browsers:
Safari, Chrome, Firefox, DuckDuckGo (all newest versions, on macOS 14.4.1

Additional context
I translated the plugin on weblate into Japanese, please integrate in future releases: https://translate.pkp.sfu.ca/projects/plugins/immersion/ja/
(I installed my translation locally for testing)

License form and licenseTerms variable was introduced in OJS 3.2; copyrightHolder and copyrightYear are deprecated.

Describe the bug
The plus sign next to the author name used to show the author's affiliation looks like the cross or dagger symbol used to indicate that the author is deceased in many countries.

To Reproduce
Steps to reproduce the behavior:

1. Publish and article where the author has an affiliation
2. Go to the article detail page and scroll to the author
3. Plus sign next to author name

Additional Context
The editor that shared this concern with me indicated that the association is very strong in some countries/academic communities

...in issue_toc, we still don’t display the cover images.

See: pkp/pkp-lib#5813

Describe the bug
After upgrading an installation from OJS 3.3 to OJS 3.4 the journal stops to work on the frontend when Immersion Theme is enabled. It returns an error code 500

To Reproduce
Steps to reproduce the behavior:

1. Upgrade OJS 3.3 to 3.4
2. Go to dashboard
3. Enable and select Immersion theme (using tag 1.1.2)
4. Check the home page
5. See the error

Expected behavior
Loading the public interface.

Desktop (please complete the following information):

• OS: MacOS
• Browser chrome
• Version 115

Additional context
Apache log error message:

Fatal error: Uncaught Exception: Unrecognized DAO SectionDAO! in /var/www/html/lib/pkp/classes/db/DAORegistry.php:77 
Stack trace: 
#0 /var/www/html/plugins/themes/immersion/z(186): PKP\db\DAORegistry::getDAO('SectionDAO') 
#1 [internal function]: ImmersionThemePlugin->addIssueTemplateData('TemplateManager...', Array) 
#2 /var/www/html/lib/pkp/classes/plugins/Hook.php(140): call_user_func_array(Array, Array) 
#3 /var/www/html/lib/pkp/classes/plugins/Hook.php(113): PKP\plugins\Hook::run('TemplateManager...', Array) 
#4 /var/www/html/lib/pkp/classes/template/PKPTemplateManager.php(1300): PKP\plugins\Hook::call('TemplateManager...', Array) 
#5 /var/www/html/pages/index/IndexHandler.php(80): PKP\template\PKPTemplateManager->display('frontend/pages/...') 
#6 [internal function]: APP\pages\index\IndexHandler->index(Array, Object(APP\core\Request)) 
#7 /var/www/html/lib/pkp/classes/core/PKPRouter.php(334): call_user_func(Array, Array, Object(APP\core\Request)) 
#8 /var/www/html/lib/pkp/classes/core/PKPPageRouter.php(277): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\core\Request), Array, false) 
#9 /var/www/html/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPPageRouter->route(Object(APP\core\Request)) 
#10 /var/www/html/lib/pkp/classes/core/PKPApplication.php(373): PKP\core\Dispatcher->dispatch(Object(APP\core\Request)) 
#11 /var/www/html/index.php(21): PKP\core\PKPApplication->execute() 
#12 {main} thrown in /var/www/html/lib/pkp/classes/db/DAORegistry.php on line 77

See: pkp/ojs#2437

OJS 3.1.2-1.

The issue goes from OJS 2 (don't know exact details).
Issue page contains $primaryGenreIds array that can be used for this purpose. Compare article_summary.tpl with the same template from the default theme for details.

Consider making the same for other themes as well.

Describe the bug
On the journal homepage, if you click on the issue image for the current issue you get a 404 error

To Reproduce
Steps to reproduce the behavior:

1. Go to the home page of a journal with a current issue that has an image
2. Click on the image
3. 404 page not found

Expected behavior
Should take you to the issue

Desktop (please complete the following information):

• OS: macOS 11.0.1
• Browser Firefox
• Version 78.5.0esr

Additional context
In the issue_toc.tpl file, the href url encoding is missing the page argument (i.e. page="issue")

Hello!

not sure if this little issue is with this template or some translation files, but with some languages (eg. Italian) this dot between the translate key "issue.no" and the "$issue->getNumber":

<span class="issue__number">{translate key="issue.no"}. {$issue->getNumber()|escape} </span>

of the file 'templates/frontend/objects/issue_toc.tpl' make the final result like this:

No.. 5

Which one do you think should be corrected?

Thanks

See: pkp/pkp-lib#6400

This can lead to a fatal error on issue and search page if the journal has publishing mode set to a subscription required.

Steps to reproduce the behavior:

1. Go to Distribution settings -> access.
2. Chose second option (The journal will require subscriptions to access some or all of its contents.)
3. Go to the issue page (e.g., current issue)
4. See error

OJS version 3.2.0
Immersion theme version 1.0.4.1

Adjust the published date to be displayed in the long format in main and stable branches:

See this fix from the default theme: pkp/ojs@f4cf12c.

The count($journals) in the site-wide index template didn't work. So you'll want to update your templates to use $journals->wasEmpty().

Also, the pagination can be removed because all journals are delivered to the template. There's no second page.

Describe the bug
Described here: https://forum.pkp.sfu.ca/t/immersion-theme-black-on-black-for-the-download-graphs/67457

The background color of the main section of the article landing page is black. Because of the color, the graph of the Usage Statistics Plugin is merged with page's background.

To Reproduce
Steps to reproduce the behavior:

1. Install an activate UsageStats plugin
2. Go to the article landing page
3. See the area with the plugin's canvas

Expected behavior
The graph should be clearly visible.

Screenshots
See the forum

Hi all,

I’m running a new installation of OJS 3.04-1 on Ubuntu 22.04 with PHP 8.1 and Apache2.

I have a strange problem with the Immersion theme. Everything seems to work, except for the ‘Issue Data’ tab, where Immersion injects its custom section colour options.

When I access that tab, I see nothing - just an empty tab.

There are two error events in the Apache log that are of note.

The first occurs when the website is first loaded. This seems to be an Apache2 error rather than a problem with OJS, per se. It might be completely unrelated.

[Sun Jul 30 08:36:39.686889 2023] [php:notice] [pid 1305] [client ] Server host “209.250.229.15” not allowed!

[Sun Jul 30 08:36:39.686935 2023] [php:notice] [pid 1305] [client 184.105.139.67:19246] ojs2: 400 Bad Request

[Sun Jul 30 08:41:56.935671 2023] [php:notice] [pid 982] [client 143.110.222.166:43370] Server host “209.250.229.15” not allowed!

[Sun Jul 30 08:41:56.935736 2023] [php:notice] [pid 982] [client 143.110.222.166:43370] ojs2: 400 Bad Request

And the second occurs when the ‘Issue Data’ tab is accessed.

[Sun Jul 30 08:58:45.433240 2023] [php:error] [pid 2326] [client ] PHP Fatal error: Uncaught Exception: Unrecognized DAO SectionDAO! in /var/www/html/ojs/lib/pkp/classes/db/DAORegistry.php:77\nStack trace:\n#0 /var/www/html/ojs/plugins/themes/immersion/ImmersionThemePlugin.inc.php(442): PKP\db\DAORegistry::getDAO()\n#1 [internal function]: ImmersionThemePlugin->addToIssueForm()\n#2 /var/www/html/ojs/lib/pkp/classes/plugins/Hook.php(140): call_user_func_array()\n#3 /var/www/html/ojs/lib/pkp/classes/plugins/Hook.php(113): PKP\plugins\Hook::run()\n#4 /var/www/html/ojs/lib/pkp/classes/form/Form.php(182): PKP\plugins\Hook::call()\n#5 /var/www/html/ojs/controllers/grid/issues/form/IssueForm.php(112): PKP\form\Form->fetch()\n#6 /var/www/html/ojs/classes/controllers/grid/issues/IssueGridHandler.php(211): APP\controllers\grid\issues\form\IssueForm->fetch()\n#7 [internal function]: APP\controllers\grid\issues\IssueGridHandler->editIssueData()\n#8 /var/www/html/ojs/lib/pkp/classes/core/PKPRouter.php(334): call_user_func()\n#9 /var/www/html/ojs/lib/pkp/classes/core/PKPComponentRouter.php(291): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()\n#10 /var/www/html/ojs/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPComponentRouter->route()\n#11 /var/www/html/ojs/lib/pkp/classes/core/PKPApplication.php(373): PKP\core\Dispatcher->dispatch()\n#12 /var/www/html/ojs/index.php(21): PKP\core\PKPApplication->execute()\n#13 {main}\n thrown in /var/www/html/ojs/lib/pkp/classes/db/DAORegistry.php on line 77, referer: https:///index.php/testjournal/manageIssues

I note that a similar issue was raised here:

#85

However, I cannot get the proposed solution, here:

https://github.com/pkp/immersion/pull/86/files/1cc70c27f159ddc9aa05338bd70f8ce6d62a4f33

to work.

If I implement the changes at 201 & 442, then access to the tab is restored, but if I try to set custom colours, the whole site breaks and returns an error 500.

If I implement the change at 186 as well, then the whole site breaks.

Perhaps implementing only the change at 201 is the answer, but I haven't tried this yet.

MacOs Catalina 10.15.7
Chrome 114.0.5735.198

Thank you for any assistance you can provide.

• new front-end template was introduced for the plugin: orcidVerify.tpl, orcidAbout.tpl
• occurrence on the registration page

See: pkp/pkp-lib#5947

The immersion theme falls back to the default primary and secondary color for all sections

See: pkp/classic#88