Typo in this line (where instead of were)

css3d-game/3d/js/level-01.js

Line 2334 in 772a744

'Where you captured? But by whom and where are you now?']

Shabby torch did not seem clickable

Tested on: Firefox 80, Chromium 84

Down in the sewers after staying still when the monster approaches, there is a shabby torch that can be picked up.

Other than all previous items that can be interacted with, this one does not change the cursor on hover.

Minor typo

At

css3d-game/3d/js/level-02.js

Line 2266 in 772a744

['The door does not badge, and there is no visible door handle.'],

badge should be budge

[style] game.LOG is why we have ES6 rest parameters

Please use ES6 for game.LOG: pwfisher@1a24cda

    game.LOG = (level, ...rest) => level < _log_level && console.log(...rest);

This is painful:

css3d-game/3d/js/engine.js

Line 798 in dc3ff4a

game.LOG = function ( a,b,c,d,e,f,g,h,i ) {

      game.LOG = function ( a,b,c,d,e,f,g,h,i ) {
        if (a > _log_level ) return ;

        var log = console.log;
        if (i !== undefined) { log (b,c,d,e,f,g,h,i); return ;}
        if (h !== undefined) { log (b,c,d,e,f,g,h); return ;}
        if (g !== undefined) { log (b,c,d,e,f,g); return ;}
        if (f !== undefined) { log (b,c,d,e,f); return ;}
        if (e !== undefined) { log (b,c,d,e); return ;}
        if (d !== undefined) { log (b,c,d); return ;}
        if (c !== undefined) { log (b, c ); return ;}
        
        log( b );
      };

Why not use ES6? It's 2020. ES6 is vanilla javascript. No need to restrict yourself an archaic style.

Sticking with ES5 only gets you IE11 support and you can get that with webpack if you need it for some reason, and still author ES6 for more readable (better) code.

If you want to be readable:

      // level = priority rank (0 = error, 1 = alert, 2 = warning, 3 = info, 4 = debug)
      // _log_level = verbosity setting
      game.LOG = function (level, ...rest) {
        if (level < _log_level) console.log(...rest);
      };

ES6 and formatting

Automate code formatting. Use Prettier with VSCode: pwfisher@e3a515b

Multiline interpolated string wanted:

css3d-game/3d/js/engine.js

Line 729 in dc3ff4a

 html = '<div><div class="inl-bl"><span onanimationend="GAME.ACTIONS.nextLine(this,' + line_delay + ')" class="' + clss + extra_class + '">' + target_txt + '</span></div></div>'; 

Key/property shorthand wanted:

css3d-game/3d/js/level.js

Line 956 in dc3ff4a

 var ASM_stdlib = { Math: Math, Float64Array: Float64Array, Uint8Array: Uint8Array, Uint32Array: Uint32Array }; 

const ASM_stdlib = { Math, Float64Array, Uint8Array, Uint32Array };

pkalogiros / css3d-game Goto Github PK

css3d-game's People

Contributors

Stargazers

Watchers

Forkers

css3d-game's Issues

Typo in this line (where instead of were)

Shabby torch did not seem clickable

Minor typo

[style] game.LOG is why we have ES6 rest parameters

ES6 and formatting

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent