pjungkamp / yoga9-linux Goto Github PK

Thanks for these patches.
The WMI driver emits KEY_UNKNOWN if you press the fn+esc the second time.
The

+	{ KE_IGNORE,	0x03 },

fixes that.

Just received a new 2024 Yoga 9i 14IMH9, and everything is working on Linux except the bass speakers. Applying the kernel parameter options snd-sof-intel-hda-common hda_model=alc287-yoga9-bass-spk-pin did not resolve the issue.

Upon further investigation, it looks like this new model uses a Cirrus CSC3551 amplifier, which seems to require some patching for it to work on Linux.

Posting here for broader visibility. I've got a patch written with @PJungkamp's help to get the keyboard backlight patch working. I've tested it on my 14ARB7, but that behaves slightly differently.

What I'm looking is for anyone with a modern Yoga laptop, where the keyboard has off / low / high / auto modes, to test my kernel patch on their system. /sys/class/leds/platform::kbd_backlight/brightness should report the current brightness (0->2), and writing 0->2 to it should set the brightness accordingly.

Patch: v5-0001-platform-x86-ideapad-laptop-Add-support-for-keyboard.patch.txt

If someone can verify it works for keyboard backlights with an auto mode, I'll send it upstream, hopefully in time for Linux 6.6.

Thanks!

I'm opening this issue just for reference (in case somebody with the same device is looking for a solution).

I've tried to force the bass speaker fix on my device (Yoga 7 Gen 7 AMD (14ARB7)), but it didn't yield any effect:

# rebooted after this change
#
sudo tee /etc/modprobe.d/snd.conf <<CONF
options snd_intel_dspcfg dsp_driver=1
options snd_hda_intel model=alc287-yoga9-bass-spk-pin
CONF

This has been tested on a v6.0-rc7 kernel, without any patch (actually, I've applied the mic fix, which I think should not be in conflict), since I've seen that the patches in this repository have been upstreamed.

Hello Philipp,
Thank you very much for putting together the necessary fixes in patches!
I've just received my Yoga and I'm trying to fix all problems.
I don't have enough experience in linux to be sure that I doing that correctly, so can you update your readme and write some useful information about how to patch linux kernel in our case ?
Thanks!

fellow yoga user; i've noticed that enabling these options in the kernel modules disables microphone. Is this also occurring for you?

It seems that the sound patch for Yoga 9 works also for Yoga 7 14IAL7, only the device ID needs to be added (0x17aa, 0x3869). I tested it on my Yoga 7 as a DKMS module and it works (Arch Linux 5.19). There was no need to blacklist any modules or pass any module options, only sof-firmware package needed to be installed.

Would you be ok with me publishing the DMKS module on GitHub as an interim solution, until your patches make it to next kernel version? Or alternatively would you be willing to add DKMS packaging to this repo (anything to avoid recompiling the kernel on every update :) )?

Thank you very much for providing these patches.

Thank you for starting this fix/doc

I would like to know if I need to install a specific package before applying this patch?
Could you please help me?
I'm trying to apply the 0007-ALSA-hda-realtek-Add-quirk-for-Yoga-devices.patch I have the following message:

can't find file to patch at input line 18
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From 85136309b3efe5a54167cdfbb9f1a3abab116929 Mon Sep 17 00:00:00 2001
|From: Philipp Jungkamp <[email protected]>
|Date: Sat, 30 Jul 2022 21:33:16 +0200
|Subject: [PATCH 7/9] ALSA: hda/realtek: Add quirk for Yoga devices
|
|The Lenovo Yoga 7 16IAP7 uses the same ALC287 codec setup as the
|Lenovo Yoga 9 14IAP7.
|
|Signed-off-by: Philipp Jungkamp <[email protected]>
|---
| sound/pci/hda/patch_realtek.c | 1 +
| 1 file changed, 1 insertion(+)
|
|diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
|index 6c4e9994d99c..94768ce71ece 100644
|--- a/sound/pci/hda/patch_realtek.c
|+++ b/sound/pci/hda/patch_realtek.c
--------------------------

OS: EndeavourOS Linux x86_64
Host: 82QE Yoga 7 14IAL7
Kernel: 5.19.6-arch1-1

Thanks again! :)

Hi,
I just bought a Yoga Pro 7 14AHP9 which has a Realtek ALC287 controller. Everything works just fine sound-wise (maybe thanks to your work?) except for one small detail: the speaker volume control has no effect, the effective volume remains at 100% regardless of the set value EDIT: the volume goes from 0 to 100% in the first few pixels of the slider.
Headphone volume control works fine.

I tried setting the volume via pipewire (-pulse) and directly in alsamixer. The PCM volume slider does control the volume, but not the Speaker slider.

By any chance do you have any insight on this small issue?

alsa-info.txt

Hi.

I really appreciate your work. I have the same issue with the speakers on the 2023 model of the Pro 9. I already tried to fix it by applying https://github.com/PJungkamp/yoga9-linux/blob/main/config/etc/modprobe.d/snd.conf. But apparently, the speakers are wired a bit differently.

What steps do you recommend to get this working? I'm asking because you already fixed it before the fix was applied to the mainline.

[qdrop@qdrop-fedora-pro9i ~]$ neofetch
             .',;::::;,'.                qdrop@qdrop-fedora-pro9i 
         .';:cccccccccccc:;,.            ------------------------ 
      .;cccccccccccccccccccccc;.         OS: Fedora Linux 38 (Workstation Edition) x86_64 
    .:cccccccccccccccccccccccccc:.       Host: 83BU Yoga Pro 9 14IRP8 
  .;ccccccccccccc;.:dddl:.;ccccccc;.     Kernel: 6.2.14-300.fc38.x86_64 
 .:ccccccccccccc;OWMKOOXMWd;ccccccc:.    Uptime: 26 mins 
.:ccccccccccccc;KMMc;cc;xMMc:ccccccc:.   Packages: 2129 (rpm), 32 (flatpak) 
,cccccccccccccc;MMM.;cc;;WW::cccccccc,   Shell: bash 5.2.15 
:cccccccccccccc;MMM.;cccccccccccccccc:   Resolution: 3440x1440 
:ccccccc;oxOOOo;MMM0OOk.;cccccccccccc:   DE: GNOME 44.1 
cccccc:0MMKxdd:;MMMkddc.;cccccccccccc;   WM: Mutter 
ccccc:XM0';cccc;MMM.;cccccccccccccccc'   WM Theme: Adwaita 
ccccc;MMo;ccccc;MMW.;ccccccccccccccc;    Theme: Adwaita [GTK2/3] 
ccccc;0MNc.ccc.xMMd:ccccccccccccccc;     Icons: Adwaita [GTK2/3] 
cccccc;dNMWXXXWM0::cccccccccccccc:,      Terminal: gnome-terminal 
cccccccc;.:odl:.;cccccccccccccc:,.       CPU: 13th Gen Intel i9-13905H (20) @ 5.200GHz 
:cccccccccccccccccccccccccccc:'.         GPU: NVIDIA GeForce RTX 4060 Max-Q / Mobile 
.:cccccccccccccccccccccc:;,..            GPU: Intel Raptor Lake-P [Iris Xe Graphics] 
  '::cccccccccccccc::;,.                 Memory: 5412MiB / 31818MiB 

New custom compilation of linux-xanmod-edge with all 7 patches work on 16IAP7
I updated my github for that, later i will update mainline kernel too
I hope all them will become modules very soon in coming kernel release
Thank you!

If you are using the newest Gen7 version of this laptop, adding the file is a necessary change to get speakers to work.
/etc/modprobe.d/snd.conf

...........

I took the https://github.com/PJungkamp/yoga9-linux/blob/main/kernel-patches/0005-Add-IdeaPad-Usage-Mode-driver.patch and made it a dkms module and installed it, after that I could see the usage mode device in evtest but it did not emit any events on switching device modes and hence gnome also did not detect when switching to tablet mode.
I had submitted the module to arch aur at https://aur.archlinux.org/packages/ideapad-wmi-usage-mode-dkms-git, just an fyi.