pjentsch / myschedule Goto Github PK

Now that ScriptingJob is generic with only jdk6 dep, the Groovy lib maybe 
remove. Remove it will shrink package size and less dependency. 

The "WEB-INF/jsp" name would be a better fit for JSP specific. We might able to 
explore other views such as Freemarker.

The class name TriggerUtils is already been used in org.quartz package, so 
renaming this class would avoid name conflict.

Task

Configure maven release plugin to use Hg and automate the release tag process.

There is already a flag to ignore init(), but we can improve and also perform 
similar check on start() method. This will allow the scheduler to have a chance 
to fail during webapp startup. Else myschedule.war will not be able to startup!

Need to improve the ScriptingJob to allow this.

Create screenshot for 2.1.0

ScriptingJob throws error when result is null

Currently when there is an application wide exception thrown, the error page is 
missing the menu navigation.

Add PAUSE/UNPAUSE on JOB list page

myschedule-1.x - for quartz-1.8.x work with jquery UI.
myschedule-2.1.x - for quartz-2.1.0 work with jquery UI.
myschedule-2.2.x - for quartz-2.x work with Vaadin UI.

$ scripts/run-java myschedule.quartz.extra.SchedulerMain 
scripts/quartz.properties.scripting
2011-10-20 07:34:52,461 INFO  main org.quartz.impl.StdSchedulerFactory:1157| 
Using default implementation for ThreadExecutor
2011-10-20 07:34:52,484 INFO  main org.quartz.core.SchedulerSignalerImpl:61| 
Initialized Scheduler Signaller of type: class 
org.quartz.core.SchedulerSignalerImpl
2011-10-20 07:34:52,485 INFO  main org.quartz.core.QuartzScheduler:243| Quartz 
Scheduler v.2.2.0-SNAPSHOT created.
2011-10-20 07:34:52,489 DEBUG main 
myschedule.quartz.extra.ScriptingSchedulerPlugin:86| Initializing scripting 
plugin MyScriptingPlugin with ScriptEngine Groovy
2011-10-20 07:34:52,579 DEBUG main 
myschedule.quartz.extra.ScriptingSchedulerPlugin:96| Running initialize script 
init-samples.groovy
2011-10-20 07:34:52,580 INFO  main org.quartz.core.QuartzScheduler:653| 
Scheduler QuartzScheduler_$_NON_CLUSTERED shutting down.
2011-10-20 07:34:52,581 INFO  main org.quartz.core.QuartzScheduler:572| 
Scheduler QuartzScheduler_$_NON_CLUSTERED paused.
2011-10-20 07:34:52,582 DEBUG main org.quartz.simpl.SimpleThreadPool:327| 
Shutting down threadpool...
2011-10-20 07:34:52,583 DEBUG main org.quartz.simpl.SimpleThreadPool:381| 
Shutdown of threadpool complete.
2011-10-20 07:34:52,584 INFO  main org.quartz.core.QuartzScheduler:725| 
Scheduler QuartzScheduler_$_NON_CLUSTERED shutdown complete.
Exception in thread "main" java.lang.NullPointerException
        at myschedule.quartz.extra.ScriptingSchedulerPlugin.runScript(ScriptingSchedulerPlugin.java:128)
        at myschedule.quartz.extra.ScriptingSchedulerPlugin.initialize(ScriptingSchedulerPlugin.java:97)
        at org.quartz.impl.StdSchedulerFactory.instantiate(StdSchedulerFactory.java:1278)
        at org.quartz.impl.StdSchedulerFactory.getScheduler(StdSchedulerFactory.java:1484)
        at myschedule.quartz.extra.SchedulerTemplate.<init>(SchedulerTemplate.java:72)
        at myschedule.quartz.extra.SchedulerMain.main(SchedulerMain.java:21)
2011-10-20 07:34:52,967 DEBUG QuartzScheduler_Worker-2 
org.quartz.simpl.SimpleThreadPool:596| WorkerThread is shut down.
2011-10-20 07:34:52,967 DEBUG QuartzScheduler_Worker-3 
org.quartz.simpl.SimpleThreadPool:596| WorkerThread is shut down.
2011-10-20 07:34:52,967 DEBUG QuartzScheduler_Worker-4 
org.quartz.simpl.SimpleThreadPool:596| WorkerThread is shut down.
2011-10-20 07:34:52,967 DEBUG QuartzScheduler_Worker-1 
org.quartz.simpl.SimpleThreadPool:596| WorkerThread is shut down.
2011-10-20 07:34:52,967 DEBUG QuartzScheduler_Worker-5 
org.quartz.simpl.SimpleThreadPool:596| WorkerThread is shut down.

JobDetail page is not working on 1.5.0

Instead of hardcoded with groovy quartz job, we should make it generic engough 
to use JDK's ScriptEngine interface. This way user may switch to different 
engine by simply set a property in the job data map. Use JRuby instead of 
Groovy for example.

JDK comes with a default Rhino (JavaScript) script engine already, so this 
should be very portable and flexible.

The following error occur when running Tmocat7. This page is working when 
running under mvn tomcat:run (tomcat 6) though.

{{{
org.apache.jasper.JasperException: /WEB-INF/views/job/trigger-detail.inc (line: 
26, column: 1) "${ 'org.quartz.SimpleTrigger' == trigger.class.name }" contains 
invalid expression(s): javax.el.ELException: Failed to parse the expression [${ 
'org.quartz.SimpleTrigger' == trigger.class.name }]
    at org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:42)
    at org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:408)
    at org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:199)
    at org.apache.jasper.compiler.Validator$ValidateVisitor.checkXmlAttributes(Validator.java:1218)
    at org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:870)
    at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1539)
    at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376)
    at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428)
    at org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:889)
    at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1539)
    at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376)
    at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428)
    at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2434)
    at org.apache.jasper.compiler.Node$Root.accept(Node.java:475)
    at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376)
    at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428)
    at org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:530)
    at org.apache.jasper.compiler.Node$IncludeDirective.accept(Node.java:639)
    at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376)
    at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428)
    at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2434)
    at org.apache.jasper.compiler.Node$Root.accept(Node.java:475)
    at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376)
    at org.apache.jasper.compiler.Validator.validateExDirectives(Validator.java:1790)
    at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:217)
    at org.apache.jasper.compiler.Compiler.compile(Compiler.java:373)
    at org.apache.jasper.compiler.Compiler.compile(Compiler.java:353)
    at org.apache.jasper.compiler.Compiler.compile(Compiler.java:340)
    at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:644)
    at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:358)
    at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:389)
    at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:333)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:684)
    at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:471)
    at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:402)
    at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:329)
    at org.springframework.web.servlet.view.InternalResourceView.renderMergedOutputModel(InternalResourceView.java:238)
    at org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:250)
    at org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1047)
    at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:817)
    at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:719)
    at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
    at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:549)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:185)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:151)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:269)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:662)
}}}

Tested 2.1.1 on Tomcat7.

Create something similar to Scheduler config examples that load into the 
scripting textarea for each type of triggers that Quartz supports.

We need to backport what we have in 2.x into 1.x.

The config properties example is not shown in javadoc 
http://static.myschedule.googlecode.com/hg/myschedule-2.x/apidocs/index.html

The backend services are too cluttered and complicated. It can be simplier and 
with fewer classes.

There are many areas that can be improved with jquery UI besides the data 
table. 

We should create a new profile that contains groovy, slf4j impl and DB drivers 
for dev and testing.

1. Need to remove classes already moved to quartz-extra.
2. Need to update web pkg to use new quartz-extra classes.

The new quartz-extra classes has API change, so it will break myschedule-web. 
Some refactoring is needed.

We should make it stick. Better yet, use the user session to keep it until 
expire.

When displaying scheduler that failed to startup, the dashboard need to display 
the error message in a user friendly way.

7 warnings
[WARNING] Javadoc Warnings
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\XmlJobLoader.java:55: warning - @return tag has no 
arguments.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\XmlJobLoader.java:64: warning - @return tag has no 
arguments.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\util\ProcessUtils.java:45: warning - @throw is an unknown 
tag.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\util\ProcessUtils.java:105: warning - @throw is an unknown 
tag.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\util\ProcessUtils.java:135: warning - @throw is an unknown 
tag.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\util\ProcessUtils.java:201: warning - @throw is an unknown 
tag.
[WARNING] 
C:\projects\myschedule\target\checkout\myschedule-quartz-extra\src\main\java\mys
chedule\quartz\extra\util\ProcessUtils.java:284: warning - @throw is an unknown 
tag.
[INFO] ------------------------------------------------------------------------

Need unit and integration tests for quartz-extra module

For next version, consider using vaadin UI library.

Currently the template class is not wrapping all methods.

Same problem with ${ item.class.name } is failing on Tomcat7.

The web app is simple enough to not use spring. Remove it will shrink package 
size and less dependency. It also would deploy more reliably, easier on 
different app servers.

We need a better and cleaner class to represent each view in web. This will 
eliminate some codes in JSP.

The SchedulerTemplate methods in the two branch are not in sync. Though the 
implementation are different, but at least the method counts and main signature 
should be sync up.

The failure is due to groovy-1.8.0.jar loading by JBoss6. Groovy have fixed 
this issue in 1.8.1 already. So the easiest workaround is to upgrade this 
library.

We will upgrade this in myschedule project on next release.

Will plan to add Derby DB as part of default dist.

This will prep to run job history plugin in future.

Will go ahead remove prepare MySQL driver from dist.

This should really be a Quartz Jira issue as enhancement.

When saving a RMI client scheduler config, this could lead to scheduler load 
failure if RMI server is down. And the dashboard shows error because of this.

The current quartz built-in JobHistoryPlugin is not very useful. It would be 
nice to have a plugin to record job history into database instead.

When deploying myschedule-2.3.0-SNAPSHOT.war in Tomcat server. We add 
slf4j-*.jar, and log4j*.jar into TOMCAT/lib to enable logging. But when 
starting up, we get this error (you will find the detail exception stack not on 
console, but in log file under TOMCAT/logs/localhost*.log

{{{
Oct 23, 2011 1:31:50 PM org.apache.catalina.core.StandardContext listenerStart
SEVERE: Error configuring application listener of class 
myschedule.web.WebAppContextListener
java.lang.LinkageError: loader constraint violation: when resolving method 
"org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;"
 the class loader (instance of org/apache/catalina/loader/WebappClassLoader) of 
the current class, org/slf4j/LoggerFactory, and the class loader (instance of 
org/apache/catalina/loader/StandardClassLoader) for resolved class, 
org/slf4j/impl/StaticLoggerBinder, have different Class objects for the type 
taticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory; used in the 
signature
    at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:284)
    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:252)
    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:265)
    at myschedule.web.WebAppContextListener.<init>(WebAppContextListener.java:17)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:525)
    at java.lang.Class.newInstance0(Class.java:372)
    at java.lang.Class.newInstance(Class.java:325)
    at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:119)
    at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4660)
    at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5226)
    at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5221)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
    at java.util.concurrent.FutureTask.run(FutureTask.java:166)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
    at java.lang.Thread.run(Thread.java:722)
}}}

There are several pages that has <%%> code block. It will be cleaner to remove 
these.

We can refactor out GroovyJob, the XmlLoader extension into a reusable jar 
under a maven sub-module "quartz-extra".

This is so user may use this extra jar without myschedule package.

We already using "schedulerTemplate" variable, so "scheduler" is more 
consistent than "quartzScheduler".

We can further simplify the table on job listing. Make the table width smaller 
and let user drill down instead of show too much.

Some icons instead of words for Action links would be nice.

The dashboard view can use some icons for action too. And we should add 
"Remove" action link to each scheduler table row instead of separate page with 
drop down.

The link after modify scheduler config on dashboard view will not work. It 
gives exception.

It looks like the link configId parameter is empty!

See summary

Need unit and integration tests for myschedule-web module

Groovy and JRuby are popular Script Engine, so add these two language examples 
would be nice.

This also give MySchedule app a chance to test working with other script 
engines.

Clean up hg branchings and just use 'default' and 'myschedule-1.x'.

 * New quartz extra user guide.
 * Update script examples
 * Update release notes - use Issues list