Aici o sa trebuiasca adaugat totul pentru a avea acea pagina comparativa live vs pro + elementele din customizer.

To-dos

• Add "About Julia Lite" Section in Appearance
• • Add Getting Started Page
• • Add Useful Plugins Page
• • Add Support Page
• • Add Free VS Pro Page
• • Add "Pro" Badges from CSS
• Add Sections and Links to Customify
• Check copy

Resources

• Issue Silk Lite

Check if we can reach all links by tabbing.

Ref: https://make.wordpress.org/themes/2019/08/03/planning-for-keyboard-navigation/

Starting from WordPress 5.2 a new function is added – wp_body_open() – that is used to trigger a wp_body_open action. The intention of this action is to allow people to add things – like a <script> tag – directly inside the body of a page.

Themes should start adding this hook to their themes as soon as 5.2 releases. The function should be placed inside of the tag immediately after it is opened.

More info: https://make.wordpress.org/themes/2019/03/29/addition-of-new-wp_body_open-hook/

For users that are navigating using only keyboard or screen readers, add a skip link to navigate directly to the main content.

Resource: https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip-links/

Since Julia Lite is fully compatible with Gutenberg, I suggest moving all the demo content to Gutenberg blocks.

Am discutat cu acosmin, parte din echipa de review-uri (Team Lead), despre acceptarea in programul Trusted Authors si ce putem face sa ajungem si noi acolo.

Astfel am aflat ca nu am trecut "examenul" cu Hive si ne-a sugerat sa faca el un pre-review la tema din queue (Julia Lite) si dupa ce rezolvam probleme sa o propunem din nou pentru programul Trusted Authors.

Am discutat cu @raduconst sa notez aici ce a gasit la Julia (sunt cuvintele review-urului pana la "→"):

• Momentan tot primesc chestia asta Notice: Pixelgrade_Config::validateCustomizerSectionConfigDefaults was called incorrectly. You need to define a default value for the following Customizer option: header_section > options > header_position. Use this filter: pixelgrade_header_customify_section_options Please see Debugging in WordPress for more information. in ...\wordpress\wp-includes\functions.php on line 4161
• Pexels License nu este compatibila cu GPL. Poti gasi pe pexels.com si poze unde la licenta este trecut CC0 → sa verificam daca pozele alese sunt CC0, daca nu, sa alegem altele
• din readme lipsesec licentele pentru fisierele din fonts
• nu stiu exact ce dependencies aveti pentru partea de JS 🙂 daca este ceva 3rd party, trebuie trecut in readme
• admin_url trebuie escaped 🙂 pe unde e folosit
• in widgets, optiuni precum Selected Posts - Available on PRO version nu sunt ok daca nu merg. Poti pune un mesaj (in widget) ca sunt posibile cu versiunea pro → sugerez sa scoatem astfel de optiuni si sa le inlocuim cu un mesaj
• Pixelgrade: Promo Box este considerat content creation. In loc de field-uri poti pune un select pentru o pagina, Button text si url sunt ok → probabil ar trebui sa scoatem de tot widget-ul asta din varianta lite
• exista vreun check pentru versiunea PHP? pai 🙂 sunt cateva probleme cu Theme Sniffer, trebuie sa rezolvi erorile. O sa fie nevoie de ceva in genul asta: https://github.com/acosmin/neville/blob/master/inc/back-compat.php → sa incercam sa limitam tema sub o anumita versiune de PHP
• Sniffer-ul mai zice si ceva de The check has failed. This could happen due to running out of memory. Either reduce the file length or increase PHP memory.
• in readme sa adaugam licenta pentru ThemeIsle - About page class
• julia_sanitize_transparent_logo() nu e functie pentru sanitize :)
• theme url-ul nu poate fi demo... If the URI is a demo site, the content must be about the theme itself and not test data. (e optional) → pana facem prezentare pentru lite (nu landing page pentru upselling), sugerez sa scoatem acel url.

Nota: sa fiti atenti la queue, daca ajunge in primele 5, msg me

cc @vladolaru @oanafilip

Desi teoretic s-a facut remove la butonul de back to top in #6 , acesta inca apare, atat pe site: https://cl.ly/45af086e2a5a , cat si in screenshot-ul temei: https://cl.ly/db3b641b78ad

Aici e vorba de modificarea optiunilor la widget-urile Featured Posts si Grid Posts.

One of the lead reviewers from WordPress.org (@kafleg) encounter this error on their local Windows machine:

Fatal error: Uncaught UnexpectedValueException: DirectoryIterator::__construct(C:/xampp/htdocs/theme-review/wp-content/themes/julia-lite/C:/xampp/htdocs/theme-review/wp-content/themes/julia-lite/inc/specific,C:/xampp/htdocs/theme-review/wp-content/themes/julia-lite/C:/xampp/htdocs/theme-review/wp-content/themes/julia-lite/inc/specific): The filename, directory name, or volume label syntax is incorrect. (code: 123) in C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\components\base\inc\extras.php:459 Stack trace: #0 C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\components\base\inc\extras.php(459): DirectoryIterator->__construct('C:/xampp/htdocs...') #1 C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\inc\specific.php(12): pixelgrade_autoload_dir('C:/xampp/htdocs...') #2 C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\components\base\inc\extras.php(469): require_once('C:\xampp\htdocs...') #3 C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\functions.php(202): pixelgrade_aut in C:\xampp\htdocs\theme-review\wp-content\themes\julia-lite\components\base\inc\extras.php on line 459

@raduconst am instalat Julia Lite pe https://demos.pixelgrade.com/julia-lite/ — fiindca avem Customify pus pe "Network Enabled" cam strica stilurile. Poti sa te uiti tu sa resetezi stilurile?

Aici o sa am nevoie de ajutor la partea de copy dar revin cu un ping de indata ce am adaugat pagina.

Este vorba de pagina https://pixelgrade.com/themes/julia-lite cu prezentarea temei.

• Sa cream comparison table (Lite vs Pro) - este vorba de acel tabel din Dashboard → Appearance → About Julia Lite → Free VS PRO: https://cl.ly/341A2P2r1e21
• copy-ul pentru widget-urile disponibile doar in varianta Pro si pentru output-ul lor - in varianta Lite vor ramane doar doua widget-uri din cele opt ce sunt varianta PRO. Lista widget-urilor ce raman este aici. Practic, este vorba de un mesaj care sa apara in momentul in care un user adauga un widget dar acesta este valabil doar in varianta PRO, de genul asta: https://cl.ly/3P1V441c0Y1o
• copy-ul pentru sidebar-urile disponibile doar in varianta Pro si pentru output-ul lor - momentan sunt zone de sidebar care vor afisa widget-urile doar in varianta PRO. Trebuie schimbat textul pus de mine, temporar, aici: https://cl.ly/0x0q301W3p1X

Provide a standard notification to install our recommended plugin, Pixelgrade Assistant.

Este vorba de pagina https://pixelgrade.com/julia-lite-documentation/ doar ca pentru Hive Lite.

Aici trebuie folosita variabila sidebars_not_supported pentru a configura widget-urile PRO sa nu apara in varianta Lite.

We should provide limited access to the Style Manager system via the Customify plugin. Thus, our users will be able to have some flexibility in styling their site and also get a taste of what we can offer them.

While testing the latest update for Julia Lite with PHP8, I have encountered the following error:

Fatal error: Uncaught Error: Unknown named parameter $end_size in /Users/madalin/Local/julialite/app/public/wp-content/themes/julia-lite/components/base/blocks/class-CallbackBlock.php on line 116

To see this error, go to Settings > Reading, and on Your homepage displays make sure you use your latest posts.

Demo Julia Lite: https://demos.pixelgrade.com/julia-lite/

To-dos

• Duplicat demo de la Julia
• Instalat Tema
• Check Content

In urma review-ului de pe wordpress.org a fost semnalata urmatoarea problema:

ERROR: Detected possible use of Pixabay images. Use of Pixabay images is not permitted because their license is not GPL compatible. There are redistribution restrictions. This occured Jan 13, 2019. New themes are not allowed to use images from Pixabay. Existing themes are encouraged (but not required) to change their images.
https://pixabay.com/ro/alimente-fite-food-styling-blog-ul-2203732/
https://pixabay.com/ro/tabel-desert-cafea-tort-alimente-1589012/
https://pixabay.com/ro/mic-dejun-branza-farfurie-2151201/
https://pixabay.com/ro/magnolie-floare-prim%C4%83var%C4%83-flori-2179229/