[BUG] Error in backend module: "expires" is not set on the token about pxa_social_feed HOT 7 CLOSED

@dahaupt Thanks for the thorough research! I will look into this today 👍

from pxa_social_feed.

@dahaupt Good to hear! What will happen now is that every time the long-lived access token is used it gets refreshed. So no need for worrying about the data expiration.

from pxa_social_feed.

@MattiasNilsson That is a great improvement! 👍

from pxa_social_feed.

@MattiasNilsson Thanks for your fast response and patch!

Unfortunately, the patch does not fix the issue in my case. The response I get from the Facebook API misses the expires_in value for the long-lived access token:

Example response:

{
    "access_token":"xxxx",
    "token_type":"bearer"
}

Therefore, the hasExpired() check in Classes/Domain/Model/Token.php line 293 throws the mentioned error.

I found this stackoverflow question for the same issue, without any helpful answers, yet.

from pxa_social_feed.

Output of the Access Token Debugger of Facebook:
Type: User
Issued: 1603663895 (about a year ago)
Expires: Never
Data Access Expires: 1649535799 (in about 3 months)

If an expires_in field is not returned, it is safe to assume that it is a non-expiring token
(source)

So I guess we can not use the hasExpired() within isValidFacebookAccessToken().

from pxa_social_feed.

@dahaupt A new release have been done, can you verify that it works? https://github.com/pixelant/pxa_social_feed/releases/tag/3.0.3

from pxa_social_feed.

@MattiasNilsson It is working now. Thanks a lot! 🚀

If I understand the changed code correctly, it will always get a new long-lived access token. Is token expiration still a thing?

Furthermore, I noticed the data expiration of our long-lived token is 90 instead of 60 days. But as the docs state it is 60 days, we should not change it.

from pxa_social_feed.