pislagz / manycoins Goto Github PK

This is strongly because of the data partitioning into pages, as HTTP requests containing thousands of currencies would take ages to load. Thus, it's bad. It means certain currencies added to favorites can only be seen in the only favorites view when an appropriate page was selected, page which said currencies are currently displayed on.

Rendering of said favorites should be changed (16th line of the TableRow.js)¹, such that the ternary operator outputs the results of another GET request (key: ids, value: list of favorites), so all favorites are displayed no matter which page does the currency show up in the all currencies view.

¹ said line, includes method to be changed:
∙∙∙if (props.onlyFavorites ? props.favorites.includes(item.id) : true) { ∙∙∙

It just needs to be done, gql requests will ensure better data management than manual sorting of the data received with Restful API.

In. so. many. ways.
There's nothing more to that, the thing just needs to be done asap.

Using Pagination component's elements to switch pages (GET request's offset key) is only working after additional page refresh. That's possibly caused by poor logic execution of requests switching.