Comments (5)
enobufs
commented on July 23, 2024
Would this happen with pion/[email protected]?
from ice.
enobufs
commented on July 23, 2024
This one says, *Agent is is nil.
github.com/pion/ice.(*Agent).ok(0x0, 0xc0004de350, 0x4446880)
/Users/max/go/pkg/mod/github.com/pion/[email protected]/agent.go:153 +0x22
which is here:
func (a *Agent) ok() error {
select {
case <-a.done: // <----------------------------- here
return a.getErr()
default:
}
return nil
}I can not find in pion/ice a code that sets the agent to nil.
I believe an upper layer is calling a nil agent... (just my guess)
from ice.
enobufs
commented on July 23, 2024
No sure if related but I have just saw a CI build error.
I will look into this.
=== RUN TestRelayOnlyConnection
ice ERROR: 2019/07/17 07:15:29 error processing checkCandidatesTimeout handler the agent is closed
goroutine profile: total 36
12 @ 0x45855f 0x453aaa 0x453096 0x4b3ff5 0x4b67a5 0x4b6781 0x5f6ee0 0x640d61 0x647e43 0x647e24 0x64f276 0x4867d1
# 0x453095 internal/poll.runtime_pollWait+0x55 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/netpoll.go:182
# 0x4b3ff4 internal/poll.(*pollDesc).wait+0xe4 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:87
# 0x4b67a4 internal/poll.(*pollDesc).waitRead+0x144 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:92
# 0x4b6780 internal/poll.(*FD).RawRead+0x120 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_unix.go:534
# 0x5f6edf net.(*rawConn).Read+0x6f /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/rawconn.go:43
# 0x640d60 golang.org/x/net/internal/socket.(*Conn).recvMsg+0x3d0 /home/travis/gopath/pkg/mod/golang.org/x/[email protected]/internal/socket/rawconn_msg.go:31
# 0x647e42 golang.org/x/net/internal/socket.(*Conn).RecvMsg+0x212 /home/travis/gopath/pkg/mod/golang.org/x/[email protected]/internal/socket/socket.go:255
# 0x647e23 golang.org/x/net/ipv4.(*payloadHandler).ReadFrom+0x1f3 /home/travis/gopath/pkg/mod/golang.org/x/[email protected]/ipv4/payload_cmsg.go:31
# 0x64f275 github.com/pion/mdns.(*Conn).start+0x155 /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/conn.go:249
7 @ 0x45855f 0x468eab 0x86c462 0x4867d1
# 0x86c461 github.com/pion/ice.(*Agent).taskLoop+0x481 /home/travis/gopath/src/github.com/pion/ice/agent.go:589
6 @ 0x45855f 0x468eab 0x86c227 0x4867d1
# 0x86c226 github.com/pion/ice.(*Agent).taskLoop+0x246 /home/travis/gopath/src/github.com/pion/ice/agent.go:576
4 @ 0x45855f 0x453aaa 0x453096 0x4b3ff5 0x4b5374 0x4b534a 0x5de2aa 0x6007de 0x5fe636 0x87398a 0x4867d1
# 0x453095 internal/poll.runtime_pollWait+0x55 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/netpoll.go:182
# 0x4b3ff4 internal/poll.(*pollDesc).wait+0xe4 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:87
# 0x4b5373 internal/poll.(*pollDesc).waitRead+0x213 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:92
# 0x4b5349 internal/poll.(*FD).ReadFrom+0x1e9 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_unix.go:219
# 0x5de2a9 net.(*netFD).readFrom+0x79 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/fd_unix.go:208
# 0x6007dd net.(*UDPConn).readFrom+0x8d /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock_posix.go:47
# 0x5fe635 net.(*UDPConn).ReadFrom+0x95 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock.go:121
# 0x873989 github.com/pion/ice.(*candidateBase).recvLoop+0x209 /home/travis/gopath/src/github.com/pion/ice/candidate_base.go:93
1 @ 0x45855f 0x42e969 0x42e93f 0x42e6db 0x544ea3 0x54ae09 0x544794 0x546df4 0x54564c 0x8b69f5 0x45814c 0x4867d1
# 0x544ea2 testing.(*T).Run+0x692 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:917
# 0x54ae08 testing.runTests.func1+0xa8 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:1157
# 0x544793 testing.tRunner+0x163 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:865
# 0x546df3 testing.runTests+0x523 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:1155
# 0x54564b testing.(*M).Run+0x2eb /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:1072
# 0x8b69f4 main.main+0x344 _testmain.go:210
# 0x45814b runtime.main+0x20b /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/proc.go:200
1 @ 0x45855f 0x42e969 0x42e93f 0x42e6db 0x6b47e4 0x6b4799 0x6b309e 0x87cc62 0x87a555 0x86946d 0x891035 0x544794 0x4867d1
# 0x6b47e3 github.com/pion/turn/internal/client.(*Transaction).WaitForResult+0x823 /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/internal/client/transaction.go:91
# 0x6b4798 github.com/pion/turn.(*Client).PerformTransaction+0x7d8 /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/client.go:358
# 0x6b309d github.com/pion/turn.(*Client).Allocate+0x52d /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/client.go:251
# 0x87cc61 github.com/pion/ice.(*Agent).gatherCandidatesRelay+0x511 /home/travis/gopath/src/github.com/pion/ice/gather.go:334
# 0x87a554 github.com/pion/ice.(*Agent).gatherCandidates+0x2a4 /home/travis/gopath/src/github.com/pion/ice/gather.go:143
# 0x86946c github.com/pion/ice.NewAgent+0x172c /home/travis/gopath/src/github.com/pion/ice/agent.go:389
# 0x891034 github.com/pion/ice.TestRelayOnlyConnection+0x5e4 /home/travis/gopath/src/github.com/pion/ice/candidate_relay_test.go:58
# 0x544793 testing.tRunner+0x163 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/testing/testing.go:865
1 @ 0x45855f 0x453aaa 0x453096 0x4b3ff5 0x4b5374 0x4b534a 0x5de2aa 0x6007de 0x5fe636 0x6c215d 0x4867d1
# 0x453095 internal/poll.runtime_pollWait+0x55 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/netpoll.go:182
# 0x4b3ff4 internal/poll.(*pollDesc).wait+0xe4 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:87
# 0x4b5373 internal/poll.(*pollDesc).waitRead+0x213 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:92
# 0x4b5349 internal/poll.(*FD).ReadFrom+0x1e9 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_unix.go:219
# 0x5de2a9 net.(*netFD).readFrom+0x79 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/fd_unix.go:208
# 0x6007dd net.(*UDPConn).readFrom+0x8d /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock_posix.go:47
# 0x5fe635 net.(*UDPConn).ReadFrom+0x95 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock.go:121
# 0x6c215c github.com/pion/turn.(*Client).Listen.func1+0x9c /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/client.go:167
1 @ 0x45855f 0x453aaa 0x453096 0x4b3ff5 0x4b5374 0x4b534a 0x5de2aa 0x6007de 0x5fe636 0x6c2483 0x4867d1
# 0x453095 internal/poll.runtime_pollWait+0x55 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/netpoll.go:182
# 0x4b3ff4 internal/poll.(*pollDesc).wait+0xe4 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:87
# 0x4b5373 internal/poll.(*pollDesc).waitRead+0x213 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_poll_runtime.go:92
# 0x4b5349 internal/poll.(*FD).ReadFrom+0x1e9 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/internal/poll/fd_unix.go:219
# 0x5de2a9 net.(*netFD).readFrom+0x79 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/fd_unix.go:208
# 0x6007dd net.(*UDPConn).readFrom+0x8d /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock_posix.go:47
# 0x5fe635 net.(*UDPConn).ReadFrom+0x95 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/net/udpsock.go:121
# 0x6c2482 github.com/pion/turn.(*Server).listen.func1+0x92 /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/server.go:229
1 @ 0x45855f 0x468eab 0x86beaa 0x86e584 0x8a2935 0x86c4a4 0x4867d1
# 0x86bea9 github.com/pion/ice.(*Agent).run+0x189 /home/travis/gopath/src/github.com/pion/ice/agent.go:565
# 0x86e583 github.com/pion/ice.(*Agent).Close+0x103 /home/travis/gopath/src/github.com/pion/ice/agent.go:749
# 0x8a2934 github.com/pion/ice.TestHandlePeerReflexive.func1.1+0xab4 /home/travis/gopath/src/github.com/pion/ice/agent_test.go:279
# 0x86c4a3 github.com/pion/ice.(*Agent).taskLoop+0x4c3 /home/travis/gopath/src/github.com/pion/ice/agent.go:592
1 @ 0x45855f 0x468eab 0x86beaa 0x86e584 0x8a3126 0x86c4a4 0x4867d1
# 0x86bea9 github.com/pion/ice.(*Agent).run+0x189 /home/travis/gopath/src/github.com/pion/ice/agent.go:565
# 0x86e583 github.com/pion/ice.(*Agent).Close+0x103 /home/travis/gopath/src/github.com/pion/ice/agent.go:749
# 0x8a3125 github.com/pion/ice.TestHandlePeerReflexive.func2.1+0x335 /home/travis/gopath/src/github.com/pion/ice/agent_test.go:310
# 0x86c4a3 github.com/pion/ice.(*Agent).taskLoop+0x4c3 /home/travis/gopath/src/github.com/pion/ice/agent.go:592
1 @ 0x5b209e 0x5b1e6a 0x5add1c 0x6c8497 0x4867d1
# 0x5b209d runtime/pprof.writeRuntimeProfile+0x9d /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/pprof/pprof.go:708
# 0x5b1e69 runtime/pprof.writeGoroutine+0xc9 /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/pprof/pprof.go:670
# 0x5add1b runtime/pprof.(*Profile).WriteTo+0x4fb /home/travis/.gimme/versions/go1.12.7.linux.amd64/src/runtime/pprof/pprof.go:329
# 0x6c8496 github.com/pion/transport/test.TimeOut.func1+0x96 /home/travis/gopath/pkg/mod/github.com/pion/[email protected]/test/util.go:18
panic: timeout
from ice.
enobufs
commented on July 23, 2024
@maxhawkins Build error I saw was caused by a bug in the new pion/ice. Once it passes the review, I will tag it as v0.5.2. Hopefully, you could try it again! (see #81)
from ice.
Sean-Der
commented on July 23, 2024
This seems to be an issue with the caller, closing.
from ice.
Related Issues (20)
- TestAcceptAggressiveNomination failed in CI HOT 2
- Connection failure when listening on multiple interfaces and overriding host candidate HOT 5
- Connection upgrade HOT 3
- Remove invalidTCPMux
- Rename Agent.startOnConnectionStateChangeRoutine() to Agent.startRoutines() HOT 1
- Simplify Agent.updateConnectionState() HOT 1
- Reenable IPv6 UDPMux tests in i386
- Active TCP candidates? HOT 7
- Support server reflexive TCP candidate type HOT 13
- Fix type of CandidatePairState enum
- TestAgentActiveTCP test is failing due to data race
- Active TCP performs network operations in main thread HOT 7
- Connection failing to TCP candidate when listening on multiple interfaces using `MultiTCPMux` and `NAT1To1IPs` HOT 5
- Noisy warnings if TURN/STUN host is not reachable via IPv6
- Panic when adding candidate HOT 5
- bug(log): webrtc using ice will print wrong log HOT 1
- ice v2 depends on transport v2.2.2, which had a breaking change HOT 1
- Candidate type is not changed from peer-reflexive to host HOT 1
- Allow users to pass custom 'CandidateSelectorControlling` and `CandidateSelectorControlled` HOT 3
- ConnectionState changes may be reported incorrectly HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ice.