Comments (4)
Sean-Der
commented on August 26, 2024
Great find @sirzooro!
I think we need to keep the goroutine, but deliver the events in order. If we drop the goroutine the user can block our main thread.
Maybe we can internally have a buffered channel and have a goroutine deliver them to the user?
from ice.
Sean-Der
commented on August 26, 2024
If you are interested in implementing this I would love to work with you on it!
from ice.
sirzooro
commented on August 26, 2024
Yes, I can create PR for this.
connectionStateRoutine is started in separate goroutine, so adding buffer to chanState should be enough. Probably 10 entries would be enough.
BTW, chanCandidate and chanCandidatePair channels also do not have buffers - adding buffers of size 10 and 2 respectively probably would help them too.
from ice.
Sean-Der
commented on August 26, 2024
great! Totally agree with that.
Could you write a test that blocks the callback with something long running? Just to confirm we aren't introducing a behavior change?
from ice.
Related Issues (20)
- Active TCP candidates? HOT 7
- Support server reflexive TCP candidate type HOT 13
- Fix type of CandidatePairState enum
- TestAgentActiveTCP test is failing due to data race
- Active TCP performs network operations in main thread HOT 7
- Connection failing to TCP candidate when listening on multiple interfaces using `MultiTCPMux` and `NAT1To1IPs` HOT 5
- Noisy warnings if TURN/STUN host is not reachable via IPv6
- Panic when adding candidate HOT 6
- bug(log): webrtc using ice will print wrong log HOT 1
- ice v2 depends on transport v2.2.2, which had a breaking change HOT 1
- Candidate type is not changed from peer-reflexive to host HOT 1
- Allow users to pass custom 'CandidateSelectorControlling` and `CandidateSelectorControlled` HOT 3
- Please add a new release tag HOT 2
- Android 11 ListenUDP permission denine
- Support ipv6 for mDNS Server HOT 3
- Start the listening port by default above 1024 HOT 1
- Doubts about discarding monotonic time HOT 4
- Please add Windows test runner HOT 1
- build error unkown field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ice.