These tests

• pinf-proxy-js/test/proxy.js

  Lines 156 to 174 in 81cafdc

  	// TODO: Fix.
  	/*
  	it("can proxy HTTPS requests", function(done) {
  	return PROXY.newProxy({
  	enableForwardHeaders: true
  	}, function(err, proxy) {
  	if (err) return done(err);
  	return REQUEST(proxy.useForRequest("https://www.microsoft.com/robots.txt"), function(err, res, body) {
  	if (err) return done(err);
  	ASSERT.equal(res.statusCode, 200);
  	//console.log("body", body);
  	ASSERT.equal(/# Robots\.txt file for/.test(body), true);
  	return proxy.close(done);
  	});
  	});
  	});
  	*/

• pinf-proxy-js/test/proxy.js

  Lines 205 to 236 in 81cafdc

  	// TODO: Fix.
  	/*
  	it("can proxy sub-commands via `HTTP_PROXY` ENV var", function(done) {
  	return PROXY.newProxy({
  	enableForwardHeaders: true
  	}, function(err, proxy) {
  	if (err) return done(err);
  	var proc = SPAWN("curl", [
  	"-s",
  	"-v",
  	"https://www.microsoft.com/robots.txt"
  	], {
  	env: proxy.useForEnv(process.env)
  	});
  	var ok = false;
  	proc.stdout.on('data', function (data) {
  	console.log('stdout: ' + data);
  	if (/# Robots\.txt file for/.test(data)) {
  	ok = true;
  	}
  	});
  	proc.stderr.on('data', function (data) {
  	console.log('stderr: ' + data);
  	});
  	proc.on('close', function (code) {
  	if (code) return done(new Error("Did not exit clean!"));
  	if (!ok) ASSERT.fail("Not not get expected response");
  	return proxy.close(done);
  	});
  	});
  	});
  	*/

make HTTPS requests via request and curl with proxy property and HTTPS_PROXY env var set respectively.

Both connect to

One wants to connect over a TLS connection the other just plain NET.

Both send the CONNECT header but relaying data does not seem to work.

Also see: http://stackoverflow.com/questions/10876883/implementing-an-http-proxy

The goal is to have pinf-proxy-js be able to proxy all requests generated by attaching to request, http, https in nodejs and declaring HTTP[S]_PROXY in shell environment variables.

$limitation The impact of this bug on the pinf ecosystem is that assets fetched over HTTP and HTTPS cannot be sniffed for shell environments (as declaring HTTP_PROXY will also cause HTTPS requests to go through it) and for HTTPS requests using request with proxy set.