pikachusauvage / tpnote Goto Github PK

Should capacity_ content the space of '\0' ?

In an other way: shoud we do

new char[capacity_+1]

or

new char[capacity_]

why +1?

We can not keep this, plus it is defied as a public method. The copy constructor need to be redo. I suggest that we make a operator[ ] to replace.

//constructeur from a copy
String::String (const String& s){
if(s.size()<MAX_SIZE){
size_=s.size();
capacity_=getCapacity(size_);
data_= new char[capacity_+1]; // dpa OK
for(unsigned int i=0; i<size_;i++){
data_[i]=s.getChar(i); //getChar need to be replaced, can't keep this public method
}
data_[size_+1]='\0'; //size+1? should be size_
}
}

test.cpp:8:34: warning: format specifies type 'int' but the argument has type
'size_type' (aka 'unsigned long') [-Wformat]
printf("%s, %d, %d\n",h.c_str(),h.capacity(),h.size());
~~ ^~~~~~~~~~~~
%lu
test.cpp:8:47: warning: format specifies type 'int' but the argument has type
'size_type' (aka 'unsigned long') [-Wformat]
printf("%s, %d, %d\n",h.c_str(),h.capacity(),h.size());
~~ ^~~~~~~~
%lu

static size_t String::length(const char_traits* s)