phonegap / phonegap-app-stockpile Goto Github PK

Pasted from another project
From @hollyschinsky:

• Review/merge 3 outstanding pull requests for Split Panel template
• Implement any feedback from users of docs (Herm)
• Update a couple screenshots due to side menu background color change PR
• Add a blurb about the icons?
• Determining best location for docs based on current docs structure/side menu
• Blog post written
• If we include all templates in the announcement, one additional to do is to ensure they're all updated with the latest changes we agreed on in yesterday's call
• Add Adobe code headers to Stockpile

console, splashscreen, statusbar, and whitelist are all integrated into the platforms, or they are no longer needed.

• Does not work in PhoneGap Developer App

Platform:

• PhoneGap Developer App on iPhone 6

Steps to reproduce:

1. search for something new (so you don't have the result cached)
2. on search results screen, start trying to scroll before any results are displayed
3. search results will appear, but the results will not scroll

npm WARN deprecated [email protected]: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!

Add viewport-fit=cover to the viewport meta tag in index.html.

This won't allow full screen notch support, but it will at least eliminate the strange white borders.

Needs some sort of UX to allow more results to be loaded after the initial.

Currently only a console.log()

https://github.com/phonegap/phonegap-app-stockpile/blob/master/src/components/pages/Results.vue#L86-L89

This should at the very least show an error dialog... but it would be even better if it checked offline status and gave an appropriate error if that is the case.

We should add the following tag to index.html:

<link  rel="apple-touch-startup-image"  href="img/Default-Portrait.png">

and create an image to go with it. This will be used when the app is started from the home screen of an 🍎 device

Discovered this issue when I was trying to set up the deployment of the Stockpile on Firebase.

I had modified src/utils/config.js file on my local repo with my Adobe Stock API key.

I did not commit the changes in src/utils/config.js because I did not want to my Adobe Stock API key to be stored in the repository.

When I used npm run build to create the production build of the App for deployment on Firebase, it did not use my uncommitted version of src/utils/config.js, the build script used the last committed version of src/utils/config.js which contains a placeholder value for the Adobe Stock API key.

To get around this issue, I had to create a local branch and commit my modified src/utils/config.js before running npm run build to get the production build of the App to use my Adobe Stock API key.

REPRO:

• Search for cats
• try to scroll results, won't scroll
• pinch/zoom (even though it does nothing) or start to perform a swipe to go back, or even a swipe to open the menu
• will scroll

Possible F7 or F7/Vue bug.

Since the API does not always return as many results as you specify in the limit search parameter, some strange things are happening...

Repro steps:

1. Search for 'cats'
2. Tap on a cat pic in the results
3. Tap on the cat pic in the details screen
4. Tap on the cat pit to put the image in viewer mode (for pinch zooming, etc) -- this hides the navbar to display just the image
5. Hit the Android back button to go back to the details screen
6. The Material navbar will still be hidden

The navbar will only come back if you again tap on the cat pic in details, returning you to the image view screen, then tap on the image to show the navbar in view mode.

This seems to be a bug in F7, but I will confirm.

Needs:

• LICENSE
• NOTICE
• COPYRIGHT
• CONTRIBUTING.md
• Adobe headers?

Anything else?

Doesn't seem to be any good reason to keep the dynamic navbar title in https://github.com/phonegap/phonegap-app-stockpile/blob/master/src/components/pages/Search.vue#L7

It's not in use in the other Pages, so...

It would be a lot better if we could have that registration src as a file so that we could remove 'unsafe-inline' from the CSP to protect from XSS, etc.