Comments (2)
Good call! I think the problem was introduced in #518 (d0be551 according to bisect).
@ypconstante would you mind to take a look? I wrote a small test case:
defmodule Floki.FindWithBug do
use ExUnit.Case, async: true
@tag only_parser: Floki.HTMLParser.Mochiweb
test "correct order" do
assert Floki.find(
"<div class=\"first\"></div><p class=\"second\"></p><div class=\"third\"></div>",
"p,div"
) ==
[
{"div", [{"class", "first"}], []},
{"p", [{"class", "second"}], []},
{"div", [{"class", "third"}], []}
]
end
end
from floki.
Yeah, the stack change is causing this.
I did some checks and there are more cases in which we don't return the nodes in the right order, unrelated with this change
iex> Floki.find(
Floki.parse_fragment!("""
<div id="1">
<div id="2">
<p id="3"></p>
</div>
<p id="4"></p>
</div>
"""),
"div p"
)
[{"p", [{"id", "4"}], []}, {"p", [{"id", "3"}], []}]
from floki.
Related Issues (20)
- Unhandled error for Floki.parse_fragment/2 HOT 1
- CDATA inside a title tag is not handled in Mochiweb parser
- Is there a way to replace paragraph tags by newlines in Floki.text()? HOT 1
- Proposal: Add Floki.Doc HOT 10
- Drop support for Elixir 1.11
- Allow option to parse attributes as maps HOT 9
- Floki is extremely noisy in logs
- Support for :has pseudo selector
- Error after upgrading to 0.35.0 HOT 6
- Buttons in Header Section Lacks Transition!!
- Floki attribute example is ambiguous
- Proposal: optimized find for simple cases HOT 6
- Is it possible to get line/column number of a tag? HOT 4
- nth-child selector not working as expected HOT 8
- Floki.raw_html/2 no longer respects `config :floki, :encode_raw_html, false` HOT 1
- Add functionality to escape values in selectors
- Issue with an archive uploaded to hex HOT 3
- Empty tag attributes are not parsed correctly HOT 2
- issues with fetching floki as dependeny HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from floki.