Giter Club home page Giter Club logo

Comments (2)

philss avatar philss commented on June 7, 2024

Good call! I think the problem was introduced in #518 (d0be551 according to bisect).

@ypconstante would you mind to take a look? I wrote a small test case:

defmodule Floki.FindWithBug do
  use ExUnit.Case, async: true

  @tag only_parser: Floki.HTMLParser.Mochiweb
  test "correct order" do
    assert Floki.find(
             "<div class=\"first\"></div><p class=\"second\"></p><div class=\"third\"></div>",
             "p,div"
           ) ==
             [
               {"div", [{"class", "first"}], []},
               {"p", [{"class", "second"}], []},
               {"div", [{"class", "third"}], []}
             ]
  end
end

from floki.

ypconstante avatar ypconstante commented on June 7, 2024

Yeah, the stack change is causing this.
I did some checks and there are more cases in which we don't return the nodes in the right order, unrelated with this change

iex> Floki.find(
  Floki.parse_fragment!("""
  <div id="1">
    <div id="2">
      <p id="3"></p>
    </div>
    <p id="4"></p>
  </div>
  """),
  "div p"
)

[{"p", [{"id", "4"}], []}, {"p", [{"id", "3"}], []}]

from floki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.