Error after upgrading to 0.35.0 about floki HOT 6 CLOSED

I'm into it. @aselder Is it possible to provide a snippet so I can reproduce the error?

from floki.

from floki.

OK, thank you!

from floki.

@philss

Here’s some info that I think clarifies the root cause. I just tried to parse that html that was found to be bad on the one page:

<spanclass=\"trade\">™ curl gelée<br><br><br></spanclass=\"trade\">

With Floki 0.35.0, I get the same exact error we saw on production:

iex(3)> Floki.parse_fragment(f)
** (MatchError) no match of right hand side value: [{"=", "="}, {"\"trade\"", "\"trade\""}]
    (floki 0.35.0) src/floki_mochi_html.erl:257: :floki_mochi_html.norm/2
    (floki 0.35.0) src/floki_mochi_html.erl:241: :floki_mochi_html.tree/3
    (floki 0.35.0) src/floki_mochi_html.erl:120: :floki_mochi_html.parse_tokens/2
    (floki 0.35.0) lib/floki/html_parser/mochiweb.ex:10: Floki.HTMLParser.Mochiweb.parse_document/2
    iex:3: (file)

with Floki 0.34.3, it works:

iex(3)> Floki.parse_fragment(f)
{:ok,
 [
   {"spanclass", [{"=", "="}, {"\"trade\"", "\"trade\""}],
    ["™ curl gelée", {"br", [], []}, {"br", [], []}, {"br", [], []}]}
 ]}

So it was some invalid html that was not causing problem before, but after upgrading floki, it was an error

from floki.

@aselder thank you so much! It was a silly mistake of mine. I'm going to release a patch version soon :)

from floki.

Done! Please try the version 0.35.1 :)

from floki.