philippwassibauer / django-activity-stream Goto Github PK

Hi Philipp.

I have gone through the documentation of the plugin and keep running into the same error.

As soon as I set my variable get_people_i_follow in my settings.py file it keeps raising an error.

Caught NameError while rendering: global name 'get_people_i_follow' is not defined

Then if I import the get_people_i_follow, manage.py raises it's ImportError.

Any ideas?

Hello,

i was using the following code:

create_activity_item('updated_project', user, project_and_role.project, data=projec_role)

being 'projec_role' a django model with foreigns keys, and the SerializedDataField was not saving the data correctly. Was saving values like '128', '129' in the database and rendering on the templates was resulting on "indentation" errrors.

my solution was to wrap the object on a dictionary and it worked :

data = {
    'project'   : project_and_role.project,
    'role'      : project_and_role.role,
    'person'    : project_and_role.person,
}

best

The get_people_i_follow() and get_my_followers() functions both use order_by('?') - this is an extremely inefficient database operation. It looks like this is being done to emphasize the non-ordered nature of the data, in which case I would recommend calling Python's set() function on the queryset instead.

It has:

followers =  ActivityFollower.objects.filter(from_user=user).all()[offset:count]

etc., which should be:

 followers =  ActivityFollower.objects.filter(from_user=user).all()[offset:offset+count]

Hi,

I found an error in your activity stream,

def to_python(self, value):
if value is None: return
if not isinstance(value, basestring): return value
value = pickle.loads(base64.b64decode(value))
return value

ERROR:
return base64.b64decode(value)
File "/usr/lib/python2.6/base64.py", line 76, in b64decode
raise TypeError(msg)
TypeError: Incorrect padding

This works for me:

def to_python(self, value):
    try:
        if value is None: return
        if not isinstance(value, basestring): return value
        value = pickle.loads(base64.b64decode(value))
        return value
    except TypeError:
        return value