Giter Club home page Giter Club logo

piano-trainer's Introduction

SheetMusicTutor is a web app which allows practicing sheet reading skills right in your browser. Currently, there are two different modes:

  • Pitch reading training
  • Rhythm training

The pitch reading training mode uses the Web MIDI API. Connect your piano via MIDI to your computer and play the displayed notes. The generated notes won't be typical chords in a typical combination. So, you can't rely on intuition or experience. Instead you must read the correct notes.

Read more in this blog post.

On the contrary, the rhythm training mode can be used without a keyboard. Just tap the given rhythm with your space button or on your touch screen.

SheetMusicTutor is written in ES6 and React, uses Vex for rendering the sheets and Chartist for rendering the graphs. The tests are executed with Jasmine/Karma on Travis.

How to use the pitch reading training

Currently, the Web MIDI API has very limited browser support. Try Chrome (at least version 39) and activate the experimental enable-web-midi flag (chrome://flags/#enable-web-midi). After connecting your MIDI device to your computer, it may be necessary to restart Chrome. Additionally, make sure that no other software is reading from the device. Finally: Just visit the GitHub hosted Piano-Trainer.

If you want to run SheetMusicTutor locally, checkout the repository and execute npm install and npm start within the folder.

License

MIT © Philipp Otto

piano-trainer's People

Contributors

graham42 avatar mjay avatar philippotto avatar shimondoodkin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

piano-trainer's Issues

After 6000 notes app becomes laggy

Using sheetmusictutor.com local data is saved between page visits. Over a longer period of time the amount of data continues to grow. At over 6000 notes played the webapp becomes sluggish and the time from playing a note until it being recognized increases to a point where it's not very usable.

Use MIDI device names rather than just numbers

Right now Chrome finds five MIDI devices connected to my computer and it can be annoying to figure out which is the one I'm looking for. If instead the MIDI device names were used this would be much more intuitive.

Allow selecting MIDI input device

My OS has chosen the piano as 2nd MIDI input device next to some other one for whatever reason.

So allowing to select the MIDI input device would be nice.

Key select drop-down menu

Hi,

Sweet app! Thank you for this :)

Would you accept a key select drop-down menu in the UI? If the user selected a key, the generator would only produce notes in that key. The idea is that training can be boring, so it would be fun to play your favorite music in the background and "play along" in the trainer in the key of the background music so that the notes played are a reasonable match for it.

BR,
Lassi

Better document dev info

In my PR I added a "How to contribute" section which just makes it easier to see the compilation info. Some more documentation could make contributing a bit easier.

For example, right now I see there's CI setup and it appears to be doing some kind of linting. It'd be nice if how to run this linter was documented.

Flat/Sharp notes

First of all, this is an awesome project and I hope that it is not abandoned yet.

I noticed that it helped me a lot, but I miss generation of flat/sharp notes.
Also, I would like an option to change the scale.

So I suggest to add:

  • Possibility to change the base scale
  • Generation of notes outside of the current scale (with lower probability)

Incorrect Note Stem Direction

It appears that all note stems on the treble clef staff are pointing up. The following algorithm can be applied for the treble clef staff:

  1. If note is below line three (3), stem direction is up.
  2. If note is on or above line three (3), stem direction is down.

The following is an excerpt from How To Read Sheet Music: A Step-by-Step Guide:

The note stem is a thin line that extends either up or down from the note head. The line extends from the right if pointing upward or from the left if pointing downward. The direction of the line doesn’t affect how you play the note but serves to make the notes easier to read while allowing them to fit neatly on the staff. As a rule, any notes at or above the “B” line on the staff have downward pointing stems, those notes below the “B” line have upward pointing stems.

Reset level when using automatic difficulty

It would be nice to have an option, to reset the level when using automatic difficulty.
Currently when doing too many mistakes, the level will reset to 1 but go right back to where you've been before, e.g. 8.

If someone wants to start over, there is currently no option to do so (aside from deleting the cache, I guess?)

Also the automatic difficulty could be done in a more sophisticated way, going down only one level after too many mistakes, instead of jumping between levels 1 and MAX_REACHED.

Great project, btw.!

Adjustable lowest and highest notes

As it currently is (judging from the version at sheetmusictutor.com), there's no way to limit the range of notes that can be displayed. This isn't a problem if you're using a full keyboard, but if you're working with something much smaller like a little 25 keyboard you'll quickly run into notes you can't play.

Would you accept a PR to add two new settings for a lowest key and highest key? I'm thinking to start they could be drop down lists, but having additional MIDI learn buttons would be even better.

Jazz chord symbols support

First thanks a lot for creating this amazing repository! I was about to create something like this for my Jazz chord practice before I found it! There are however two features I am currently missing compared to the version I had in mind:

  • Jazz chord notation (symbol notation) support.
  • Multi bar support.

Jazz chord notation (symbol notation):

With this I mean the notation that is often used in lead sheets (see this document):

image

Multi bar support

The ability to see more bars in advance when training (For example one line of 4 bars). I think by doing this both sight-reading and eye scanning would be trained.

I'm happy to develop these features if there is support from the community.

UI Suggestion

Hi Philipp,
I really love what you've done here with this app. My only suggestion would be to add a "minimal view" option. For example, when practicing I find the background image and side widgets a bit distracting. I'd love to have the option to see just the score and a white background.
Thanks,
Ben

Local website broken in node 8 and 14

I tried setting up this project locally but unfortunately, the website is not displaying. After following the instructions in the README.md I get the following error when running npm start:

Uncaught SyntaxError: Cannot use import statement outside a module

Does anybody know with which npm versions this project is working?

Current system information

OS: Ubuntu 18.03
node version: 8.17.0 and 14.13.0
npm version: 6.13.4 and 6.14.8
firefox version: 81.0
chrome version: 85.0.4183.121

30 second time limit discards valid data

Given a user who takes longer than 30 seconds rather often, a substantial chunk of valid data is discarded.

e.g. I've been studying piano for <60 hours (~45-55) and these (because they're outside the normal introductory playing range etc.) take anywhere from 12-40 seconds

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.