philc / vimium Goto Github PK

Currently we have a command-buffer length of two keystrokes. Typing an unrecognized keystroke will make it so the next keystroke is ignored by our system.

Instead, the command interpreter should throw out the first keystroke if it's not part of a command.

Additionally, even if the first keystroke was potentially a valid part of a command, if the second keystroke does not complete a valid command, then only the first keystroke should be deleted from the buffer, not the second, as it may constitute its own valid command or it may be the beginning of a different valid 2-keystroke command.

We may need to snapshot the tab during the chrome.tabs.onRemoved event instead of the D keystroke, although I'm not sure if at that point we can capture the page's URL, scroll position, and window ID.

None of the keybindings seem to work. All I get is a little notice in the bottom indicating when I'm in 'Insert mode'. Chrome version is 4.0.429 and Vimium version is v1.11.

See if everything works under windows.

This is so you can pass-through one keystroke into the page or browser which Vimium will ignore.

Otherwise the flash embed will interpret our command keystrokes. This is frustrating because you think you're interacting with the flash app but typing "d" for example will close the tab because Vimium is still listening to the keystrokes.

Hit J or K to scroll up and down the page; it scrolls multiple times.

http://www.graniteds.org/confluence/display/DOC/6.+Using+Flex+Builder+3

Some sample sites that don't work for me: cnn.com, nytimes.com, linkedin.com

Can you take a look?

When a vimium keybinding is detected, you should probably (somehow) call back to the page to set event.preventDefault();

Phil - Sorry if this is a naive question, but, being new to google chrome, I haven't been able to figure out how to install vimium. I haven't found any installation instructions and don't know google-chrome well enough to know where to put the files (from philc-vimium-1f6f81d.tar.gz). (I tried putting the files under 'resources' under the google-chrome installation on my system, but that did not work.)

How do I install vimium to work with chrome?

Thanks!

This is so you can pass-through all keystrokes into the page or browser which Vimium will ignore. This mode can be exited by hitting escape.

Look into this ..

People are starting to find us -- we need at least a list of commands so they can get started.

See this URL:
http://habrahabr.ru/

Examples include commas colons and spaces.

Currently zoom only affects the top-level page. This is because our content script is not running on iframes. See d6b95ff for more details.

Ideally the iframes would receive their default zoom-level setting from the top-level page, and they would be zoomed any time the tab's top-level window is zoomed.

You can use tab to switch between inputs in a form; insert mode will toggle off and on as you switch.

Currently it leaves you in command mode with / on the prompt.

http://dobrochan.ru
https://mail.google.com
and other

From our chrome extensions gallery page:

A big annoying problem using:

• Vimium 1.1
• Google Chrome 4.0.249.43
• Ubuntu 9.04.

After setting exclusion list sites, pages are loaded at 240% zoom.

Except that, it works great here. :-)

The links to reviews on this page are not accessible via link hints:

http://www.metacritic.com/games/platforms/xbox360/masseffect

It seems like the find UI should give you more feedback when there are no matches. Currently it highlights a partial match of what you were typing, but doesn't tell you there are no exact matches.

Also note that in the long term, we might want to try and trigger Chrome's native find interface if possible, since they're doing a lot of this work already.

HItting command F enters link-hint mode. As a general rule, we should strongly avoid clashing with the native browser UI. We should instead enter insert mode when the user enters CMD+F to pull up the find dialog.

What's weird is that this bug shouldn't currently manifest, because I remember we ignore any keystrokes that have CMD as a modifier.

just downloaded the dev channel version of chromium for mac, and downloaded 1.1 of vimium - installed, but no dice, no key commands I've tried work. Any suggestions for things to try? Happy to try and debug if I know where to start...

Tabbing to an element and typing a letter to select a value (e.g. a state name) will have those keystrokes interpreted by vimium.

Some of our commands use chrome.tabs.getSelected, which assumes that the tab that's executing the command is focused. This can break down if say you open a new tab in the background by middle clicking on a link. I've changed a few of the commands in commit b04b03, but I'm not sure which other commands need to be changed. We also might want to take this opportunity to switch a few of these to the new one-time messaging system as you noted in bug #8, which should reduce the amount of code we need for messaging.

URL manifesting:
http://www.hulu.com/house

Want "map y н" etc...

also
want ":" commands mode

upd:
hinting don't work in http://dobrochan.ru and other keys (hjkl)

To reproduce, go to this page:
http://www.google.com/search?hl=en&q=chrome+ui+font+mac&aq=f&oq=&aqi=
And using our find interface, type "customizing". You'll see that the text selection jumps back and forth between the two occurrences of "customizing"

Right now, if you close a tab in one window and then hit U in another window, the tab will be restored there. It's arguable if that's correct behavior or not, but Vimperator does this on a per-window basis.

http://www.w3schools.com/jsref/jsref_obj_string.asp

TypeError
arguments: Array
0: "appendChild"
1: null
message: "Cannot call method 'appendChild' of null"
stack: "TypeError: Cannot call method 'appendChild' of null at Object.displayElement (chrome-extension:/…"
type: "non_object_property_call"

Example: search.twitter.com

focusNode is a div with two elements (the input box and another div). focusOffset is 1 (pointing to the div) instead of the expected 0 which would point to the input box.

1. Open a new tab.
2. Navigate to google.com
3. The search box is selected but we're not in insert mode.

Currently we only use the characters ASDFJKL. We should use more so that it's less likely we need 3 characters to display hints for all links on a page.

Any keys that Vimium itself will interpret should not be sent to the webpage. Hitting J and K on the Commits page of github will highlight the next/previous commit (implemented by github) in addition to scrolling the page (implemented by Vimium).

When navigating to a text field via link hinting, the cursor should be placed at the end of the text field's contents instead of selecting the contents.

It looks like content scripts no longer execute on view-source: and we can't put it in the manifest as it throws an error. I've asked on the mailing list -- will update with more information as I get it.

On page load, this this thows a javascript error:
http://failblog.org/2009/11/13/friday-rewind-cop-fail/

chrome-extension://mbgolajmfflanenogmhbaneckaimemea/vimiumFrontend.js:91Uncaught TypeError: Cannot read property '38' of undefined

Line 91 is currently
if (focusNode && focusOffset &&
isInputOrText(focusNode.children[focusOffset])) { enterInsertMode(); }

I had to try it a few times to see the error, but often the vimium hotkeys do not work on this page.

Looks like there's a new API for one-time requests. Ports are to be used for more persistent, long-running communications. Some of our port calls can probably be converted to one-time requests.

Reference: http://code.google.com/chrome/extensions/messaging.html

Typing / does not pull up the find dialog.

The zoom in sequence "zi" does not work because the command processor never gets a chance to see the "i" key. Seems like the frontend needs to be able to ask the backend if that "i" is part of a recognized shortcut, and if so, avoid entering insert mode.