phikal / 4jhan-server Goto Github PK

Why use JSON for it?

You can't even have comments and have to add "" everywhere.

Needs some work.
When accessing some thread that doesn't exist anymore:

TypeError: Cannot set property 'thread' of undefined
    at Statement.<anonymous> (/home/under/4jhan-server/lib/sqlite.js:49:21)
--> in Database#all('SELECT * FROM comment WHERE op = ?', '1', [Function])
    at Statement.<anonymous> (/home/under/4jhan-server/lib/sqlite.js:47:8)

Any chance to see a working instance? Don't have a node stack installed at the moment (lazy).

Currently images, although the thread has been deleted, aren't. This leads to images being saved although not referenced to in threads. Needs to be fixed to save storage.

If MongoDB isn't a deal breaker, you could drop it and manage three different DB systems (Postgres, MySQL and SQLite3) once with Knex.js. I have used it before and it would fit nicelly with 4jhan.

Because mantaining four (as PostgreSQL support is planned) DB systems doesn't sound nice at all, especially when one of them is noSQL.

I couldn't test if http works yet, so it would be nice if someone with certificates could.

Using testing branch, they're at the same size that original image's.

That's strange, because the code seems right.

Any reason to don't do thumbnailing?

I could do it.