Giter Club home page Giter Club logo

flc's People

Contributors

brunocalado avatar lozanoje avatar madereddy avatar phenomen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

flc's Issues

AV Alert

Hi.

The AV is generating an alert:

image

Feature Request: Zoom option

I understand the goal is to keep the client simple, but it would be very useful to include a zoom feature.
For example, I typically am using a laptop and reducing the zoom to 80% allows me to reduce the size of the UI and see more of the canvas.
Thanks for considering this request. I think this project is great.

Set FLC to High Performance Mode

Not exactly an issue, but maybe a feature request. When launching FLC it says in green that High Performance GPU is available, but using that GPU is quite a hassle to get setup. I'm using Windows 11 23H2 on a MSI Creator Z16, RTX 3060. If I go into Display Settings and manually add FLC and manually set it to High Performance Mode, it still uses my Intel UHD GPU. The only way I've been able to use High Performance Mode is by adding msedgewebview2.exe and setting that to High Performance Mode. This works and is fine, but msedgewebview2.exe is installed a version specific folder (e.g. 120.0.2210.91) and if it gets an update then the folder name changes. I then have to go back into Display Settings and re-add the .exe and set it to High Performance Mode. I have to do that on each webview upgrade. So the feature request would be an easier way to enable High Performance Mode for the app.

I also just realized that when msedgewebview2.exe is set for HPM, it only uses HPM for "Copy", but still uses my Intel UHD for "3D" according to Task Manager and looking at the GPU Engine for that process. I can see it switching back and forth between GPU 0 and GPU 1.

[FR] Add confirm exit

is it possible add a pop up for close confirmation before close it to avoid close by mistake?

Saved ip's bug

Somehow I've saved bugged ip adress and now everytime I launch FLC I get empty screen and this error in console:
image
Would really like to know how to purge saved ip's. Reinstalling didn't help.

Node.js option

To specify different userdata folders to have several Foundry installations for testing.

Edit: and a checkbox to autoload localhost:port (the one specified at config.json of userdata) in flc when server starts

Edit 2: allow to add to favourites different configurations to different foundry versions (foundry directory) and userdata

This will help having different foundry versions with different userdata folders

Linux support

No issue - works fine on my windows machine but I'm interested in linux support :)

[Feature] Save Password

Hi,

it would be nice to have the chance to save a login password with autofill for a server. This is especially worthit if one is using cryptic passwords. Thank you for the client!

Have a nice day

Cannot connect with self-hosted foundry with proxy and ssl

I've got interested in the project since one of my players cannot use Foundry from a browser. I love it, and I started using it (and recommend all my players to use it tbh).
Apart from some functionalities I'm missing, but this is not about them, I have the following problem,

I'm hosting my Foundry in Oracle Cloud and it is set up with SSL and Nginx. It couldn't detect that my server is on (/api/status), it seems there were 2 reasons for it:

  1. Nginx was responding with 400 automatically, due to the API call not containing the Host header.
  2. Tauri Fetch didn't recognize the SSL certificate I'm using (not self-signed or anything like that, and I haven't yet seen problems with this certificate)

My workarounds were:

  1. Adding "Host": new URL(server.host).hostname into the headers of API status call
  2. Replacing tauri_fetch with plain fetch (+ small amount of following changes needed for this to work)

Those worked (and my group is using my custom build of 2.9.5), but since this thing is being updated I thought I should share those problems. I can make a PR for that with my changes, although I didn't test them against other foundries, at least yet.

FLC doesn't work with reverse-proxies using a path

I was taking a look at your application that was posted on Reddit and noticed that you advertised that it can connect to HTTP(S) servers. I have a few Foundry installs I use myself and use sub directories off of my site to proxy them to. This feature is supported by Foundry themselves as you have to edit a config value for it to work, and while a more advanced use case, I can see it breaking some other setups too.

To reproduce setup a FoundryVTT install behind a reverse proxy such as Nginx with a path.

Example of an Nginx config that would allow this:

 location /vtt/ctg {
     proxy_read_timeout 90;

     client_max_body_size 500M;

     proxy_set_header Connection "Upgrade";

     proxy_headers_hash_max_size 1024;
     proxy_set_header Upgrade $http_upgrade;
     proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
     proxy_set_header X-Forwarded-Proto $scheme;
     proxy_set_header X-Real-IP $remote_addr;

     proxy_pass http:/localhost:31005;
}

The config lines for Foundry that need to be adjusted for this are as follows (this is assuming an HTTPS reverse proxy):

{
   ...
    "hostname": "example.com",
    "localHostname": "example.com",
    "proxyPort": 443,
    "proxySSL": true,
    "routePrefix": "path/to/foundry",
   ...
}

If I can assist by providing any more information or testing let me know!

Zoom/Pan Mode doesn't work in FLC

Activating Zoom/Pan Mode from module Zoom/Pan Options (virtually required for touchpads to work in Foundry) does not allow pinch to zoom, two-finger pan.

Notebook Friendly

Hi.

Control + +/- or PageUP/PageDown don't work. This is important for notebook users without the mouse.

tks

Dependabot Alerts Enabling

Dependabot alerts should be enabled for this project along with basic CodeQL scanning. I forked this repo and enabled Dependabot and found PostCSS needed to be updated. Dependabot will automatically create PRs that can be merged without taking extra time. The PostCSS example below:

An issue was discovered in PostCSS before 8.4.31. It affects linters using PostCSS to parse external Cascading Style Sheets (CSS). There may be \r discrepancies, as demonstrated by @font-face{ font:(\r/*);} in a rule.

Display issues at 2560*1440 resolution

Works OK on my 1080p monitor but when maximising on a 1440p monitor the top of the screen shows a black bar, and the title bar and its button become unresponsive (including close button).

image

Feature Request : add the ability to run a limited list of plugins

For GMs, if would be nice if FLC could allow a dev mode to install chrome plugins such as Beyond20, Rivet and other plugins that are used by GMs for prepare and run their games. Iโ€™m aware that this would go against the no-bloat principle of FLC, but it would be still be better then running out of Chrome of other browsers. Thanks !

High Memory Usage

After 6+ hours of usage as a GM the memory usage will be at 8GB or more and FLC slows way down. If this is inherent of webview2 or Foundry then close this issue.

About early FLC 4.0 release

I had to push an early release of the FLC 4.0 due to a security vulnerability found in the older version of Tauri (a framework that powers FLC). If you used FLC just for Foundry and not to browse shady websites, then there is nothing to worry about. But just in case, I decided to patch it ASAP.

This version is a full codebase rewrite, and it's not complete at the moment. Some features are missing โ€” notably a Server Status Check and Node Server Launcher. Also, UI is very incomplete. But I felt like security of users is more important, so I pushed the update.

I will add missing features and polish a UI in coming days. Sorry for the inconvenience! Let me know if there is something you want to see in FLC since with a new modern codebase it's now much easier to add features.

Not selecting dedicated GPU on laptop

I'm using FLC on a laptop, and I've not been able to get the computer to use the dedicated Nvidia GPU in the laptop, it always defaults to the intel integrated graphics chip. This happens regardless of whether I try to force it to use the Nvidia chip with both Nvidia control panel and windows graphics settings.

I'm not sure if there's a way to build the exe such that windows recognizes it automatically as a "graphics heavy" application and uses dedicated graphics by default, but if so that'd be really useful.

Hardware:
i7-8550U, 16 GB DDR4 RAM
intel UHD Graphics 620
Nvidia MX150 2GB

full screen

I don't see the possibility to make it full screen. It's a problem if you stream the screen. Maybe I didn't see it but with f11 it doesn't work.

Can't use it

I really like the idea of a lightweight browser just for foundry but I can't use it

image

I haven't got this problem on chrome or firefox, what can I do?

Aliasing issue on SVGs and images

In a new DND5e world with no mods active.

Screenshot taken from FLC:

image

Screenshot taken from Firefox/Chrome:

image

As you can see the FLC image is more pixelated. This issue extends to other images too:

image

I've seent his happen in the past and I think it was a Chromium issue? But I cannot reproduce this in Chrome or Firefox now. Seems to only occur in FLC.

HUD Scale

Hi.

Can you add the possiblity to scale the HUD? Like a regular browser.

tks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.