phast184 / link-checker-tool Goto Github PK

just ignores these all together
thanks

It would be beneficial to add an installation instruction to your README.md file. Here is what I think it should be so that it can be installed globally on the users computer:

Installation

1. Download the tool anywhere on your computer
2. Start up a command prompt window and go into where the tool is
3. Enter npm install -g to install the tool globally

This can be put any where but I think it should go between features and usage.

There's a new way to iterate through the list that will make sure you're never out of range or have to worry about the element number

You can change it to something like below

for (const url of validUrls) {
  checkUrl(url)
}

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of

Hi, I would like to add a feature where user can include a file with list of URL that they want to ignore while testing your tool. Lemme know what do you think? 😃

According to the comments at the top using -f option means file, but you're only checking a link here in lines 82-84. Shouldn't this be separated to either lct -u link or lct -f fileName?

This way you won't have to check argv.f when checking if there's a url and only check for typeof in your else if statement

Since it extends incredibly far off the screen, I think you should consider concatenation on the string so that it is easier to read and the person viewing your code doesn't have to scroll a long way to the right just to read it

The README is not clear. I followed the instructions and the output was:

I think it would be beneficial for the user to see the different unknown errors as during my testing I found that the links that ended up here were marked as malicious. Below is the change I would make so it's yellow instead of grey like the other unknown error.

Should be around line 76-ish

console.log(chalk.rgb(255, 204, 51)("[UNKOWN][ENOTFOUND] " + url));

The commands listed in your instructions were inoperable on my end:

However, I was able to run the program using:

node link-checker.js -f index2.html

When I tried to install your tools using npm link, it gave me error saying "No such file or directory." I dig deeper and found you provided wrong path in package.json in the bin

  "bin": {
    "lct": ".src/link-checker.js"
  },

Your link-checker.js file is not in src folder. I changed it in my issue #10.
You can see it here also:
https://github.com/sanji11/link-checker-tool/blob/f43f96e7f3d0d2435823b11646b78ac01f73cfab/package.json#L5-L7

Support --all, --good, and --bad flags. The --all flag is the default, and if none of these are present, it will display good and bad URLs. The --good flag causes only good URLs to get displayed; the --bad flag causes only bad URLs to get displayed.