Comments (2)
Hi @apetkau,
Thanks to yours comments, I take time to answer to learn python and oriented object programming to understand your work !
My first conclusion was the same as you.
- Instead of using the
get_available_organisms(cls)
method maybe theget_organisms(cls, database_dir)
already existing do the job ! It use the information from theconfig
file into pointfinder directory and you already created a test to check diff betweenorganism
I'm just trying to understand how to refer to the new method - Then for pointfinder nucleotide analysis, I will try to translate all nucleotide position into positive value (as you mentioned for promoter region with negative position) to be use in your code. I think some changes in the
CodonMutationPosition.py
to be more flexible ?
from staramr.
Hello @pimarin,
That's awesome you've taken the time to learn Python and Object Oriented programming 😄. I hope it is going well for you. I can be a very useful language to learn. Another important library I use throughout staramr is pandas for manipulation of data in Python (in particular, loading and working with CSV files or other tabular data structures). And then, while I don't use these in staramr, this could lead into learning about matplotlib or seaborn for creating visual plots of data. But this is all quite a bit to learn (and is a bit outside of what staramr handles).
-
Yes, the
get_organisms()
method is used to load up all the PointFinder organism name available in the currently-installed version of the PointFinder database:staramr/staramr/blast/pointfinder/PointfinderBlastDatabase.py
Lines 86 to 94 in fd4c230
Just to clarify, the reason I use
get_available_organisms()
instead ofget_organisms()
to return a list of organisms to use for PointFinder is because anything not returned byget_available_organisms()
is not guaranteed to work in staramr. That is it was a decision I made to prevent staramr from returning potentially invalid results. This particular issue would be a compromise where instead of disallowing people from runningstaramr
with organisms not returned byget_available_organisms()
, I would simply print a warning. -
Thanks so much for offering to help out with looking into supporting those other coordinates for PointFinder databases (negative coordinates or insertions/deletions). I really do appreciate it. I would welcome any contributions you can make.
However, note that I have someone in my group who will be looking into this issue too. I want to be a bit more open about my plans for staramr, so I have started to write up my plans in the Projects section of GitHub. There are two projects you can see here:
- Release
0.8.0
: This will update the default databases for staramr and I will try to include fixing this issue (where you can run staramr with other PointFinder organisms, but you will get a warning printed). - Release
1.0.0
: This will include full support for other PointFinder organisms by supporting insertions/deletions/promotor regions leading to AMR.
I hope this all makes sense? Again, I would welcome any suggestions or contributions you may have. But we do plan to work on fixing up some of these issues and packaging them up into new staramr releases.
- Release
from staramr.
Related Issues (20)
- AttributeError: 'float' object has no attribute 'split' HOT 5
- start and end position HOT 1
- ERROR: ('Error, plasmidfinder database type [{}] is either incorrect or plasmidfinder database not installed properly', 'enterobacteriaceae') HOT 2
- The plasmidfinder.tsv shows that there is no plasmid present HOT 4
- Duplicated resfinder hits with update to database HOT 5
- cant run staramr HOT 3
- an unexpected keyword argument "inplace" and can't out the "results.xlxs" HOT 3
- Update Plasmidfinder DB HOT 1
- Update StarAMR documentation HOT 1
- Add PointFinder "Required_mut" column to pointfinder.tsv results HOT 1
- Add option to specify database path HOT 4
- different percent identity/alignment length for identical sequences on opposite strands HOT 5
- ERROR: the local id is too long or OSError: [Errno 39] Directory not empty: 'input-genomes' HOT 3
- Update MLST references in README
- docker image v0.8.0 does not accept --user HOT 3
- conda install gets an old version which does not run well HOT 4
- AttributeError: type object 'object' has no attribute 'dtype' HOT 4
- Dashes in updated pointfinder db cause crash
- A Full Set of pbp5 Ampicillin Mutations are on the Threshold of the Default Percent Identity
- Adding more databases HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from staramr.